Repository navigation
Read the same year's income for the Ohio homestead exemption - #11161
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11161 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 24 11 -13
=========================================
- Hits 24 11 -13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
hua7450
left a comment
There was a problem hiding this comment.
Thanks, David. The single-year fix is right: on main a household run with no prior-year input read 0 and qualified everyone, and Cases 15 and 16 now pin the <= at 41,000 through the real income chain. The 2025 and 2026 limits (40,000 and 41,000) are dated by tax year, as the Department's table has them. One fix before I approve, and it is wording only.
Before merge
- Describe this as a same-year proxy, not a re-booking. R.C. 323.151(C) counts income "for the year preceding the year in which application ... is made", so tax year Y tests modified AGI of Y-1 against the limit for Y. The formula now tests Y against Y, with the limit, amount and age all still read for the tax year. The documentation says the model "books the homestead exemption to that income year", which would need next year's limit and amount: 2025 modified AGI of 40,500 qualifies for tax year 2026 in law (limit 41,000), but the model tests it against 40,000. Please reword the documentation, the formula comment, the YAML header and the changelog the way
or_tax_before_credits_in_prior_yeardoes ("defaults to the current year's ... as a proxy"), and say that a known prior-year figure goes in throughoh_homestead_exemption_total_income(Case 8 already shows the override).- Case 2's new name ("prior-year Ohio modified adjusted gross income under the limit does not qualify a filer over it") states the reverse of 323.151(C). Cases 1 and 2 should be named as the proxy default.
- The changelog says microsimulation read an empty prior year. With the default 2024 dataset, 2025 and 2026 runs on main had prior-year data, so the fragment should claim single-year runs only.
Optional
- Owners exempt from the income test. With the limit now binding, owners who had the reduction for tax year 2013 or 2006 (323.152(A)(1)(b)) are denied. Only the PR body records this; a comment at the income test in
oh_homestead_exemption_eligible.pywould keep it with the code. - An issue for the departure from the statute's income year, so it stays tracked.
- Tests. Case 3 in
oh_homestead_exemption_total_income.yamlcovers the same class as Case 16 inoh_homestead_exemption_eligible.yaml, which is the boundary case.
The total income for the homestead exemption read Ohio modified AGI for the prior year. With only one year of inputs, as in household runs and microsimulation, that read returned 0, so the income limit never applied. R.C. 323.151(C) uses the year before application; PolicyEngine books the relief to that income year, so the exemption now reads the same year's Ohio modified AGI. Moves the one-year-of-inputs case from the #10812 audit, adds cases at and one dollar above the 2026 income limit, and restates the two-year total income cases for the same-year read. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…same-year proxy - Reword the oh_homestead_exemption_total_income documentation and formula comment: R.C. 323.151(C) uses the year before application, and the model defaults to the current year's Ohio modified AGI as a proxy, which an explicit input overrides (same pattern as or_tax_before_credits_in_prior_year). - Rename total income test Cases 1 and 2 as the proxy default; inputs and expected values are unchanged. - Limit the changelog fragment to single-year runs and use the proxy framing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
71a1a1c to
68d5ce0
Compare
|
Thanks, Ziming. Fixed in 68d5ce0, rebased on main. Fixed (your "Before merge" item)
Skipped (optional, not in this round): a comment on owners exempt from the income test under 323.152(A)(1)(b), a tracking issue for the income-year departure, and the duplicate Case 3. Verification: the Ohio homestead exemption tests pass locally (32/32) after the rebase. An independent check confirmed all three items and found no other changes. Ruff is clean. |
hua7450
left a comment
There was a problem hiding this comment.
Thanks, David. The documentation, formula comment, YAML header and changelog now describe the same-year read as a proxy for R.C. 323.151(C)'s prior year and point to oh_homestead_exemption_total_income for a known prior-year figure. Cases 1 and 2 are named as the proxy default with main's inputs, and the changelog claims single-year runs only. Comparing the PR's own diff before and after the rebase, those wording changes are the only ones. Approving.
Part of #10812 (state credit income audit).
What was wrong
oh_homestead_exemption_total_incomereadoh_modified_agiatperiod.last_year. Inputs carry forward in policyengine-core, not backward, so the prior year has no data in a single-year household run. The read then returns 0, and the homestead exemption's income limit never binds: every aged, disabled or surviving-spouse owner passed the income test whatever their income.What changes
or_tax_before_credits_in_prior_yeardoes, so the exemption for year Y tests year Y's income. A known prior-year figure goes in throughoh_homestead_exemption_total_income(eligible Case 8). The variable'sdocumentationand the formula comment say that the law uses the prior year and the model uses the same year as a proxy. The authenticated statute PDF is added as a second reference; the existing reference is kept.income_limit.yaml).oh_homestead_exemption,oh_homestead_exemption_eligible,oh_homestead_property_tax_reduction,oh_homestead_exemption_qualifying_surviving_spouse). None reads income for another year. Age, ownership and residence timing are left as they are.Who is affected
Ohio homeowners who qualify by age, permanent and total disability or as a qualifying surviving spouse, in single-year household runs without prior-year income:
oh_homestead_exemptionandoh_homestead_property_tax_reductionfall to 0. On main they always passed the income test.oh_modified_agifor two years is now tested on the exemption year's value instead of the prior year's.No other variable reads the homestead variables, so Ohio income tax and household net income don't change.
Tests
Moved from #10812 (into
oh_homestead_exemption_total_income.yaml):Added (in
oh_homestead_exemption_eligible.yaml), both from wages so they run throughoh_modified_agi:Existing tests changed:
oh_homestead_exemption_total_income.yamlCase 1: inputs unchanged (oh_modified_agi35,000 in 2025, 99,000 in 2026); expected value 35,000 → 99,000, the 2026 value, since the 2026 exemption now reads 2026 income. Renamed as the same-year proxy default.oh_homestead_exemption_total_income.yamlCase 2: inputs unchanged (39,000 in 2025, 60,000 in 2026); expected value 39,000 → 60,000 for the same reason. Renamed from "current-year ... is ignored", which is now the reverse of the rule.oh_homestead_exemption_eligible.yamlCase 8: renamed from "prior-year total income controls eligibility" to say that a total income input overrides the same year's modified AGI. Inputs and the expected value (ineligible) are unchanged.Not in this PR
The #10812 review lists no other Ohio gap. The audit notes two points this PR leaves alone:
axiom: n/a: same-year proxy only; the legal rule in R.C. 323.151(C) is unchanged, and rulespec-us has no R.C. 323.151 module
Tested on Modal: run
w1-oh-a, 227/227 passed (every Ohio test file, every partner test file, andtest_source_conflicts.py).🤖 Generated with Claude Code