Repository navigation
Conversation
MaxGhenis
marked this pull request as ready for review
November 16, 2026 20:37
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP: Correct New Jersey's pre-2018 property tax deduction cap.
Fixes #11043
This patch applies a $10,000 ordinary general cap for 2015–2017 and $15,000 from tax year 2018. It adds two dated nodes and four historical references, preserves all existing metadata and 2021+ values, and leaves the formulas and deduction-versus-credit election unchanged. The 2015 node marks earliest model availability; the deduction predates it.
Under P.L. 2009, c.69, §2, physical page 2, a qualifying resident may deduct property taxes up to $10,000. The Division documented that cap in its 2016 annual report, physical page 34, and 2017 NJ-1040 instructions, Worksheet G, physical page 36. The Legislature increased the cap to $15,000 for taxable years beginning on and after January 1, 2018 in P.L. 2018, c.45, §§1–3 and 12.
The new variable-named history YAML adds seven cases and 20 monetary assertions: below/at/above-cap returns for 2015–2020, plus one wage-only household. For example, a 2017 single filer with $50,000 of wages and $20,000 of qualifying property taxes computes NJ gross income of $50,000 and a $10,000 potential deduction. The fixtures stipulate an otherwise-qualified full-year resident who solely owns one homestead, with no other income or adjustments in the raw-wage example.
The scope leaves separate-spouse sharing, proportionate ownership, Senior Freeze/PTR, specified 2009 restrictions, the 1996–1997 phase-in and 2018 property-tax-credit counting rules unchanged. PR 10654 retains the election work. These conditional cap fixtures do not establish a complete return, final tax, partner-wide compatibility or population effect.
Validation:
Genuine RED: four failures and three passes against the unchanged cap. The 2015–2017 above-cap returns produced $10,001 rather than $10,000; the raw 2017 return produced $15,000 rather than $10,000. RED stopped at that potential-deduction output and did not establish the later AGI assertion.
Final local GREEN: 19 cases passed across five YAML files in one process—seven new cases, three ordinary potential-deduction cases and nine adjacent eligibility/deduction/election cases. Both raw 2017 outputs passed. Pytest reported 16.18 seconds; the bounded native command took 93.87 seconds and peaked at 4,271,144,960 bytes RSS.
The local producer used base
29f81ccc363c00b712d2faa99811f3363df0653fplus the three exact working-tree files, US 2.140.1, Core 3.36.0 and Python 3.14.7. Onemake formatrun completed with exit 0 and preserved all three file hashes. These results come from that working-tree state.At commit
a0c4e4e32672f074bd6e5862dd7b79364c750c94, a metadata check matched all 22,599 current tracked source entries, 29,302 runtime entries and the interpreter to the GREEN post-run seals. The check preserved the existing stat-only treatment of known payloads. It ran no model imports or tests and produced no new native result.All 37 jobs in current-head full CI run 43951729919 succeeded; GitHub recorded completion at 22:07 UTC on November 16, 2026. Formal independent review remains pending.
axiom: TheAxiomFoundation/rulespec-us#2037 queued
The historical source amendment extends existing RuleSpec issue 2037. Its current 2026 module does not establish historical coverage. The source packet does not authenticate historical admission or a signed runtime binding, and all 20 external comparisons remain unrun. The amendment grants no approval for a new billed run.