Repository navigation
Round the Vermont veteran tax credit's phase-out steps down - #10871
Merged
Merged
Conversation
Vermont's 2025 Schedule IN-112, Part II, line 10 has filers divide AGI above $25,000 by 100, "rounding down to the nearest whole number". 32 V.S.A. § 5830g(c)(2) sets $5 per $100 and says nothing about a partial $100. The formula rounded up with np.ceil, so a tax unit with AGI from $25,001 to $29,999, other than a multiple of $100, got $5 less than the schedule gives. It now uses np.floor. The baseline YAML file gains boundary cases at each edge of the worksheet. The variables-folder file now expects $250 at AGI of $25,050 and $5 at $29,950, and four of its cases gain a Vermont state code so they reach the formula. A new invariants test checks every whole-dollar AGI from $0 to $35,000 against the worksheet. The five parameter files' booklet links now open page 34, which holds the credit's instructions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Put active verbs in the changelog fragment, the invariants test's docstring and one of its comments. No code or expected value changes. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
MaxGhenis
marked this pull request as ready for review
November 13, 2026 22:32
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10871 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 37 23 -14
=========================================
- Hits 37 23 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
US + core hub merge audit, us#10871 at
🤖 Generated with Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Vermont gives a veteran with federal AGI of $25,000 or less a $250 refundable credit. For AGI above $25,000 and below $30,000, Vermont pays "$250.00 less $5.00 per $100.00" of AGI above $25,000, and it pays nothing at $30,000 or more (32 V.S.A. § 5830g(c)). The section says nothing about a partial $100. In the section before it, the legislature wrote rounding up into the child tax credit's phase-out: "for each $1,000.00, or fraction thereof" (§ 5830f(b)).
The Department of Taxes fills that gap on the 2025 Schedule IN-112, Part II, line 10: "DIVIDE Line 9 by 100, rounding down to the nearest whole number." The Schedule IN-112 instructions give the same line.
vt_veteran_tax_creditcounted the $100 steps withnp.ceil, so a partial $100 took $5 like a whole one. For example, at AGI of $25,050 the schedule gives $250 and the model paid $245, and at $29,950 the schedule gives $5 and the model paid $0. The formula now usesnp.floor, so the credit rises by $5 for a tax unit with a veteran and AGI above $25,000 and below $30,000, unless AGI exceeds $25,000 by a whole multiple of $100. Across every whole-dollar AGI from $0 to $40,000, the old formula and the schedule differ at 4,950 values from $25,001 to $29,999, each by $5, and agree everywhere else.The variable's
referencenow cites § 5830g, the schedule and its instructions in place of a news article. The five parameter files' booklet links move from page 36, which holds the Schedule IN-113 instructions, to page 34, which holds this credit's instructions.The Department of Taxes hasn't posted a 2026 Schedule IN-112, so the model applies the 2025 schedule's rounding to 2026 under the same statute.
Tests
Pull request run 43611035458 at
6fdd72d82apassed all 36 jobs on GitHub's merge with main9a63ae6605.policyengine_us/tests/policy/baseline/gov/states/vt/tax/income/credits/vt_veteran_tax_credit.yamlgains 19 cases at each edge of the worksheet. For 2025 they cover AGI of -$1,000, $24,999, $25,000, $25,001, $25,099, $25,100, $25,101, $25,199, $25,200, $27,550, $29,899, $29,900, $29,901, $29,999, $30,000, $30,001 and $30,100. For 2026 they cover $25,099 and $29,999. Each case name carries the worksheet's arithmetic, for example "floor(4,999 / 100) = 49, pays $250 - 49 x $5 = $5".policyengine_us/tests/variables/gov/states/vt/tax/income/credits/vt_veteran_tax_credit.yamlnow expects $250 at AGI of $25,050 and $5 at $29,950. Four of its cases had no state code, so the default state, California, kept them from reaching the formula. They now set Vermont.policyengine_us/tests/core/test_vt_veteran_tax_credit_invariants.pytypes the worksheet's lines from the schedule, without reading the parameters or the formula, and checks three invariants:One simulation per year checks every whole-dollar AGI from $0 to $35,000 in 2025 and 2026, where the YAML cases sample 19 points. A Hypothesis test (12 derandomized examples of up to 20 tax units) adds negative, large and fractional AGIs, joint units, units without a veteran, New Hampshire units and 2024. The file runs in the Makefile's
coreRest Python group.Local runs
With the formula back on
np.ceil, 10 of the 19 new baseline cases fail, each by $5, and so do the variables-folder cases at $25,050 and $29,950.All 3 invariants tests fail against
np.ceil. Each whole-dollar test reports 4,950 of 35,001 AGIs off by $5, and the Hypothesis test fails on a Vermont veteran with AGI of $25,000.01.On macOS, the invariants file's process peaked at 1.22 GB of resident memory, and its three test calls took 2.2 s together.
YAML tests take their expected values from the 2025 Schedule IN-112 worksheet and § 5830g(c)(3).
Source conflict: not applicable. The statute says nothing about a partial $100, and the schedule fills that gap.
ruff format(0.15.5, theuv.lockpin) andruff checkpass on the changed Python files.Changelog fragment
changelog.d/fix-vt-veteran-credit-rounding.fixed.md.Microsimulation impact
We estimate that this branch changes none of the outputs below in 2026 on the default dataset. We compared
mainata93cc58d7ewith this branch at6fdd72d82a.vt_veteran_tax_creditvt_income_taxstate_income_taxincome_taxhousehold_benefitshousehold_net_incomeNo sampled return's credit changes, so the household tests above show what this change does.
axiom: TheAxiomFoundation/rulespec-us#2220 queued (32 V.S.A. § 5830g with the 2025 Schedule IN-112's whole $100 steps; the pinned corpus release lacks the 2025 schedule, so the signed encoder can't run yet)
🤖 Generated with Claude Code