Repository navigation
Capture sources for ten ruled source conflicts - #10841
Merged
Merged
Conversation
Add period-specific statutes, enrolled acts, regulations, guidance, and tax instructions for the shared source-conflict register. No model changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Add the official formatting legend and check the extraction header before readers quote amended text. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Add federal repeal timing, Maine credit and chapter text, and the New York joint-claim sentence in content stream order. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
US + core hub merge audit, us#10841 at
🤖 Generated with Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add 33 official source captures for ten source-conflict candidates and the Maine EITC identification-number provision. Later register entries can pin these files after they reach main.
Each capture starts with the official URL and extraction method, then holds unedited text from the declared PDF pages. This PR also adds an extraction-header regression test and a changelog fragment.
Coverage
Capture paths below start at
source_conflicts/sources/.us-ar:gambling-loss-deduction-before-2015us-hi:joint-return-claimable-spouse-exemptionus-hi:joint-return-one-disabled-spouse-exemptionsus-me:childless-eitc-age-capus-me:sales-tax-fairness-credit-mixed-joint-returnus-ny:college-tuition-credit-claimed-spouseus-ny:real-property-credit-claimable-spouseus:charitable-non-itemizer-2020-separate-capus:education-benefits-joint-claimed-spouseus:recovery-rebate-joint-claimable-spouseSection 5219-S page 2 and PL 2021 chapter 479 page 1 carry subsection 7, the Maine EITC identification-number provision. #10527 proposes a candidate for it,
us-me:eitc-itin-qualifying-children, andsource_conflicts/candidates.yamldoesn't hold that id yet.Extraction and historical limits
pdftotextdrops strike-through and underline marks. The Act 155 header identifies that loss and the affected page 9 text. Page 1 supplies the official formatting legend. The official PDF, page 9 strikes 2015, inserts 2017, and underlines the gambling-loss clause in section 21. On page 10, the act also strikes 1995 in section 24 and underlines section 25; the header's general warning covers those marks without naming them. Arkansas lawmakers applied sections 1–24 from tax year 2015 in section 25, PDF page 10. DFA describes HB1390 as a clarification in its impact statement.pdftotextalso drops the amendment marks in the three session laws. The header of the PL 2019 chapter 527 pages 1–5 capture warns of that loss and points to PDF page 4; page 5 also underlines subsections 5 and 6. The headers of the PL 2017 chapter 474, PL 2021 chapter 479 and PL 2019 chapter 527 page 5 captures carry no warning. For example, PL 2017 chapter 474, page 8 strikes "or" after paragraph A and underlines the new paragraph C. Consult the PDFs before quoting amended text from these captures.pdftotext -layoutsplits it too. The-rawcapture keeps that sentence on consecutive lines of the 2025 IT-214 instructions, page 1. Use the reading-order capture for other passages;-rawjoins some neighboring words.Methodology choices
Retain the candidates' existing readings. These captures supply source text without changing policy, candidate years, register entries, or pins. New York's IT-214 instructions address the taxpayer in the singular and tell joint filers to submit one claim. When registering the conflict, distinguish that wording from an either-spouse inference.
The Arkansas header describes formatting that plain text cannot preserve. A verbatim excerpt check can still match a struck year; consult the official PDF before quoting amended language. The regression test requires the formatting warning, the struck and inserted years, and the section 21 underline range.
Keep the page 5 captures of section 62 and PL 2019 chapter 527 and the pages 2–3 capture of section 5213-A beside the wider captures of the same documents. A register entry can pin either file.
Sources still missing
Two candidates still need documents before registration:
Capture hashes and official sources
us-ar/act-155-2017-p1.txtb6ad05cde2b560bead541576cbf1716f08828588162c4345db193a0ae4c447b8us-ar/act-155-2017-p9-10.txt6c2946ccab817b88cf55fde3108a5e11be7d80309348b627f179665cceb39b66us-ar/hb1390-dfa-impact-2017.txt4016f13228fabe5a8139bf21f880e3ac022e4063f0c85b76a3761a9108d035d6us-hi/har18-235-54-2025-p100-101.txt38c8ec872582fd42df0b4496346427b635b984f48d6b79eebfbe33762cc47b33us-hi/n11-instructions-2022-p20.txtdfd6ccda01e4c85c33e238272ed93de4a2cd4d73678f6585b338c93da24b146fus-hi/n11-instructions-2023-p20.txt1de090ed1b656d198a04750f0d74c1a79d6f517721e4d4d88b62eebe1f8f9537us-hi/n11-instructions-2023-p9.txt625e383143231112be1ba8c523e3fe17daf6802712b0e1dff85633d44b714315us-hi/n11-instructions-2024-p20.txt0758efd01332ceee5ee559d6a75cf4cb1a76f005e6b1dc34a00275a023f336aeus-hi/n11-instructions-2024-p9.txtcbc2a98a2a460f02ff8b2d1a1bdba693c712cdc5c94452603c58ef92d4e50b07us-hi/n11-instructions-2025-p20.txt6849f11f73907e523109c7ee1e4da173604c636b502768115e995b8171d4e108us-hi/n11-instructions-2025-p9.txtb8206c708ced5a331cb33ace8d1890f66f4689984f51471020439b131034a7a3us-hi/tir2022-01-revised-2022-p1.txtaef9250a44a5fedd00425fad0caf28a8b6dbc0f7f129be0dfe2e45340b5c095aus-me/5213-a-2026-p1-3.txt883dfe009c096a78372913583fee41ef828fc62f09a41caf62382240892a2078us-me/5213-a-2026-p2-3.txtcefe7173aabb21c24f4847105bd0bed6b726ce9efad94ff37463557cd1183bd8us-me/5219-s-2026-p2.txtc767b8382679c6c3de99fbdbb55ebd44d9fc30c7fbd2b41b7cd6639311e2de7eus-me/pl-474-2017.txt30c2de382a4458ecd9643089e924732d8e0fbae2b5b6f8d0fe600717fb2ef7cbus-me/pl-479-2021-p1.txt2c2e137905bf49f7af29d33ec7c3f82e2be6181f1f1bde92553c7428a1d880c5us-me/pl-527-2019-p1-5.txt18e050eb3dcf35a9b8bd0bd55e392d99f1dd15fefcd8161e2b7ead2dafed509aus-me/pl-527-2019-p5.txt96c7b92ad3af066100021db9379124c30e2ca9319c572495980732d3a1c52be5us-ny/it214-instructions-2025-p1-raw.txt3a83ed66946afeb4eb65eb0bb016584d5b3ff6f89aa630ee62b6edf7ab161ca6us-ny/it214-instructions-2025-p1.txt55d530e053913f5e19e7b2001929810092d2c6f29052feeae13c73bdabf6f39dus-ny/it272-2025-p1.txt0675b090a3cb1ee98ee9d9477f0cb1c47ba5ec43e23b2c2f84c32fd1e9e75bffus-ny/it272-instructions-2025-p1.txt2c2b73b41aea9cb64c811c42ddcf2b86217ee2358449260fcce8307492843ef2us/i1040-instructions-2020-p30.txt7a61a696d444e90bd87edcdeecb1dd903ae9385dbd485f29a7964afafb290b03us/i1040-instructions-2025-p115.txtb5d56f6049adca83a5683c5903f9e406cc04bf536ef05975a346a1197fd92baaus/i1040-recovery-rebate-worksheet-2020-p59.txt9c48310497dd3e4eaeed665593d709e35e2ec26c562e07b84677751f8a83f1b4us/i1040-recovery-rebate-worksheet-2021-p59.txt09d90e23b115fffa49f4ac1443b94e7715c8cec0ce42157b49d65e19e925ad0aus/pl-116-136-2020-p65.txtc77bc95d64ba55bb1ec44bed9eebd521787c8e8dd49e92794c323a90a80b1c1dus/usc-26-62-2020-p5-6.txtd8b3a4da9e3a3e5cdacf50b294bb9bb7c28f4121d65d478b44f8a7bc0907b92aus/usc-26-62-2020-p5.txt34f7ba1e1a5a05f4071418df265ffb69c379eb0064f32e813c5af3e0a48e316bus/usc-26-6428-2020-p1.txt35fc7fa7040afca8b92310f6de74f1c9586193ce2125743296a378845882d098us/usc-26-6428a-2020-p1.txt8efccc2d07a8e509878cd2f41a496f1255cba689b8b375071fb1938210104230us/usc-26-6428b-2021-p1.txtdc3c5ff8e30cc0c321f5e63e0f60880043545bfbf5e6f551a31cc496c971dd88Validation
Pull request run 43752366166 at
a35bdaf3b0passed all 38 jobs on GitHub's merge with mainbdaf14f08d.policyengine_us/tests/code_health/test_source_capture_methods.pyholds one test of the Act 155 pages 9–10 capture. It confirms that the capture body still holds "as in effect on January 1, 2015", although the act strikes that year, and that the header holds each of its three notes on the lost marks.git diff --checkpasses on the test file and the changelog fragment. Among the captures, it flags two lines ofus-ny/it272-2025-p1.txt, where the extraction keeps the form's tab characters.Each header names its source and extraction method, and our notes sit only in those two header lines.
Microsimulation impact
This PR adds source captures, a test of one capture's header and a changelog fragment, and it changes no formula, parameter or numerical expectation.
impact: none: this PR changes no formula, parameter or numerical expectation
axiom: n/a: source captures for the source-conflict register and a capture-header test; no model change
🤖 Generated with Claude Code