Skip to content

Count only parents' own ESA and JSA in the Wales childcare income limit; test #1966's and #2007's switches - #2895

Open
MaxGhenis wants to merge 7 commits into
mainfrom
legacy-award-reader-switches-1966
Open

MaxGhenis wants to merge 7 commits into
mainfrom
legacy-award-reader-switches-1966

Conversation

@MaxGhenis

@MaxGhenis MaxGhenis commented Nov 6, 2026 •

Copy link
Copy Markdown
Collaborator

Follow-up to #2026 and #2027.

Summary

#2027 added claimant_or_partner_esa_income, claimant_or_partner_jsa_income and the person-level is_on_* flags, which say whom an award is payable to. Parallel PRs added readers of the benefit-unit totals esa_income and jsa_income. Those totals also hold an award that another member of the benefit unit (neither the claimant, the partner nor a child or young person they are responsible for) claims in their own right. This PR finishes the readers whose source PRs have since merged:

  • One reader changes: the Childcare Offer for Wales income test (da3f802, merged 2026-10-23). Its list of the family's benefits named esa_income and jsa_income, so another member's own award counted towards a parent's £100,000 gross income limit. The list now names claimant_or_partner_esa_income and claimant_or_partner_jsa_income.
  • Two source PRs already read the right awards when they merged; this PR adds tests: Give Scotland and Wales working-age CTR their own rules #1966 (the Scotland and Wales working-age council tax reduction personal allowance) and Fix HB and national CTR non-dependant deductions #2007 (the non-dependant exemptions, the remunerative work test and a couple's gross income for the deduction bands).

Reader by reader

Source Reader Law Before Now
da3f802 wales_childcare_offer_parent_condition, through gov.welsh_government.childcare_offer.income.benunit_gross_income_sources Childcare Offer for Wales: Guidance for Local Authorities (April 2026, non-statutory), paras 57, 58 and 69: each parent's gross income of £100,000 or less; other adults without parental responsibility are not parents the list named esa_income and jsa_income, so another member's own award counted towards a parent's gross income the list names claimant_or_partner_esa_income and claimant_or_partner_jsa_income, as the offer's exception criteria already do. The equal split between the claimant and any partner, a modelling convention, is unchanged
#1966 council_tax_reduction_working_age_personal_allowance SSI 2021/249 Sch 1 para 1; WSI 2013/3029 Sch 7 para 1: the higher allowance for a single applicant under 25 entitled to main phase ESA on #1966's branch before aed6724, add_for_members(benunit, period, ["esa_contrib", "esa_income"], claimant_or_partner), which counted the benefit unit's income-related ESA #1966 switched it before merging (aed6724): the applicant's or partner's contributory ESA, plus claimant_or_partner_esa_income where the benefit unit's awards are the applicant's. This PR adds YAML cases and a property entry for this reader
#2007 housing_benefit_non_dep_deduction_exempt, council_tax_reduction_non_dep_deduction_exempt (with Scotland's working-age partner rule), household_benefits_individual_non_dep_deduction (remunerative work) and _non_dependants.FAMILY_GROSS_INCOME_BENEFITS (a couple's gross income) HB Regs 2006 reg 2(1), (3) and (3A), reg 6(6) and reg 74(4) and (8); SI 2006/214 regs 6(6) and 55(4) and (8); SI 2012/2885 Sch 1 para 8(4) and (8); SSI 2012/319 reg 48; SSI 2021/249 reg 90; WSI 2013/3029 Sch 1 para 3 and Sch 6 para 5 on #2007's branch at 4a0935b, is_award_payee read the benefit-unit awards and took the payee to be any member who reported one, or the head where none did; the couple's gross income added the benefit-unit jsa_income and esa_income #2007 merged reading is_on_income_support, is_on_income_based_jsa and is_on_income_related_esa (through is_on_legacy_income_related_benefit) and is_on_pension_credit; its main merge c915c72 replaced is_award_payee, and 634047b scoped the couple's gross income to claimant_or_partner_jsa_income and claimant_or_partner_esa_income. This PR adds YAML cases and property entries for these readers

The only formula input that changes is the Wales offer list. The other changes are tests, comments and the changelog.

#2007's code on main reads the payee flags partly through a shared helper, is_on_legacy_income_related_benefit, and counts State Pension Credit through is_on_pension_credit. The readers use the person-level payee flags, apply Scotland's working-age partner rule, and band a couple on the claimant's and partner's awards, so no reader needed a change.

Sweep of the remaining readers on main

git grep on main (2c570224b) for "esa_income" / "jsa_income" in variables and for the unquoted names in parameters. No new reader turned up. Every remaining reader is one #2027 left on the totals on purpose, or one another PR owns:

Invariants

  1. The Income Support, income-based JSA or income-related ESA that a member who is neither the claimant, the partner nor a dependant reports in their own right never changes any family reader or any existing member's reader. The properties in test_legacy_award_readers_properties.py also add that member, and allow a change only where their presence ends the severe disability premium or makes them the council tax reduction applicant. This PR adds the personal allowance to FAMILY_READERS, and both non-dependant exemptions, the Housing Benefit individual deduction and the Wales parent condition to MEMBER_READERS. It adds two shapes the other shapes never reach. One has families in Wales with a parent just under £100,000. The other (test_other_members_awards_never_change_the_non_dependant_readers) has a household with an applicant aged 70 in England and a non-dependant benefit unit, whose claimants work 35 hours on £13,000 or not at all, some with a £200 report below the tariff income on £10,000 of savings; it checks both exemptions and both individual deductions for every existing member. As Count only the claimant's and partner's legacy awards in means tests and passports #2027 notes, this holds while the benefit cap does not bind.
  2. The claimant's or partner's own award still moves each reader (YAML controls).
  3. The person an award is payable to is on it: another member who reports Income Support, income-based JSA or income-related ESA in their own right is on it, and a claimant whose claimant-and-partner award falls to nil after tariff income is not (YAML).

Tests

New YAML in policyengine_uk/tests/policy/baseline/finance/benefit/family/legacy_award_readers/. Each file cites the law and parameter values behind its expectations.

  • council_tax_reduction_working_age_personal_allowance.yaml: 4 cases (another member's income-related ESA, or the applicant's own, in Scotland and in Wales, 2025-26).
  • wales_childcare_offer.yaml: 4 cases (a lone parent earning £96,000 with another member's income-related ESA or income-based JSA of £8,000, or the parent's own).
  • non_dependant_exemptions.yaml: 8 cases. Another member's income-based JSA or income-related ESA exempts that member, not the non-dependant claimant. A claimant whose own ESA falls below tariff income is not on it, while another member receives their own award. Another member who reports Income Support in their own right is on it (aged 23, exempt under both; aged 40, under council tax reduction only). The claimant's own JSA or ESA exempts the claimant. The deduction bands a non-dependant couple on its own income, leaving out another member's ESA.

Each case passes with the switch, and cases fail without it (check_switch.sh, which restores only the switched files):

Switch Pre-switch code Result without the switch
Wales offer the parameter file at the branch point 2c570224b 2 of 4 fail
#1966 the reader on #1966's branch at fae2f38b4 2 of 4 fail
#2007 539a03c06: main's three reader files with #2007's is_award_payee (4a0935b) restored, and the couple's gross income on the benefit-unit totals 4 of 8 fail: the claimant below tariff income, the other member's Income Support at 23 and at 40, and the couple's band

With the old code, the properties fail in the generate phase (no shrinking):

  • Give Scotland and Wales working-age CTR their own rules #1966: the young-singles property, on council_tax_reduction_working_age_personal_allowance;
  • Wales offer: the Welsh high earners property, on wales_childcare_offer_parent_condition;
  • Fix HB and national CTR non-dependant deductions #2007: the working-age property passes with the old code, so this PR adds the non-dependant shape. That property fails with all three 539a03c06 readers (on council_tax_reduction_individual_non_dep_deduction, the couple's band, here; on council_tax_reduction_non_dep_deduction_exempt in review r1's run), and on housing_benefit_non_dep_deduction_exempt with the old payee rule and the claimant-or-partner names in FAMILY_GROSS_INCOME_BENEFITS.

Test runs on this branch started at c240ddbea, with this PR's #2007 files in the working tree, and at 6805d2d78; the property file ran last, at 98cdbc4b1. Review r1 reran the legacy YAML, the switch checks and the property file at 3720d44d3.

Enhanced FRS impact

CI's aggregate impact job makes real microsimulation runs on the certified Enhanced FRS (enhanced_frs_2024_25.h5, policyengine-uk-data 1.58.1, sha256 056e80fd8e91) for each fiscal year 2025-26 to 2031-32. Its report for 98cdbc4b1 compared base 2c570224b1 (main) with merge commit 72c8d60642. The report records no household net income changes in any year. The change broke no checks (the VAT sign check fails on both sides), and the report flagged no moves for review.

A local pair of runs on a private copy of another Enhanced FRS build (sha256 e433e532b17b, not the certified file) compared main at 2c570224b with this head, 98cdbc4b1, for 2025 to 2030. Each year they compared 143 arrays exactly: the readers in the table, the benefits and non-dependant deductions they feed, the claimant-or-partner awards, the benefit-unit totals and household net income. None changed in any year. In that file no other member (neither a claimant, a partner nor a child or young person they are responsible for) reports income-related ESA, income-based JSA or Income Support, so the switch has nothing to move there; the tests above are what exercise it.

Review

  • Review r1 (Subfleet, GPT-6.1 Sol, job 20261117-025243-reader-switches-review) approved 3720d44d3 with one nit. It re-derived the 16 new YAML expectations from the law and parameters, and reran the legacy reader YAML (105 passed), the three check_switch.sh checks (2, 2 and 4 cases fail without the switch), the new property against 539a03c06 (fails) and the property file (22 passed). It also checked the mechanism claims against aed6724, c915c72 and 634047b. The nit: the new property's docstring said a £200 report leaves no award, which a partner's report of the same award can change.
  • 98cdbc4b1 fixes that docstring (no code change). Review r2 (Subfleet, GPT-6.1 Sol, delta) confirmed the fix, its arithmetic and its citations, and requested corrections to drafts of this body and of the reply on C1.
  • Review r1's sweep also noted two older readers that this PR's rule does not reach, since each needs attribution to a person rather than a name swap: Warm Home Discount (warm_home_discount.py; SI 2026/389 reg 9 names the electricity customer or partner) and the cost-of-living payment (cost_of_living_means_tested_payment.py). This PR leaves both for follow-ups.

Axiom

axiom: TheAxiomFoundation/rulespec-uk#416 queued (addendum TheAxiomFoundation/rulespec-uk#416 (comment); addendum 3, companion test 20: TheAxiomFoundation/rulespec-uk#416 (comment)), with TheAxiomFoundation/rulespec-uk#393 (Scotland and Wales working-age CTR), TheAxiomFoundation/rulespec-uk#407 (non-dependant deductions) and TheAxiomFoundation/rulespec-uk#480 (Childcare Offer for Wales).

Reproducer: policyengine_uk/tests/policy/baseline/finance/benefit/family/legacy_award_readers/wales_childcare_offer.yaml; policyengine_uk/tests/policy/baseline/finance/benefit/family/legacy_award_readers/council_tax_reduction_working_age_personal_allowance.yaml; policyengine_uk/tests/policy/baseline/finance/benefit/family/legacy_award_readers/non_dependant_exemptions.yaml; policyengine_uk/tests/test_legacy_award_readers_properties.py::test_other_members_awards_never_change_the_non_dependant_readers

🤖 Generated with Claude Code

MaxGhenis and others added 3 commits November 6, 2026 14:39
#1966 already reads claimant_or_partner_esa_income in
council_tax_reduction_working_age_personal_allowance (aed6724). Add
excluded-adult cases for Scotland and Wales: another member's own
income-related ESA leaves a single applicant under 25 on the lower
personal allowance, and the applicant's own award gives the higher one
(SSI 2021/249 Sch 1 para 1; WSI 2013/3029 Sch 7 para 1). The two
excluded-adult cases fail on #1966's pre-switch reader (fae2f38).

Add the reader to FAMILY_READERS, and to CTR_APPLICANT_READERS: an
added member older than the claimant becomes the household head who
applies alone, which changes the applicant.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Childcare Offer for Wales limits each parent's gross income to
£100,000 (guidance for local authorities, April 2026, paras 57 and 69).
benunit_gross_income_sources listed esa_income and jsa_income, so an
award that another member of the benefit unit claims in their own right
counted towards a parent's gross income. List
claimant_or_partner_esa_income and claimant_or_partner_jsa_income
instead, as the offer's exception criteria already do. The equal split
between the claimant and any partner is unchanged.

Add excluded-adult cases and controls, pin the new names in
test_wales_childcare_offer_income_sources.py, add
wales_childcare_offer_parent_condition to MEMBER_READERS, and add a
property shape with a Welsh parent just under the limit, since the other
shapes never come near £100,000.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@juaristi22 juaristi22 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review status: COMPLETE — request changes for one completion blocker

Reviewed head: a8affa040113600fe99998164c613c228c8ad92f.

C1 — Make the queued source record dispatch-ready for the Welsh Childcare Offer change. The repository requirement applies to policy and parameter fixes. A queued record must identify the operative source, module/corpus boundary, required outputs, companion cases and actual execution blocker.

I checked issue #416 and all eight comments, including the linked addendum. That packet covers the CTR personal-allowance reader but omits the new Welsh Childcare Offer £100,000 income rule, its guidance/corpus boundary, per-parent outputs and excluded-adult companion cases. The English childcare provisions concern different programmes; #393's CTR packet also does not supply this change.

Please extend the actual filed packet with that provision, source-derived cases and the ingest/execution blocker, then update the PR's completion record. This requires a reviewable dispatch record; no billed encoder execution is requested here. The blocker concerns the explicit completion requirement.

The policy and code checks otherwise support the switch. Welsh guidance, paragraphs 57–58 and 69 supports the per-parent limit and exclusion of other adults without parental responsibility. 173 repository tests passed (68 YAML and 105 Python), plus eight childcare and four positive-CTR household controls. The childcare exclusion cases pay £6,720 with the corresponding household-income effect. The entered-own-award controls test the stored-input contract; they do not certify benefit entitlement at those wages. CTR production is unchanged, and the final CTR checks do not claim a monetary effect from the personal-allowance reader.

There are no material evidence gaps in this completed review. The PR remains a draft and current-head CI was still pending. The planned survey run and expected £0 impact are not counted as completed validation.

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Aggregate impact on certified data: pass

Base 2c570224b1 against head 72c8d60642, both on enhanced_frs_2024_25.h5 (policyengine-uk-data 1.58.1, sha256 056e80fd8e91), fiscal years 2025-26 to 2031-32. Each year is a full microsimulation run on each side.

Checks: 0 broken by this change, 1 failing on both sides, 0 fixed. Moves flagged for review: 0 (thresholds in report_spec.yaml; a flag does not fail the job).

Workflow run and full report

Notes

  • In the years a figure from fewer than 10 records is suppressed (spending.disabled_students_allowance), every total containing it, and the decile incomes, are rebuilt from their other components, so no published total includes it. Those totals are marked †. A change is withheld where the two sides leave out different figures and can't be lined up.

Moves flagged for review

None.

Spending by benefit and service

Measure 2025-26 2026-27 2027-28 2028-29 2029-30 2030-31 2031-32
Disabled Students' Allowance suppressed suppressed suppressed suppressed suppressed suppressed suppressed

Caseloads

Measure 2025-26 2026-27 2027-28 2028-29 2029-30 2030-31 2031-32
Disabled Students' Allowance suppressed suppressed suppressed suppressed suppressed suppressed suppressed

Household net income by decile

No household's net income changes in any year.

No change in any year: receipts by tax head; government balance, each component counted once; model totals; household income totals; population; poverty rates; people in poverty; inequality; mean household net income in each side's own deciles; standard reform costings (change in gov_balance); standard reforms: change in each reform's target.

Checks failing on both base and head (1)
  • VAT excluding private school fees is never negative (sign:vat): 2025-26: 76 units below zero, a weighted £-52,314,332 in total; 2026-27: 76 units below zero, a weighted £-54,150,722 in total; 2027-28: 76 units below zero, a weighted £-56,043,426 in total
Counted-once check

The check raised each of 92 components by £1 per unit in 2026-27 and read every head of its totals household by household: its own head must rise by exactly £1, no other tax head may move, no other benefit may rise, and the model's own total must move by what its heads moved. A response that is not finite breaks every rule. The check measures a head that breaks a rule twice more: once holding every other head at its baseline value, and once holding every other head at its value after the first £1 while the component rises again. The head fails where either measurement still shows the response. The check cannot hold a head at a value that is not finite. In each unit where another head is not finite after the first £1, it holds that head at its baseline value, and the second measurement judges no household the unit belongs to. There a head fails wherever it first broke a rule, or wherever the check could not confirm whether its response contains the component. 0 failed and the check skipped 0.

  • widowed_parents_allowance: pension_credit responds only through other heads in fewer than 10 households (other heads that moved there: carers_allowance; gov_spending; not a failure)
  • widowed_parents_allowance: pension_credit responds only through other heads in fewer than 10 households (other heads that moved there: carers_allowance; household_benefits; not a failure)
Provenance
Side Commit Runtime Environment hash Partition hash Time
base main 2c570224b1 uk 2.179.1 (files dd0c351a4fca), core 3.34.9, py 3.13.18 aarch64 286ce9a4027c f5dab8526157 3192.38s
head #2895 merged into main 72c8d60642 uk 2.179.1 (files 555560c1a538), core 3.34.9, py 3.13.18 aarch64 286ce9a4027c f5dab8526157 3131.12s

Dataset: hf://policyengine/policyengine-uk-data-private/enhanced_frs_2024_25.h5@2526edbbb687a3b54dbb11272e5389e4b62d2ac2, sha256 056e80fd8e9151d78f432a25cde863340baee81304c6216a37fb575ce8563784 (verified on both sides), policyengine-uk-data 1.58.1.

Receipts by tax head: head levels
Measure (head) 2025-26 2026-27 2027-28 2028-29 2029-30 2030-31 2031-32
Final charge on cash interest in non-cash ISAs £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn
Lifetime ISA withdrawal charge £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn
Income tax £294.44bn £315.21bn £335.80bn £351.25bn £366.92bn £385.32bn £399.96bn
National Insurance (employee and self-employed) £51.70bn £54.14bn £56.13bn £57.73bn £59.76bn £61.64bn £63.51bn
National Insurance (employer) £148.71bn £155.37bn £160.88bn £165.09bn £172.06bn £177.36bn £182.57bn
Employer NI change borne by capital £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn
Employer NI change borne by consumers £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn
Capital gains tax £12.60bn £13.15bn £13.60bn £14.11bn £14.67bn £15.24bn £15.80bn
Student loan repayments £7.82bn £8.13bn £8.39bn £8.58bn £8.79bn £9.04bn £9.29bn
VAT excluding private school fees £242.22bn £249.47bn £258.67bn £264.86bn £270.95bn £277.04bn £283.21bn
Change in VAT from its baseline £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn
VAT on private school fees £1.95bn £2.01bn £2.09bn £2.14bn £2.20bn £2.26bn £2.31bn
Change in private school VAT from its baseline £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn
Fuel duties £24.71bn £24.13bn £26.00bn £26.83bn £26.51bn £25.78bn £24.63bn
Alcohol duties £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn
Tobacco duties £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn
Vehicle excise duties £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn
Betting and gaming duties £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn
TV licence fee £4.26bn £4.40bn £4.41bn £4.42bn £4.43bn £4.44bn £4.45bn
Council tax £49.21bn £52.16bn £54.89bn £57.95bn £61.16bn £64.47bn £67.91bn
High value council tax surcharge £0.00bn £0.00bn £0.00bn £0.48bn £0.49bn £0.50bn £0.51bn
Northern Ireland domestic rates £0.55bn £0.58bn £0.60bn £0.63bn £0.66bn £0.69bn £0.72bn
Business rates £34.68bn £36.20bn £38.00bn £39.46bn £42.27bn £43.25bn £44.29bn
Stamp duty land tax on the household's own purchases £6.88bn £7.32bn £7.66bn £8.06bn £8.47bn £8.91bn £9.35bn
Stamp duty land tax paid by companies £4.72bn £4.57bn £5.29bn £6.03bn £6.37bn £6.92bn £7.45bn
Land transaction tax (Wales) £0.07bn £0.08bn £0.08bn £0.09bn £0.10bn £0.10bn £0.11bn
Land and buildings transaction tax (Scotland) £0.31bn £0.32bn £0.33bn £0.35bn £0.36bn £0.38bn £0.40bn
Unspecified tax change borne by capital £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn
Unspecified tax change borne by consumers £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn
Wealth tax £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn
Wealth tax excluding the main residence £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn
Land value tax £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn
Carbon tax £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn
Spending by benefit and service: head levels
Measure (head) 2025-26 2026-27 2027-28 2028-29 2029-30 2030-31 2031-32
Lifetime ISA bonus £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn
State Pension £121.68bn £125.92bn £126.72bn £129.48bn £132.98bn £136.65bn £140.41bn
Pension Credit £6.21bn £6.46bn £6.68bn £6.82bn £6.89bn £7.07bn £7.22bn
Winter Fuel Payment £1.86bn £1.85bn £1.79bn £1.77bn £1.78bn £1.78bn £1.78bn
Pension Age Winter Heating Payment (Scotland) £0.19bn £0.20bn £0.20bn £0.21bn £0.21bn £0.22bn £0.22bn
Universal Credit £75.71bn £81.81bn £84.29bn £86.34bn £87.51bn £89.06bn £89.70bn
Housing Benefit £8.57bn £8.52bn £8.85bn £9.06bn £9.29bn £9.57bn £9.84bn
Council Tax Reduction £2.19bn £2.32bn £2.44bn £2.58bn £2.72bn £2.87bn £3.02bn
Employment and Support Allowance (income-related) £0.79bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn
Employment and Support Allowance (contribution-based) £5.20bn £5.37bn £5.56bn £5.69bn £5.82bn £5.95bn £6.09bn
Jobseeker's Allowance (income-based) £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn
Jobseeker's Allowance (contribution-based) £0.29bn £0.30bn £0.31bn £0.31bn £0.32bn £0.33bn £0.34bn
Income Support £0.11bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn
Working Tax Credit £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn
Child Tax Credit £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn
Incapacity Benefit £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn
Personal Independence Payment £26.95bn £28.03bn £29.05bn £30.09bn £30.75bn £31.51bn £32.21bn
Disability Living Allowance £7.49bn £7.79bn £8.07bn £8.36bn £8.55bn £8.76bn £8.95bn
Attendance Allowance £8.68bn £9.03bn £9.36bn £9.69bn £9.90bn £10.15bn £10.38bn
Carer's Allowance £4.48bn £4.66bn £4.83bn £5.00bn £5.11bn £5.27bn £5.42bn
Carer Support Payment (Scotland) £0.31bn £0.32bn £0.33bn £0.34bn £0.35bn £0.36bn £0.37bn
Scottish Carer Supplement £0.00bn £0.04bn £0.04bn £0.05bn £0.05bn £0.05bn £0.05bn
Severe Disablement Allowance £0.03bn £0.03bn £0.03bn £0.03bn £0.03bn £0.03bn £0.03bn
Industrial Injuries Disablement Benefit £0.50bn £0.52bn £0.54bn £0.55bn £0.56bn £0.58bn £0.59bn
Armed Forces Compensation Scheme £0.61bn £0.63bn £0.65bn £0.66bn £0.68bn £0.69bn £0.71bn
War Widow's or Widower's Pension £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn
Child Benefit £16.20bn £16.82bn £17.39bn £18.01bn £18.40bn £18.84bn £19.26bn
Scottish Child Payment £0.49bn £0.52bn £0.53bn £0.55bn £0.56bn £0.57bn £0.56bn
Two Child Limit Payment (Scotland, counterfactual) £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn
Healthy Start vouchers £0.05bn £0.05bn £0.05bn £0.05bn £0.05bn £0.05bn £0.05bn
Maternity Allowance £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn
Statutory Maternity Pay £3.30bn £3.41bn £3.54bn £3.62bn £3.70bn £3.78bn £3.87bn
Statutory Paternity Pay £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn
Statutory Sick Pay £1.12bn £1.16bn £1.20bn £1.23bn £1.26bn £1.29bn £1.32bn
Sure Start Maternity Grant £0.01bn £0.01bn £0.01bn £0.01bn £0.01bn £0.01bn £0.01bn
Bereavement Support Payment £0.67bn £0.69bn £0.71bn £0.73bn £0.75bn £0.76bn £0.78bn
Widowed Parent's Allowance £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn
Tax-Free Childcare £0.56bn £0.57bn £0.57bn £0.58bn £0.60bn £0.61bn £0.59bn
Extended childcare entitlement £2.99bn £3.50bn £3.59bn £3.71bn £3.78bn £3.86bn £3.93bn
Universal childcare entitlement £2.06bn £2.22bn £2.29bn £2.37bn £2.43bn £2.48bn £2.53bn
Targeted childcare entitlement £0.50bn £0.51bn £0.52bn £0.54bn £0.55bn £0.57bn £0.56bn
Childcare Offer for Wales £0.26bn £0.28bn £0.28bn £0.29bn £0.30bn £0.31bn £0.32bn
Care to Learn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn
Childcare Grant £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn
Parents' Learning Allowance £0.20bn £0.20bn £0.20bn £0.20bn £0.20bn £0.20bn £0.20bn
Adult Dependants' Grant £0.06bn £0.06bn £0.04bn £0.04bn £0.04bn £0.04bn £0.04bn
Travel Grant £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn
Disabled Students' Allowance suppressed suppressed suppressed suppressed suppressed suppressed suppressed
16 to 19 Bursary Fund £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn
NHS spending £203.89bn £204.30bn £204.56bn £204.91bn £205.34bn £205.85bn £206.35bn
State education spending £0.02bn £0.02bn £0.02bn £0.02bn £0.02bn £0.02bn £0.02bn
Transport subsidy spending £25.05bn £25.10bn £25.14bn £25.18bn £25.23bn £25.30bn £25.36bn
Cost-of-living support payment £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn
Energy Bills Rebate £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn
Household Energy Payment £0.00bn £2.11bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn
Energy Price Guarantee subsidy £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn
Basic income £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn
Disability basic income £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn
Other public spending budget change £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn
Caseloads: head levels
Measure (head) 2025-26 2026-27 2027-28 2028-29 2029-30 2030-31 2031-32
Lifetime ISA bonus 0k 0k 0k 0k 0k 0k 0k
State Pension 11,264k 11,145k 10,819k 10,700k 10,723k 10,750k 10,776k
Pension Credit 1,489k 1,484k 1,476k 1,454k 1,452k 1,457k 1,466k
Winter Fuel Payment 7,844k 7,783k 7,473k 7,375k 7,391k 7,409k 7,427k
Pension Age Winter Heating Payment (Scotland) 803k 802k 800k 797k 799k 801k 802k
Universal Credit 6,343k 6,419k 6,408k 6,369k 6,364k 6,343k 6,295k
Housing Benefit 1,249k 1,182k 1,181k 1,165k 1,164k 1,166k 1,168k
Council Tax Reduction 3,326k 3,344k 3,351k 3,364k 3,375k 3,388k 3,395k
Employment and Support Allowance (income-related) 71k 0k 0k 0k 0k 0k 0k
Employment and Support Allowance (contribution-based) 719k 720k 721k 722k 724k 726k 728k
Jobseeker's Allowance (income-based) 0k 0k 0k 0k 0k 0k 0k
Jobseeker's Allowance (contribution-based) 67k 67k 67k 67k 67k 68k 68k
Income Support 25k 0k 0k 0k 0k 0k 0k
Working Tax Credit 0k 0k 0k 0k 0k 0k 0k
Child Tax Credit 0k 0k 0k 0k 0k 0k 0k
Incapacity Benefit 0k 0k 0k 0k 0k 0k 0k
Personal Independence Payment 3,567k 3,575k 3,579k 3,585k 3,593k 3,602k 3,611k
Disability Living Allowance 1,291k 1,294k 1,296k 1,298k 1,300k 1,304k 1,307k
Attendance Allowance 1,695k 1,698k 1,700k 1,703k 1,707k 1,711k 1,715k
Carer's Allowance 1,034k 1,037k 1,038k 1,040k 1,042k 1,060k 1,062k
Carer Support Payment (Scotland) 71k 71k 71k 72k 72k 72k 72k
Scottish Carer Supplement 0k 71k 71k 72k 72k 72k 72k
Severe Disablement Allowance 4k 4k 4k 4k 4k 4k 4k
Industrial Injuries Disablement Benefit 137k 137k 137k 138k 138k 138k 139k
Armed Forces Compensation Scheme 93k 93k 94k 94k 94k 94k 94k
War Widow's or Widower's Pension 0k 0k 0k 0k 0k 0k 0k
Child Benefit 8,124k 8,121k 8,121k 8,131k 8,146k 8,162k 8,179k
Scottish Child Payment 351k 352k 352k 353k 350k 348k 337k
Two Child Limit Payment (Scotland, counterfactual) 0k 0k 0k 0k 0k 0k 0k
Healthy Start vouchers 200k 200k 200k 201k 201k 201k 202k
Maternity Allowance 0k 0k 0k 0k 0k 0k 0k
Statutory Maternity Pay 333k 333k 334k 334k 335k 336k 337k
Statutory Paternity Pay 0k 0k 0k 0k 0k 0k 0k
Statutory Sick Pay 181k 182k 182k 182k 182k 183k 183k
Sure Start Maternity Grant 26k 26k 26k 26k 26k 26k 26k
Bereavement Support Payment 98k 98k 98k 98k 98k 99k 99k
Widowed Parent's Allowance 0k 0k 0k 0k 0k 0k 0k
Tax-Free Childcare 1,043k 1,027k 1,014k 1,009k 1,011k 1,009k 993k
Extended childcare entitlement 795k 800k 796k 797k 798k 798k 792k
Universal childcare entitlement 1,071k 1,072k 1,072k 1,073k 1,076k 1,079k 1,074k
Targeted childcare entitlement 165k 156k 154k 154k 155k 155k 150k
Childcare Offer for Wales 39k 39k 39k 39k 39k 39k 39k
Care to Learn 0k 0k 0k 0k 0k 0k 0k
Childcare Grant 0k 0k 0k 0k 0k 0k 0k
Parents' Learning Allowance 98k 98k 98k 99k 99k 99k 99k
Adult Dependants' Grant 18k 18k 12k 12k 12k 12k 12k
Travel Grant 0k 0k 0k 0k 0k 0k 0k
Disabled Students' Allowance suppressed suppressed suppressed suppressed suppressed suppressed suppressed
16 to 19 Bursary Fund 0k 0k 0k 0k 0k 0k 0k
Cost-of-living support payment 0k 0k 0k 0k 0k 0k 0k
Energy Bills Rebate 0k 0k 0k 0k 0k 0k 0k
Household Energy Payment 0k 21,065k 0k 0k 0k 0k 0k
Energy Price Guarantee subsidy 0k 0k 0k 0k 0k 0k 0k
Basic income 0k 0k 0k 0k 0k 0k 0k
Disability basic income 0k 0k 0k 0k 0k 0k 0k
Government balance, each component counted once: head levels
Measure (head) 2025-26 2026-27 2027-28 2028-29 2029-30 2030-31 2031-32
Government receipts, each component once £884.82bn £927.25bn £972.82bn £1,008.07bn £1,046.18bn £1,083.32bn £1,116.48bn
Government spending £529.29bn † £545.33bn † £550.40bn † £559.11bn † £566.74bn † £575.46bn † £583.07bn †
Government balance, each receipt once £355.53bn † £381.92bn † £422.41bn † £448.95bn † £479.44bn † £507.86bn † £533.41bn †
Benefits in household_benefits but not in gov_spending £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn £0.00bn
Model totals: head levels
Measure (head) 2025-26 2026-27 2027-28 2028-29 2029-30 2030-31 2031-32
gov_tax £884.82bn £927.25bn £972.82bn £1,008.07bn £1,046.18bn £1,083.32bn £1,116.48bn
household_tax £491.95bn £520.39bn £551.18bn £575.98bn £600.96bn £626.66bn £648.39bn
pre_budget_change_household_tax £484.13bn £512.26bn £542.79bn £566.92bn £591.68bn £617.12bn £638.58bn
gov_spending £529.29bn † £545.33bn † £550.40bn † £559.11bn † £566.74bn † £575.46bn † £583.07bn †
household_benefits £529.29bn † £545.33bn † £550.40bn † £559.11bn † £566.74bn † £575.46bn † £583.07bn †
gov_balance £355.53bn † £381.92bn † £422.41bn † £448.95bn † £479.44bn † £507.86bn † £533.41bn †
Household income totals: head levels
Measure (head) 2025-26 2026-27 2027-28 2028-29 2029-30 2030-31 2031-32
Household market income £1,637.96bn £1,702.77bn £1,757.35bn £1,806.41bn £1,855.97bn £1,912.43bn £1,970.44bn
Household net income £1,636.63bn † £1,687.51bn † £1,715.12bn † £1,747.12bn † £1,778.28bn † £1,816.57bn † £1,859.19bn †
Household net income (HBAI definition) £1,449.51bn £1,499.52bn £1,530.52bn £1,564.80bn £1,597.47bn £1,635.15bn £1,676.12bn
Population: head levels
Measure (head) 2025-26 2026-27 2027-28 2028-29 2029-30 2030-31 2031-32
People 69,245k 69,383k 69,473k 69,592k 69,738k 69,912k 70,080k
Benefit units 35,110k 35,181k 35,226k 35,286k 35,360k 35,449k 35,534k
Households 31,046k 31,108k 31,149k 31,201k 31,267k 31,345k 31,420k
Poverty rates: head levels
Measure (head) 2025-26 2026-27 2027-28 2028-29 2029-30 2030-31 2031-32
Absolute poverty, before housing costs: everyone 16.2% 15.4% 16.3% 16.2% 16.4% 16.4% 16.5%
Absolute poverty, before housing costs: children 24.6% 21.8% 23.0% 22.7% 22.9% 23.0% 23.2%
Absolute poverty, before housing costs: working-age adults 14.0% 13.7% 14.6% 14.6% 14.7% 14.7% 14.9%
Absolute poverty, before housing costs: pensioners 13.7% 13.4% 14.0% 13.9% 14.0% 14.0% 13.9%
Absolute poverty, after housing costs: everyone 21.5% 21.0% 22.0% 22.5% 22.8% 23.0% 23.4%
Absolute poverty, after housing costs: children 33.1% 31.2% 32.1% 32.4% 32.8% 33.2% 34.0%
Absolute poverty, after housing costs: working-age adults 19.9% 19.8% 20.8% 21.5% 21.8% 22.0% 22.2%
Absolute poverty, after housing costs: pensioners 12.7% 12.4% 13.2% 13.2% 13.3% 13.4% 13.6%
Relative poverty, before housing costs: everyone 16.9% 15.9% 16.3% 16.2% 16.3% 16.2% 16.5%
Relative poverty, before housing costs: children 25.7% 22.6% 23.0% 22.7% 22.8% 22.6% 23.2%
Relative poverty, before housing costs: working-age adults 14.4% 14.0% 14.6% 14.6% 14.7% 14.6% 14.9%
Relative poverty, before housing costs: pensioners 14.5% 14.1% 14.0% 13.8% 13.8% 13.9% 13.9%
Relative poverty, after housing costs: everyone 21.4% 20.9% 21.2% 21.3% 21.3% 21.5% 21.7%
Relative poverty, after housing costs: children 32.9% 31.0% 31.1% 31.0% 31.0% 31.2% 31.7%
Relative poverty, after housing costs: working-age adults 19.8% 19.7% 20.2% 20.4% 20.4% 20.6% 20.8%
Relative poverty, after housing costs: pensioners 12.5% 12.4% 12.2% 11.8% 11.7% 11.8% 12.1%
People in poverty: head levels
Measure (head) 2025-26 2026-27 2027-28 2028-29 2029-30 2030-31 2031-32
Absolute poverty, before housing costs: everyone 11,246k 10,704k 11,333k 11,298k 11,407k 11,448k 11,584k
Absolute poverty, before housing costs: children 3,676k 3,270k 3,455k 3,406k 3,441k 3,463k 3,509k
Absolute poverty, before housing costs: working-age adults 5,947k 5,858k 6,277k 6,330k 6,387k 6,400k 6,490k
Absolute poverty, before housing costs: pensioners 1,624k 1,576k 1,602k 1,562k 1,579k 1,585k 1,584k
Absolute poverty, after housing costs: everyone 14,869k 14,565k 15,263k 15,690k 15,910k 16,094k 16,373k
Absolute poverty, after housing costs: children 4,940k 4,671k 4,814k 4,873k 4,931k 5,015k 5,145k
Absolute poverty, after housing costs: working-age adults 8,424k 8,435k 8,943k 9,324k 9,474k 9,559k 9,683k
Absolute poverty, after housing costs: pensioners 1,504k 1,460k 1,505k 1,493k 1,505k 1,520k 1,545k
Relative poverty, before housing costs: everyone 11,694k 11,032k 11,318k 11,297k 11,348k 11,350k 11,584k
Relative poverty, before housing costs: children 3,847k 3,389k 3,454k 3,406k 3,427k 3,414k 3,509k
Relative poverty, before housing costs: working-age adults 6,128k 5,990k 6,270k 6,330k 6,356k 6,359k 6,490k
Relative poverty, before housing costs: pensioners 1,719k 1,652k 1,594k 1,561k 1,565k 1,576k 1,584k
Relative poverty, after housing costs: everyone 14,800k 14,518k 14,756k 14,791k 14,867k 15,002k 15,214k
Relative poverty, after housing costs: children 4,916k 4,649k 4,661k 4,651k 4,673k 4,701k 4,796k
Relative poverty, after housing costs: working-age adults 8,396k 8,414k 8,699k 8,813k 8,870k 8,959k 9,049k
Relative poverty, after housing costs: pensioners 1,488k 1,455k 1,395k 1,326k 1,324k 1,342k 1,369k
Inequality: head levels
Measure (head) 2025-26 2026-27 2027-28 2028-29 2029-30 2030-31 2031-32
Gini coefficient, equivalised HBAI income before housing costs 0.3076 0.3049 0.3055 0.3054 0.3059 0.3064 0.3080
Mean household net income in each side's own deciles: head levels
Measure (head) 2025-26 2026-27 2027-28 2028-29 2029-30 2030-31 2031-32
Decile 1: mean household_net_income per household £17,748 † £17,980 † £17,927 † £18,181 † £18,318 † £18,538 † £18,742 †
Decile 2: mean household_net_income per household £28,029 † £29,037 † £28,754 † £28,997 † £29,258 † £29,676 † £30,171 †
Decile 3: mean household_net_income per household £34,252 † £35,426 † £36,069 † £36,548 † £37,157 † £37,774 † £38,103 †
Decile 4: mean household_net_income per household £38,926 † £40,769 † £41,716 † £42,763 † £43,387 † £44,167 † £44,499 †
Decile 5: mean household_net_income per household £43,346 † £45,603 † £46,054 † £47,001 † £47,755 † £48,626 † £50,309 †
Decile 6: mean household_net_income per household £47,933 † £49,175 † £50,879 † £52,032 † £52,922 † £53,942 † £54,719 †
Decile 7: mean household_net_income per household £55,672 † £56,650 † £57,493 † £57,674 † £58,791 † £59,706 † £61,106 †
Decile 8: mean household_net_income per household £68,786 † £70,811 † £71,870 † £73,483 † £73,890 † £75,325 † £77,181 †
Decile 9: mean household_net_income per household £78,891 † £81,011 † £80,860 † £82,646 † £85,464 † £86,940 † £89,508 †
Decile 10: mean household_net_income per household £116,864 † £120,162 † £124,545 † £126,420 † £125,756 † £128,269 † £130,694 †
Standard reform costings (change in gov_balance): head levels
Measure (head) 2025-26 2026-27 2027-28 2028-29 2029-30 2030-31 2031-32
Raise basic rate by 1pp £6.41bn £6.66bn £6.63bn £6.85bn £7.03bn £7.25bn £7.47bn
Raise higher rate by 1pp £3.61bn £3.87bn £4.00bn £4.22bn £4.44bn £4.71bn £4.83bn
Raise personal allowance by ~800GBP/year £-3.82bn £-3.93bn £-4.01bn £-4.05bn £-4.11bn £-4.24bn £-1.95bn
Raise child benefit by 25GBP/week per additional child £-1.99bn £-1.75bn £-1.55bn £-1.38bn £-1.30bn £-1.18bn £-1.07bn
Reduce Universal Credit taper rate to 20% £-20.83bn £-21.38bn £-21.81bn £-22.02bn £-22.37bn £-22.77bn £-22.96bn
Raise Class 1 main employee NICs rate to 10% £10.89bn £11.30bn £11.71bn £12.01bn £12.31bn £12.62bn £13.00bn
Raise VAT standard rate by 2pp £24.17bn £24.97bn £25.86bn £26.46bn £27.07bn £27.68bn £28.31bn
Raise additional rate by 3pp £2.90bn £3.15bn £3.22bn £3.41bn £3.61bn £3.85bn £4.14bn
Raise the Universal Credit standard allowance by 10% £-3.06bn £-3.23bn £-3.30bn £-3.40bn £-3.48bn £-3.53bn £-3.55bn
Raise the State Pension by 10% £-7.76bn £-7.99bn £-8.22bn £-8.44bn £-8.79bn £-8.52bn £-8.86bn
Standard reforms: change in each reform's target: head levels
Measure (head) 2025-26 2026-27 2027-28 2028-29 2029-30 2030-31 2031-32
Raise basic rate by 1pp: change in income_tax £6.55bn £6.86bn £6.79bn £7.00bn £7.20bn £7.44bn £7.66bn
Raise higher rate by 1pp: change in income_tax £3.61bn £3.92bn £4.01bn £4.23bn £4.45bn £4.72bn £4.84bn
Raise personal allowance by ~800GBP/year: change in income_tax £-3.94bn £-4.07bn £-4.14bn £-4.18bn £-4.22bn £-4.40bn £-1.76bn
Raise child benefit by 25GBP/week per additional child: change in child_benefit £2.33bn £2.14bn £1.95bn £1.76bn £1.65bn £1.52bn £1.40bn
Reduce Universal Credit taper rate to 20%: change in universal_credit £20.79bn £21.36bn £21.84bn £22.07bn £22.39bn £22.80bn £23.01bn
Raise Class 1 main employee NICs rate to 10%: change in national_insurance £11.15bn £11.63bn £12.00bn £12.29bn £12.61bn £12.94bn £13.31bn
Raise VAT standard rate by 2pp: change in vat £23.98bn £24.77bn £25.66bn £26.24bn £26.85bn £27.46bn £28.07bn
Raise additional rate by 3pp: change in income_tax £2.90bn £3.15bn £3.22bn £3.42bn £3.62bn £3.86bn £4.12bn
Raise the Universal Credit standard allowance by 10%: change in universal_credit £3.06bn £3.22bn £3.32bn £3.41bn £3.48bn £3.54bn £3.55bn
Raise the State Pension by 10%: change in state_pension £10.68bn £11.17bn £11.28bn £11.60bn £12.03bn £12.46bn £12.96bn

MaxGhenis and others added 3 commits November 17, 2026 00:09
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
#2007 merged reading whom each award is payable to, through #2027's
is_on_income_support, is_on_income_based_jsa and is_on_income_related_esa,
and banding a non-dependant couple on claimant_or_partner_jsa_income and
claimant_or_partner_esa_income, so no formula changes. Add excluded-adult
cases and controls in legacy_award_readers/non_dependant_exemptions.yaml,
and add both non-dependant exemptions and the Housing Benefit individual
deduction to MEMBER_READERS. With #2007's earlier is_award_payee restored,
4 of the 8 cases fail.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…unit

The working-age families seldom put a claimant in remunerative work beside
another member's own award, so the property did not catch #2007's earlier
payee rule or the benefit-unit totals in a couple's gross income. Add a
shape: an applicant aged 70 in Maidstone and a non-dependant benefit unit
whose claimants work 35 hours on £13,000 or not at all, some with a £200
report below the tariff income on £10,000 of savings. With the earlier code
restored, the property fails in the generate phase on the council tax
reduction deduction (the couple's band); with only the earlier payee rule
restored, on the Housing Benefit exemption.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Review r1 on 3720d44: "that member has no award" was too broad, since a
claimant's £200 report and a partner's £3,000 report of the same award
leave the couple £2,368 after the £832 tariff income. Say that a £200
report on its own gives no award, that the couple's reports make one
award, and cite SI 2006/214 reg 55(4) beside reg 74(4) for the couple's
band. Docstring only.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@MaxGhenis

Copy link
Copy Markdown
Collaborator Author

@juaristi22 on C1: the filed packet now covers the Childcare Offer for Wales rule. Addendum 3 on TheAxiomFoundation/rulespec-uk#416 (TheAxiomFoundation/rulespec-uk#416 (comment)) gives:

  • Operative source: the Welsh Government's guidance for local authorities (version 8.3, April 2026), paragraphs 57, 58 and 69 verbatim, and questions 8 and 9 of the July 2020 income guidance that paragraph 70 points to. Section 1 of the Childcare Funding (Wales) Act 2019 has not come into force, so the guidance is the source.
  • Module and corpus boundary: Encode the Childcare Offer for Wales childcare element from the Welsh Government's April 2026 guidance (PE parity: PolicyEngine/policyengine-uk#1644) TheAxiomFoundation/rulespec-uk#480 queues uk/policies/govwales/childcare-offer-for-wales.yaml, whose output 2 is childcare_offer_parent_condition. axiom-corpus origin/main (7242a0229) holds no gov.wales guidance rows; the addendum names the citation paths to ingest.
  • Required output: childcare_offer_gross_income in GBP a year for each parent, feeding output 2; any income-related ESA or income-based JSA it counts reads the claimant-and-partner award.
  • Companion cases: test 20, the four cases in wales_childcare_offer.yaml (another adult's ESA or JSA leaves a parent on £96,000 eligible; under PolicyEngine's convention of counting the legacy awards, the parent's own takes their gross income to £104,000), and the invariant the Welsh high earners property checks.
  • Execution blocker: ingest the guidance, cut a UK release and rebind the toolchain in a CODEOWNERS PR; each billed encoder run then needs separate approval.

The body's axiom line now cites addendum 3, with TheAxiomFoundation/rulespec-uk#480. Since your review, 6805d2d adds #2007's tests (non_dependant_exemptions.yaml, 8 cases, and the non-dependant readers in the property file). 3720d44 adds a non-dependant property shape, because the working-age shape did not catch #2007's earlier code. 98cdbc4b1 corrects that property's docstring after the independent review.

@MaxGhenis
MaxGhenis requested a review from juaristi22 November 17, 2026 08:45
@MaxGhenis
MaxGhenis marked this pull request as ready for review November 17, 2026 08:46
@MaxGhenis MaxGhenis changed the title Count only parents' own ESA and JSA in the Wales childcare income limit; test #1966's switch Count only parents' own ESA and JSA in the Wales childcare income limit; test #1966's and #2007's switches Nov 17, 2026

@juaristi22 juaristi22 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Program review

Base repository: PolicyEngine/policyengine-uk
PR number: 2895
Reviewed head SHA: 98cdbc4
Merge base SHA: 2c57022
Mode: incremental from a8affa0
Scope: changed behavior and affected dependencies; seven PR-owned paths, C1 queue completion and new reader tests
Source manifest: /private/tmp/policyengine-command-runs/32baa0e3c673/pr-2895-sweep20261116-1956-review-sources.json
Review status: PARTIAL

Source Documents

Critical

C1 — Make the queued record dispatch-ready for the Welsh Childcare Offer change (RESOLVED)

The current repository requirement still requires a pe-parity queued issue with module/corpus citation, operative text, required outputs, same-source companion tests and the signed-encoder blocker. I read the actual current issue416/comments, addendum3 6941251151, and companion issues480/393/407; this is not acceptance of the PR body's promise or the author's private review.

Addendum3 now identifies #480's uk/policies/govwales/childcare-offer-for-wales.yaml; the April2026 and July2020 guidance ingest citations; verbatim paragraphs57/58/69 and income questions8/9; annual per-parent childcare_offer_gross_income feeding output2 childcare_offer_parent_condition; the unrelated-adult exclusion; companion20a–d and the invariant. It records missing guidance ingest, a UK release and toolchain rebind through CODEOWNERS, and separate approval for every billed signed-encoder run. Issue480 is OPEN/pe-parity and supplies the parent/child eligibility, hours, value outputs and wider same-source companions. Issue416 is OPEN/pe-parity, and the new comment hash dd35d21afa0948db2c4e37a2f37a326844f69f45afcf1ce37b4fac3af567f1a8 matches the source watch. Issues393/407 supply the existing CTR/non-dependant context, not a replacement for the newly filed Wales consumer.

The passage allowing an encoding to omit legacy benefits is explicit, rather than an undisclosed claim that the guidance uniquely dictates their inclusion. For this reader change, both admissible approaches must exclude a non-parent adult's own award. Cases20c/d separately declare the PolicyEngine legacy-count convention. The relevant unit change, outputs and companion obligations are dispatchable without pretending the entire module is already encoded or the signed encoder has run. This satisfies the demonstrated C1 completion requirement; the billing/ingest work remains queued and no encoder execution was authorized or attempted here.

C2 — Complete the required Test / Result check at the reviewed head (OPEN)

The current required Test / Result job133960336726 is FAILURE, not a superseded attempt. Official job metadata binds it to 98cdbc4b1bc548eb0452e3ebd052c7ad0c47822d. Python7/8 job133914606729 was cancelled after90 minutes; its official annotation explicitly says it exceeded1h30m0s. The result job fails both the all-jobs-success gate and the outcome-coverage check (.github/workflows/test-suite.yaml:310,:341):14,119 collected tests,12,041 outcomes (11,989 passed,50 skipped,2 xfailed), and 2,078 collected tests with no outcome. This confirms a required-check/execution blocker, not a newly established policy assertion failure or a measured Wales/HB error. Provide healthy complete execution before approval; neither local passes nor author-attributed prior runs satisfy this gate. Raw job, annotations and Result log are retained in the technical receipt.

Should Address

None.

Suggestions

None.

Evidence Gaps

  • LOCAL_EXECUTION_COMPLETION: 95 of122 selected local checks remain unfinished after the bounded campaign;27PASS/0FAIL, all16 newYAML passed. Complete the named remaining tests or obtain qualified exact-head hosted execution; current required CI is incomplete/failing.
  • Role checks incomplete: pr-2895-sweep20261116-1956-review-code.md; see recovered report.

Notes

  • Review completion and severity are separate. The automatic partial-role gap below is an alias for the single named required gap, not a second missing question.
  • No foreign branch/source edits, fixes, merges, private data runs, dependency installs or billed encoders.
  • Role reports and raw receipts retain exact validation premises and excluded exploratory attempts.
  • Only seven PR-owned paths relative current main are audited; the wide prior-head interval contains unrelated main imports. CTR/HB production is unchanged.
  • The Welsh £6,720 is provider-funded childcare valuation, not cash paid to parents. High-wage own-ESA/JSA cases are stored-award reader controls, not lawful means-tested entitlement. Equal couple splitting remains a disclosed model convention.
  • Policy progress-log maximum gap230.314s exceeded its120s cadence and is recorded; acquisition and completion clocks were not reset.
  • Setup/role/cleanup intervals use captured clocks; scope/dispatch overhead was not separately timed and remains in total elapsed. Heartbeat delivery and app interruption clocks are retained separately in caller acceptance. No source or CI timing was reset.

Validation Summary

Current local:27PASS(16newYAML+11Python),0FAIL,95unfinished/122selected; one actual pytest invocation, original540s window retained, timeout124. Six final2025 Wales Offer controls returned6720/6720/0/0/6720/6720, and two finalCTR controls1480/1740, separate frompytestcounts. Exact snapshot imports,17lockedpins,194Core3.34.9payload hashes verified via read-only cached overlay; noinstall. Invalid diagnostic/setup attempts preserved and excluded; HBzero is notpositiveHBcoverage. Prior173passes remain historical only. Latest exact-head requiredTest/Result133960336726FAILURE followsPython7/8 90mtimeout,2078missing outcomes.18officiallaw/guidancepairs(13reuse5new),8currentGitHubtechnicalpairs; zero source rejects/discards,0PDF renders,167.061s newacquisition. No privatepopulation/authorSubfleet proof adopted.

Timing

setup seconds: 5.24s; elapsed seconds: 1055.95s; adjudication seconds: 0.00s; consolidation cleanup seconds: 196.41s; code role seconds: 820.59s; policy role seconds: 729.32s; parallel review seconds: 820.59s

Review Severity

REQUEST_CHANGES. Open findings: 1 critical, 0 should address, 0 suggestions.

@MaxGhenis

Copy link
Copy Markdown
Collaborator Author

@juaristi22 on C2: the 90-minute job limit cancelled Python 7/8 in all four attempts of run 44046798159 at 98cdbc4b1, and no test failed in any of them:

  • Attempt 1 reached 99% with 2,066 tests passed, 11 skipped and none failed or errored; the shard uploaded no outcomes for its 2,078 tests.
  • Attempt 2 reached 100% with 2,067 tests passed and 11 skipped; the limit cancelled the job about two seconds after the last test, before it uploaded outcomes.
  • Attempt 3 uploaded outcomes for all 2,078 tests, so Test / Result's outcome-coverage check passed across the 14,119 collected tests (14,056 passed, 61 skipped, 2 xfailed). Its all-jobs-success gate failed because the limit cancelled the shard during its Codecov upload.
  • Attempt 4 reached 99% with 2,064 tests passed, 11 skipped and none failed or errored; the shard uploaded no outcomes.

Python 7/8 runs close to the limit on main too: main's push run 43904807430 needed 89.5 minutes for it, and the merge queue's run 44600036553 for #2926 on 19 November needed 89.1. With this PR, Python 7/8 runs 2,078 tests against 2,079 in main's push run, and the two test lists differ only in three Wales offer source cases whose ids name the income sources this PR swaps. Python 6/8 ran both new property tests and passed.

I haven't changed the code since your review and won't rerun the shard. Once #2919 merges and spreads main's tests over ten shards, I'll merge main into this branch for a fresh run and re-request your review when that run passes.

I've updated the body's Enhanced FRS section to report CI's aggregate impact run at this head: base 2c570224b1 against merge 72c8d60642, with no household net income changes in any year from 2025-26 to 2031-32.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants