Repository navigation
Guard against random draws in the engine - #2873
Conversation
Port policyengine-us's scanner for engine-time randomness and hash draws as a code-health test. EXEMPT lists the package's SHA-256 digests, which fingerprint, key caches or check content; RATCHET lists today's draws: the splitmix64 helper, the formulas and uprating that call it, and the seeded numpy draws in participation and two scenarios. Cases that need newer syntax are filtered at collection, so no Python reports a skip. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LwQq6H1FBndAKeuXdSGuft
|
Ready for hub review Head: Pre-flight
Comparison with the reference (after formatting)
The scanner from the constants down to Lists, reconciledMy run on I read every function behind the digests. All are SHA-256 used for provenance, a cache key or a content check, and none decides who gets something or meets a threshold. The two that the code compares are:
The ratchet draws I read:
One possible difference from the brief: without Observations, not acted on:
Star imports in a possible cycleThe scanner's own graph shows 9 of 1,432 star imports (1,418 of them from package modules) in a possible cycle:
Tests (all on
|
| Python | Collected | Passed | Skipped | Wall time | Peak RSS |
|---|---|---|---|---|---|
| 3.11.18 | 369 | 369 | 0 | 18.8 s | 56 MB |
| 3.12.3 | 380 | 380 | 0 | 22.7 s | 59 MB |
| 3.13.18 | 382 | 382 | 0 | 20.3 s | 59 MB |
| 3.14.6 | 382 | 382 | 0 | 18.8 s | 65 MB |
3.11 leaves out the 13 cases that need 3.12 or 3.13 syntax; 3.12 leaves out the 2 that need 3.13.
Caveat: the brief's bare uvx … pytest <file> --noconftest gives collection errors on every Python. pytest 9 sets up the policyengine_uk Package node above the file, which imports policyengine_uk/__init__.py, and that needs policyengine-core. I ran instead through a scratch plugin (-p skip_package_init) that turns _pytest.python.Package.setup into a no-op. The plugin is not committed. The guard itself imports only the standard library and pytest.
The guard file in the locked environment, serial, with conftest: 28.8 s wall, 316 MB peak RSS. Most of that memory comes from the conftest importing the model. The longest single call is the first package_scan (about 7 s; the scan alone takes about 7.8 s for 1,534 modules on 3.13).
The wheel: uv build --wheel (sha256 48570c87…), locked environment with --no-install-project, then uv pip install --no-deps the wheel, run from an empty directory against the installed tests directory: 382 passed. The scan reads the same 1,534 modules with identical counts and lines.
uv run pytest policyengine_uk/tests/code_health -n 4: 3,544 passed. Before I added the fixture, it gave 1 failed (test_every_test_module_cache_is_released) and 3,543 passed.
ruff format --check ., ruff check ., ruff check --select F811,F821 policyengine_uk (all ruff 0.17.2) and git diff --check pass.
Mutation checks (scratch copies; all killed)
import randomadded towarm_home_discount_random_draw.py: killed.stochastic import (1 found, 0 allowed).- A second
splitmix64_uniformcall inwarm_home_discount_random_draw.formula: killed.draw helper call (2 found, 1 allowed). - A new
new_drawsindata/economic_assumptions.pythat callssplitmix64_uniform: killed.new_draws: draw helper call (1 found, 0 allowed). - One ratchet occurrence removed (the module-level
Scenarioinpip_reform.pyreplaced): killed as stale bytest_allowlist_entries_still_match. - The
xorshiftentry raised from 3 to 4, which takesRATCHETto 22 against a ceiling of 21: killed bytest_ratchet_only_shrinksand as stale. - The
_fingerprintEXEMPTentry removed: killed. The hash use and 7 draw helper calls spread throughcapital_gains_projection.py,simulation.pyandtax_benefit_system.py.
Open work, checked
I ran the guard over each PR's head:
- Break wealth-decile ties by a fixed hash of household_id #2618 (
47ee0515b):_fixed_hashreports 3hash constantand 3xorshift, plus adraw helper callinhousehold_wealth_decile.formula, as the brief says. It also reports thewarm_home_discount_random_drawentry stale, because its base (3bcacaaa2) predates that file. - Give UK simulations a working subsample #2265 (
e4c54d7fa) and Count only supplied inputs that are still stored in their tier #2308 (5b4dc2143):utils/subsample.pyreports_random_state(hash use,random source), a module-levelrandom source, anddraw_household_counts(sampling callanddraw helper call).subsample_simulationandSimulation.subsamplealso report draw helper calls. Both also report findings and stale entries from their older bases (for example arandom sourceinuprate_student_loan_plans; and in Count only supplied inputs that are still stored in their tier #2308, 3random sourceinapply_participation_responsesand draw helper calls inSimulation.build_from_*). These clear when the PRs mergemain. - Reuse prepared current-law baselines for local H5 scenarios #2862 (
3886de2d1):_core_fingerprintreports a hash use and spreads to_identity,prepare_current_law_baseline,reuse_prepared_baseline,validate_prepared_baseline_request,Simulation.__init__andSimulation.prepare_baseline.
None has merged.
Judgment calls
- No changelog fragment.
check_changelog_fragments.pyonly warns when a PR adds none, a fragment would trigger a release for a tests-only change, and recent tests-only commits onmain(abab81f8b,c78f88649,8199bc05e,c9397c23e) add none.github-prs.mdsays every PR needs one, so the hub may wantchangelog.d/deterministic-engine-guard.changed.md. - I added the cache-release fixture (hunk 4 above) to meet pe-uk's own code-health rule.
- The PR body has no
Fixesline, because no issue exists for this work.
CI on 0835944 (checked 05:57Z)
All seven Test / Python shards, Test / YAML and Test / Result pass, so the strict outcome check found no new skip, xfail or XPASS. Changelog fragments, Changes, Documentation build, Fix evidence, Lint, the four install and smoke-import jobs and Release build also pass. Aggregate impact was still running at 05:57Z, after 73 minutes. No push was needed.
Skipped
Nothing needs private data. I didn't run the full suite; CI covers it.
Generated by Claude Code
Aggregate impact on certified data: passBase Checks: 0 broken by this change, 1 failing on both sides, 0 fixed. Moves flagged for review: 0 (thresholds in Notes
Moves flagged for reviewNone. Spending by benefit and service
Caseloads
Household net income by decileNo household's net income changes in any year. No change in any year: receipts by tax head; government balance, each component counted once; model totals; household income totals; population; poverty rates; people in poverty; inequality; mean household net income in each side's own deciles; standard reform costings (change in gov_balance); standard reforms: change in each reform's target. Checks failing on both base and head (1)
Counted-once checkThe check raised each of 92 components by £1 per unit in 2026-27 and read every head of its totals household by household: its own head must rise by exactly £1, no other tax head may move, no other benefit may rise, and the model's own total must move by what its heads moved. A response that is not finite breaks every rule. The check measures a head that breaks a rule twice more: once holding every other head at its baseline value, and once holding every other head at its value after the first £1 while the component rises again. The head fails where either measurement still shows the response. The check cannot hold a head at a value that is not finite. In each unit where another head is not finite after the first £1, it holds that head at its baseline value, and the second measurement judges no household the unit belongs to. There a head fails wherever it first broke a rule, or wherever the check could not confirm whether its response contains the component. 0 failed and the check skipped 0.
Provenance
Dataset: Receipts by tax head: head levels
Spending by benefit and service: head levels
Caseloads: head levels
Government balance, each component counted once: head levels
Model totals: head levels
Household income totals: head levels
Population: head levels
Poverty rates: head levels
People in poverty: head levels
Inequality: head levels
Mean household net income in each side's own deciles: head levels
Standard reform costings (change in gov_balance): head levels
Standard reforms: change in each reform's target: head levels
|
|
Ready for hub review Verdict: REQUEST_CHANGES at The port is faithful, every test passes on every Python, and the lists match the scan entry by entry. Three things need to change before merge: a model output that differs between runs and that neither the lists nor the stated limits cover, a missing changelog fragment whose cited precedent doesn't hold, and advice to four open PRs that the ratchet's own ceiling rules out. None is P1: CI is green and no model output changes. All runs below used a detached scratch worktree of the head, with FindingsP2-1. Formulas read the clock, and neither the lists nor the stated limits say so
A mutation confirms the guard can't see this. A new formula returning Replacement text:
P2-2. The PR needs a changelog fragment, and the hand-off's precedent says the opposite of what it shows
Add P2-3. Three of the four open PRs can't "carry their own entry"The body says: "The guard fails each of these PRs until it carries its own entry or changes." I merged the guard's head into each spot-checked head (
Replace the section's opening sentence and the #2862 bullet with: and add to the #2618 bullet: "Its hash orders tied households and so decides their decile; #2618 must order ties without a hash, for example by P3-1. The "82" sentence says the spread reaches 82 occurrences; it reaches 40The scan without Body replacement: "Without P3-2. "So
|
The guard's docstring now says it looks for draws and not for the clock (#2875). The comments on the splitmix64 and Universal Credit entries say which constants the scan recognises, which entries reach the hash and how Simulation.__init__ applies the modifier. Two test rows follow PolicyEngine/policyengine-us#10447 at 221f2fe44, and a changelog fragment records the guard. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
juaristi22
left a comment
There was a problem hiding this comment.
Review at 6f4d3313060987611bd00da46d3f392ffda1013e — COMPLETE; no confirmed findings or material evidence gaps.
All 389 focused checks passed (384 randomness-guard checks and five cache-release checks). The manual review covered alias/import resolution, scope handling, exclusions, model inventory and ratchet behavior, and compared the earlier-head author review with the fixes adopted in this head. Conclusions apply to the guard’s documented static-analysis scope and exemptions.
The PR remains draft; this is a review comment, not an approval.
juaristi22
left a comment
There was a problem hiding this comment.
Review status: COMPLETE — approved at 6f4d3313060987611bd00da46d3f392ffda1013e. No findings or material evidence gaps remain.
The head and description are unchanged from the completed review. I retained the verified 389 prior test passes (384 randomness-guard cases and five module-cache checks), together with the completed resolver/import-graph and author-feedback assessment; no code review or tests were repeated for the readiness change.
The PR is now ready for review. Fresh checks pass at this exact head, including the required Lint and Test / Result contexts. Historical benchmarks and the guard's documented limits retain their original qualifications.
Main gained Simulation.subsample and policyengine_uk/utils/subsample.py through #2308 on 9 November, after this branch's last CI run. The guard scans the whole package, so the merge queue ran it over that code and removed #2873 for a failed check on 11 November. The merge has no conflict: main does not touch the guard or its changelog fragment. On the merged tree the guard reports eight draw patterns, all in the subsample code; the next commit handles them. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
On main's code the guard reports eight draw patterns, all in the subsample tool that #2308 added. Five sit in policyengine_uk/utils/subsample.py, where it hashes the seed, makes a generator and draws households. The other three are the calls that reach them, in draw_household_counts, subsample_simulation and Simulation.subsample. This commit lists the eight in a third allowlist, SAMPLING_TOOLS. The two package tests allow RATCHET and SAMPLING_TOOLS summed per key. draw_helpers still reads EXEMPT alone, so the tool's functions stay draw helpers and a use of one from any other scope counts there as a draw helper call. RATCHET, RATCHET_CEILING, EXEMPT and the scanner do not change. Four new guard tests pin the list. The tool's three functions are draw helpers. A formula that uses a listed sampler fails. The list names only the subsample tool and shares no key with RATCHET or EXEMPT. No package module uses an attribute named subsample, because the scan does not follow method calls. A new test in test_subsample.py checks that the draw neither reads nor moves numpy's or the standard library's global random stream. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@juaristi22, the new head, At All 386 guard tests pass on this head locally, and CI runs on it now. The merge stays with you. |
juaristi22
left a comment
There was a problem hiding this comment.
Follow-up review of 697529ba571a36860cc9b1cefadb11a8831c49af, incremental from 6f4d3313060987611bd00da46d3f392ffda1013e.
Code review COMPLETE: no findings or material evidence gaps. The eight SAMPLING_TOOLS occurrences are checked alongside the ratchet without treating them as non-draw digests. All three sampling functions remain draw helpers, so unlisted callers and extra occurrences still fail. RATCHET, EXEMPT and the ceiling retain their values. The documented static-analysis limits remain explicit.
Validation: 18 focused tests passed, including the four new guard tests, both global-stream cases and native UK subsampling/seed regressions (15.65s pytest; 21.20s wrapper). The current 1,616-module scan has no unexpected occurrences or stale entries. The exact upstream commit/blob reference also matches the official source. Unchanged detector behavior was retained from the prior review rather than rerunning the full generic suite.
Approval remains deferred pending CI. At the final evidence capture, Lint passed, but the required Test / Result check was not yet available and seven Python shards were still running. This completes the requested code re-review; the merge hold now waits on required checks at this exact head. I will recheck CI without repeating the completed code review.
juaristi22
left a comment
There was a problem hiding this comment.
Approval of 697529ba571a36860cc9b1cefadb11a8831c49af, completing the CI gate after the code re-review.
The review remains COMPLETE with no findings or material evidence gaps. All 21 current CI contexts have passed, including required Lint and Test / Result. The head, description and human review activity are unchanged; the prior 18 focused passing tests and source checks remain valid. No code review, model calculation or test execution was repeated for this approval.
The reviewed sampling-tool fix, completed re-review and successful exact-head CI satisfy the hold requested for this PR.
Addresses #2874
axiom: n/a: tests only
Why
policyengine-core bans randomness in variable formulas, so the data build has to draw each stochastic input and store it (PolicyEngine/policyengine-core#500). Core's own check looks for numpy and stdlib randomness in formulas, but it misses the splitmix64 hash of entity ids in
policyengine_uk/utils/stochastic.pyand the seeded numpy draws outside formulas. This PR addspolicyengine_uk/tests/code_health/test_no_engine_time_randomness.py, which fails on any new draw. It lists today's draws as a ratchet and the draw inSimulation.subsampleas a sampling tool. Later PRs move each ratchet draw into the data build and lower the ratchet. This PR changes no model code and no output.Where the guard comes from
The file ports the scanner of PolicyEngine/policyengine-us#10447 at
221f2fe44ff265b8911810bcc440b3586fa6fc51(policyengine_us/tests/code_health/test_no_engine_time_randomness.py, git blob15b6826c0ebecbec84c6b51f128e5f76226e0e47). The scanner, from the constants down topackage_scan, and every generic detector test stay as they were. The port changes only:policyengine_ustopolicyengine_uk;RATCHET,RATCHET_CEILING,EXEMPTandOFFLINE_MODULES(empty: the scan finds no offline tool that needs one, sotest_model_never_imports_offline_modulespasses trivially until a module joins it);SAMPLING_TOOLS, a third list that the pe-us guard does not have, and_summed, which adds two lists' counts per key;test_package_draws_nothing_outside_the_allowlistsandtest_allowlist_entries_still_match. The pe-us guard passesRATCHETtocheck_allowlistsas its first list, and these passRATCHETsummed withSAMPLING_TOOLS;test_the_subsample_tools_functions_are_draw_helpers,test_a_use_of_a_sampling_tools_function_from_another_scope_fails,test_sampling_tools_lists_only_the_subsample_tool_and_no_key_is_in_two_listsandtest_no_package_module_uses_the_subsample_method;test_model_api_passes_on_cores_numpy_and_its_own_helpersnow checks a pe-uk variable module andadd_for_members, whichpolicyengine_uk/model_api.pypasses on;test_splitmix64_hash_and_its_uprating_caller_are_draw_helpersreplaces the pe-us start-month test; the offline-import tests check an example name of their own,policyengine_uk.tools.offline, since pe-uk has notoolspackage;SAMPLING_TOOLS;package_scan's cache when the module's tests finish, astest_test_module_caches_released.pyrequires of every test module;pytest.skipcalls for cases that need newer syntax._on_this_pythonfilters those cases as pytest collects them, and two tests whose cases all need Python 3.12 sit underif sys.version_info >= (3, 12), so no Python collects a case it cannot parse and no run reports a skip. Every case stays.The PR also adds
test_the_draw_neither_reads_nor_moves_the_global_random_streamstopolicyengine_uk/tests/test_subsample.py.The lists
EXEMPTholds 21 digest occurrences in 9 files. Each computes a SHA-256 for provenance, cache keys, content checks or an equality check, and none decides who gets something or meets a threshold:build_metadata.pyget_data_build_fingerprintdata/capital_gains_projection.py_fingerprintdata/dataset_sources.py_cached_dataset_pathdata/economic_assumptions.pyuprating_input_fingerprintutils/aggregate_impact/__main__.py_sha256utils/aggregate_impact/dataset.pysha256_fileutils/aggregate_impact/measure.py_digest_tool_files,definitions_digest,model_fingerprint,runtime_identityutils/aggregate_impact/partition.pyload_partitionutils/build_lha_published_rates.pyfetcheach with its module's
hashlibimport.RATCHETholds 21 occurrences in 10 files, soRATCHET_CEILING = 21:utils/stochastic.py:splitmix64_uniform, the three splitmix64 constants and three xorshift steps;uc_deduction_random_draw.py,uc_deduction_type_random_draw.py,warm_home_discount_random_draw.pyandmonths_since_last_birthday.py: one formula call each tosplitmix64_uniform;data/economic_assumptions.py:uprate_student_loan_planshashesperson_idand compares the draw with the take-up rate;apply_single_year_uprating,apply_uprating,extend_single_year_datasetandSimulation._extend_dataset_with_cgt_provenanceinsimulation.pyreach it;dynamics/participation.py: a seeded numpyRandomStateinapply_participation_responses;scenarios/uc_reform.py: a seeded numpyGeneratorinadd_universal_credit_reform, and the module-levelScenariothat passes it on;scenarios/pip_reform.py:np.random.seedandnp.random.randominmodify_simulation, and the module-levelScenariothat passes it on.SAMPLING_TOOLSholds the 8 occurrences of one sampling tool in 2 files.Simulation.subsampledraws households when a caller calls it, and the draw decides which households the simulation keeps and the weights they carry. It draws from a generator of its own, which it seeds from the caller's seed or the fixed default"policyengine-uk":utils/subsample.py: thehashlibimport;_random_state, which seeds a numpyRandomStatefrom the SHA-256 digest of the seed's text, and its return annotation; thechoicecall indraw_household_countsand that function's call to_random_state; andsubsample_simulation's call todraw_household_counts;simulation.py:Simulation.subsample's call tosubsample_simulation.draw_helpersreadsEXEMPTalone, soEXEMPTentries would stop_random_state,draw_household_countsandsubsample_simulationcounting as draw helpers, and a formula could then call_random_statewith no finding.RATCHETentries would needRATCHET_CEILINGto rise from 21 to 29, which the file says never to do, andRATCHETlists draws that later PRs move into the data build; #2874 names no such step for the subsample. UnderSAMPLING_TOOLSthe three functions stay draw helpers, andRATCHET,RATCHET_CEILINGandEXEMPTkeep their values.The scan over
mainat74db8b6793b13810c52e5d33f2bb3437adb79046reads 1,616 modules, cuts no lookup at the depth limit and finds no other draw pattern. WithoutEXEMPT, the scan reports 90 occurrences in 22 files: the 21 inRATCHET, the 21 digests, the 8 inSAMPLING_TOOLS, and 40 draw helper calls that reach the digests.Invariants
test_package_draws_nothing_outside_the_allowlists, including a second call in a scope the lists already name and a new function in a listed file.test_allowlist_entries_still_match, andtest_ratchet_only_shrinksfails whenRATCHETexceedsRATCHET_CEILING. SoRATCHETcan't grow unless a change also raisesRATCHET_CEILING, which the file says never to do._random_state,draw_household_countsorsubsample_simulationcounts as adraw helper callin its scope, under any name the code imports the function as. So a use in a scope with nodraw helper callentry failstest_package_draws_nothing_outside_the_allowlists, and so does a use beyond a listed scope's entry.test_the_subsample_tools_functions_are_draw_helpersfails if a change takes any of the three out of the draw-helper set, asEXEMPTentries for the tool would.SAMPLING_TOOLScan name only occurrences inutils/subsample.pyand the one call inSimulation.subsample, and no (file, scope, kind) key can sit in two of the three lists.test_sampling_tools_lists_only_the_subsample_tool_and_no_key_is_in_two_listsfails otherwise.subsample:test_no_package_module_uses_the_subsample_methodfails on one.draw_household_countsgives the same counts for a seed whatever numpy's and the standard library's global random streams hold, and leaves both streams as they were (test_the_draw_neither_reads_nor_moves_the_global_random_streams).The guard reports recognised patterns, so it works as a ratchet, not a proof that no hand-written draw exists. It inherits every limit the docstring lists: it does not follow
evalorexec, imports of a computed name, values reached through objects or containers, or methods as draw helpers. For example,Simulationcallsuniversal_credit_july_2025_reform.simulation_modifier(self)through an object, which the scan does not follow. The guard does not scan policyengine-core, so it cannot show that nothing downstream reads numpy's global stream. It also looks for draws and hashes, not reads of the clock (#2875).policyengine_uk/tests/code_health/test_formulas_do_not_read_the_clock.pyscans the modules undervariablesfor those.Three limits apply to the sampling tool:
simulation.subsample(n=1000)in a scenario. The test on the attribute name catches that spelling and missesgetattr._random_statethat returns an unseededRandomStatechanges no count.policyengine_uk/tests/test_subsample.pytests that behaviour:test_the_same_seed_keeps_the_same_householdsfor the seed and the new test for the global streams.draw helper callentry, such as each of the four ratcheted formulas, can swap its call for one of the tool's functions with no finding.SAMPLING_TOOLShas no ceiling. A PR that lists a draw from another file there has to change the test that limits the list to the subsample tool.Interaction with open work
maingainedutils/subsample.pyandSimulation.subsamplethrough #2308 on 9 November. This PR mergesmainand lists the tool's eight occurrences inSAMPLING_TOOLS.The file says never to raise
RATCHET_CEILING, so neither of these PRs can add aRATCHETentry. The guard fails each of them until the PR changes or, for #2862, adds anEXEMPTentry:_fixed_hashinvariables/household/wealth/household_wealth_decile.py, a copy of the splitmix64 mix that orders tied households and so decides which decile each falls in: threehash constant, threexorshift, and adraw helper callfrom the formula. It needs a tie-break without a hash, or a stored draw._core_fingerprintinutils/prepared_baseline.py, which identifies policyengine-core's code and decides no household's outcome. AnEXEMPTentry forutils/prepared_baseline.py,("<module>", "hash library"): 1and("_core_fingerprint", "hash use"): 1, clears all ten occurrences the guard reports.Impact
Impact: none; tests only.
Tests
On commit
697529ba571a36860cc9b1cefadb11a8831c49af, pytest (Python 3.12.14, policyengine-core 3.34.9, Hypothesis 6.170.15) passes all 386 tests in the guard file. On the commit before it, which differs only in one comment line of the guard file,policyengine_uk/tests/test_subsample.pygives 60 passed and 2 failed, the new test's two cases among the passes. The two failures,test_where_capital_gains_inputs_came_from_is_keptandtest_a_neutralised_capital_gains_input_still_reads_as_its_default, look up the installedpolicyengine-ukdistribution, and that run used an exported tree with no install. They fail the same way onmain's tree in the same environment. CI on the pushed head runs both files on an installed package.These checks ran on
697529ba5with Python 3.12.14. Each loads the guard file by its path and calls its functions, and none starts pytest or importspolicyengine_uk:package_scan, thencheck_allowlistswith the three lists): 1,616 modules, no draw pattern outside the lists, no entry that allows more than the scan finds, no lookup cut at the depth limit, 11 draw helpers. WithRATCHETas the first list on its own, the scan reports the tool's eight occurrences.SAMPLING_TOOLSentries makestest_package_draws_nothing_outside_the_allowlistsfail with one finding. Raising any one to 2 makestest_allowlist_entries_still_matchfail with one entry.Variableformula, under an alias and throughpolicyengine_uk.simulation) and a control that draws from numpy directly. It misses a scenario that callssimulation.subsample(frac=0.1), whichtest_no_package_module_uses_the_subsample_methodreports, and agetattrwith a computed name on a dynamic import, which nothing reports.EXEMPT, the draw helpers fall from 11 to 8 andtest_the_subsample_tools_functions_are_draw_helpersfails.The new
test_subsample.pytest also passes when called on the source of_random_stateanddraw_household_counts, compiled outside the package with numpy 2.5.4, and fails on six edits of that source that read or move a global stream.ruff format --checkandruff check(ruff 0.17.2, the versionuv.lockpins) pass on both changed test files at697529ba5.🤖 Generated with Claude Code