Skip to content

Sim's table models still map the report columns API v1 drops #1110

Open

Description

@anth-volk

API v1's revision 4e30076d4b9f (PolicyEngine/policyengine-api#4335, C1 · 41) drops nine columns from the v2 report tables:

  • reports.label, description and user_id, with the foreign key fk_reports_user_id_users and the index ix_reports_user_id;
  • report_runs.trigger, baseline_cliff_gap, baseline_cliff_share, reform_cliff_gap and reform_cliff_share, with the check ck_report_runs_cliff_impact_complete;
  • budget_window_runs.trigger.

Sim's mapped classes in libs/policyengine-simulation-persistence/src/policyengine_simulation_persistence/tables.py still declare all of them. Once #4335 merges, test_the_models_match_the_public_api_tables fails against API v1's master, so the weekly drift run (public-api-schema-drift.yml) fails, and no PR can move public-api-commit past that merge.

Done when:

  • Report, ReportRun and BudgetWindowRun declare none of these columns, constraints or indexes.
  • libs/policyengine-simulation-persistence/public-api-commit names #4335's merge commit, so the comparison and the weekly drift run pass.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions