Skip to content

Remove the staging v2 route checks that need the Public API's catalog first #1087

Closed

Description

@anth-volk

The staging deploy's two v2 route checks, "Calculate the staging household through the candidate" (staging_household_check, added in #1046) and "Create a staging economy report through the candidate" (staging_economy_check, added in #1052), run after the deploy moves the v2 default to the release's worker. Both routes look up the Public API's catalog version for that worker's policyengine.py version, and the Public API publishes catalog rows only for the version it has installed.

The Public API cannot move to a new policyengine.py version until this service has deployed it, so for every new version these checks fail on the staging deploy and the production deploy is skipped. Deploy run 43946222393, for policyengine.py 6.20.0 (#1076), failed this way: both routes answered 400 unknown_catalog_version.

Remove the two checks from simulation-deploy.reusable.yml and from the requirements of deployment_ready. The v2 routes answer unknown_catalog_version for a new version until the Public API's own deploy publishes its catalog; no client calls them yet, and the two services are being merged into one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions