Repository navigation
Conversation
On main, nz.geo.assign refuses before placing any household: the four layers in nz/geography_assignment.json declared source "atomic_geography_support.json", vintage "ta2026_regc2025_au2017" and relation "exact", while the transport support's columns say otherwise (for example, as_area is a best_fit AU2017 bridge). atomic_geography._bind requires each layer's labels to equal its support column's. Take-up reads this node's outputs, so step 4 would have stopped here. The generator now copies each layer's source, vintage and relation from the support column it reads. A new test runs the committed assignment on the committed transport support through assignment, derivation and the gate, and checks that changing any one label refuses. The existing test built its layers from the column labels, so it never read the committed assignment. Found by the Belgium lane while mapping its own geography step. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
On main,
nz.geo.assignrefuses before it places any household. NZ's step-4 run would stop there.atomic_geography._bindrequires each layer's source, vintage and relation to equal the support column it reads. Innz/geography_assignment.json, all four layers declared:atomic_geography_support.json;ta2026_regc2025_au2017;exact.The columns in
nz/transport_atomic_geography_support.jsonsay otherwise:ta_codeta_2026official_tabulationregion_coderegc_2025official_tabulationas_areaau_2017best_fitas_area_altta_2025best_fitChange
tools/build_nz_transport_graph.py: each layer now copies its three labels from the support column it reads. This is the same in-memory definition the generator writes as the transport support,as_area_altincluded.nz/geography_assignment.json: regenerated. No other generated resource changes;--checkpasses for all three NZ builders.tests/golden/nz_country_spec.json: the new hash forgeography_assignment.jsonand the new NZ fingerprint.test_nz_joint_geography.py: a new test runs the committed assignment on the committed transport support through assignment, derivation and the gate. It also checks that changing any one label of any layer refuses. On main the test fails with "Atomic geography: layer source, relation or vintage differs"; on this branch it passes. The existing test built its layers from the column labels, so it never read the committed assignment.changelog.d/nz-geography-layer-labels.fixed.md: the fragment.The draws key on the definition's hash, so households' sampled areas change. No NZ run has produced output at the old bytes.
Scope
NZ-only. There are no changes to shared code and no shared test hunks. Belgium found this while mapping its own geography step.
Local checks
Serial run of five files at d9b0207 (the head before the changelog-only commit 622a98e):
test_nz_joint_geography.py,test_atomic_geography.py,test_country_spec.py,test_nz_transport_declarations.pyandtest_spec_engine_country_bundles.py. All pass; the pinned-source replay tests skip without their environment variables.ruff checkandruff format --checkpass on the changed Python files.axiom: n/a: Microcosm geography declaration fix; no Axiom encoding, RuleSpec or runtime change
🤖 Generated with Claude Code