Repository navigation
Move the US engine to policyengine-us 2.145.3 and prepare the Route A national build - #1676
juaristi22 wants to merge 43 commits into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…e refresh Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The three US extras move from policyengine-us 2.2.1 / core 3.32.5 to the newest release at lock time (2.145.3, 17 Nov), which needs core >=3.36.0 and spm-calculator 1.1. uv then resolves one core for both forks, so the UK side moves from 3.34.10 to 3.36.1 as well (ruled 17 Nov). Core 3.35-3.36.1 adds a situation hook, an opt-in uprating base mode and a calculate_add crash fix. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The driver used BSD stat and a df whose output wraps on Linux, so on a Linux host every input failed its size check. file_bytes tries GNU stat, then BSD stat; free_bytes reads df -Pk. The tests no longer shim stat, so CI's runner exercises the GNU path. STOP_BEFORE_RELEASE=1 stops after the base, the base preflight and the release config, so the release's gates can be dry-run on the fresh base (tools/dry_run_us_release_gates.py, #1042) before the multi-day release (ruled for the next national build on 17 Nov 2026). The README gains a Linux section (settings, tmux, systemd) and links the operator runbook. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
policyengine-us 2.145.3 adds takes_up_medicare_part_d_if_eligible, takes_up_csfp_if_eligible, takes_up_school_meals_if_eligible (SPM unit) and takes_up_ak_permanent_fund_dividend_if_eligible, all defaulting to true. The take-up mapping must be total over the engine, so each joins the spec, the contract and the generator as an engine-owned program left at its default (rate_unsourced, no locked source), as ruled on 17 Nov 2026. That reproduces 2.2.1, which paid all four programs to every eligible person. The ABI program count moves from 17 to 21, and each input gets a battery metric and a take-up operator boundary entry. The engine ABI lock is regenerated with the other re-pins. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Mortgage legs (ruled R16): policyengine-us removed the tax-unit first/second_home_mortgage_interest legs (policyengine-us#9605). The PUF chain stops producing them; the person-level home_mortgage_interest carries the amount. The eCPS parity gate records the two retired reference layers instead of grading them (ported from #1365). The late transfer surface drops to 71 targets and the stacked surface to 139. - Stored-input register: seven entries are engine inputs on 2.145.3 (tax_unit_role_input, parent_1_id, parent_2_id and the four federal student loan inputs) and leave it. The pool's build-time simulation projection keeps microunit's tax-unit roles (#1027, ruled R14). - QBI (ruled R10): the base ASEC channel keeps the engine's own qualification defaults; estate income now defaults to non-qualified. - Location (ruled R17): the release copies the base's household-location root attributes onto its H5 and records them, so a block_v1 national file no longer reads as legacy to ACS staging (#1647). - OBBBA estate row (ruled R13): noted as zero by construction, since estate_tax needs is_deceased, which no release stores. - IRMAA holdout: the engine falls back to the earliest input year (policyengine-us#10106), so a single-year release now has payers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Ruled 17 Nov 2026 (R7), the smallest fix for the tail failures of the 19 Oct and 3 Nov national runs: 1. The tail-concentration gate and its per-run register now measure the release's base frame at pre-calibration weights, where the QRF draw artifact the gate guards (#462) lives. On the 3 Nov base most columns that failed at final weights sat at 0.45-0.63 before calibration: the excess came from calibration putting weight on few carriers. The share at the export's final weights is still measured and reported in qrf_tail_concentration.json (schema 2, final_weight_report), and decides nothing. The gate shadow reads the same base frame, so both verdicts agree. The release dry run's tail margins default to zero, since its staged frame is now the release's own verdict. 2. long_term_capital_gains_on_collectibles, the one column above the threshold before calibration, gets the weighted donor q0.999 bound that non_sch_d_capital_gains has. Tail bounds now also apply to sparse snapped amount outputs, lowered onto the donor's snap grid so the snap cannot carry a value past them. #481 stays the root fix. The route A example no longer passes the d490 register, which was measured at final weights and would now read as stale. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Static consumer index (B3): ports #1365's index extensions and helper reviews and extends them for 2.145.3. Every helper a formula calls is reviewed at a code digest (71 reviews: 30 new and 13 re-reviewed since #1365). Six general readers cover the sites the index could not read (class attributes through get_variable, dict comprehensions, call defaults, getattr on parameter nodes, closures passed as arguments, helper results passed as arguments), and the digest follows imports made inside a helper. - Generated-variable audit (B2): refreshed to 2.145.3 and spm-calculator 1.1.0; the 120 generated variables are unchanged. - Concept mapping (C6): reviewed against 2.145.3, with take-up bindings for the four new programs; the coverage golden is regenerated. - Social Security (R4, revised): pe-us 2.145.3 migrates a stored social_security_<type> to its _reported source, so benefit levers apply (tested: the same values as storing _reported, in the baseline and under a lever reform). The adapter reads the migrated names from the installed engine and treats them as storable inputs with their default, and refuses a frame that stores both a name and its _reported input. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Federal Reserve replaced scfp2022s.zip on 2026-10-09, when it published the 2025 SCF. The file it serves now states every dollar value in 2025 dollars, and the pinned original is no longer served, so a fresh build stopped at the SCF wealth stage on the digest check (#1368). Ruled 17 Nov 2026 (option 2 of #1368): pin the republished file (zip d4e139c6..., member 6ff73d52..., downloaded from federalreserve.gov on 17 Nov) and convert on read. read_scf_2022_summary_extract identifies the file by its digest and divides the eight dollar columns Microcosm reads (liq, stocks, nmmf, bond, networth, wageinc, intdivinc, ssretinc) by the Fed's CPI-U-RS ratio 4789/4376; sentinel codes keep their value. The records and weights are the original's: the weighted shares of nonzero, positive and negative net worth equal the values recorded for the pinned original. Values equal the original only to float precision. The original 2022-dollar member is still read as it is, so no file is converted twice, and the reader records which case applied. Both SCF loaders (wealth and auto loans, whose targets come from the unchanged full file) use it. Route A's SCF input row moves to the new member. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The release decides the QRF tail gate on its base frame at pre-calibration weights, so its dry run grades the tail register on that same frame with no calibration or L0-selection shift (support fixed, zero tail-share margins). The dry-run module keeps its measured default margins (0.35, 0.05, 1.0) for other callers. The imputation schema admits the collectibles q0.999 bound. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The release now carries the base's household-location rule onto its H5 after the written file passes the stored-input premise check. The attributes are root metadata only and move no column, so the verdict holds. The diagnostics test of the release main path stubs the base-location reader, since its stub base is not an HDF5 file. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Regenerated or re-measured on 2.145.3: the pool engine contracts, the engine ABI lock, the generated spec bundle and its frozen legacy digests, the F0 coverage pins, the release input-coverage manifest (retired eCPS layers are no longer required), the primary QRF target-order digest, the year-window tripwires and the eCPS parity known-gap versions. Reform probes: the above-the-line deduction list names educator_expense_ald, and the SALT refund probe scores federal income tax (2.145.3 counts the refund in gross income; about 29 state lists now read it, both ways). Test pins follow the engine. Two engine changes shape them: - 2.145.3 backdates every parameter to 2015 before it applies reforms, so the QBI list's first breakpoint at the first reform pass is 2015-01-01. The list-edit guard still refuses an edit there; a 2017 edit now holds only inside its period. - Files built on 2.2.1 store the retired tax-unit mortgage-interest legs, which the stored-input check now refuses, and tax_unit_role_input is an engine input, so it left the register. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
docs/us-national-build-runbook.md gives each stage's commands, environment, inputs and secrets, time, memory and disk, success check and what to send back, plus the risks only a real build settles. The agent guide and the release build rule point to it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…e refresh Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The retired tax-unit first_home_mortgage_interest leg leaves the post-PUF transfer (72 to 71 targets, 53 to 52 numeric) and the primary PUF pass (two outputs and two inputs fewer). The pool fixtures, the late-producer DAG pins and the operator-ordering doc follow. The H3 post-transfer parity fixture is regenerated with its tool: its synthetic source gains the four new take-up columns, and its expected cells do not change. The national gate-scope digests move with the QRF tail gate's notes. Quote style follows ruff format in the files the re-pins edited. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
acs_local_reviewed_fill_consumers.yaml is reviewed against policyengine-us 2.2.1, and on 2.145.3 the consumer walk differs for 34 of its 59 entries. The walk tests now run only on the engine the register was reviewed against. One test checks that the ACS local release gate refuses the installed engine meanwhile, so no local-area release can use the unreviewed register. The re-review is microcosm#1675. The national release does not run this gate. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Since #1635's second round a verdict difference is recorded and printed as a warning, and the release still finishes. S3 now has the operator read the us_national comparison file after the release and report a difference, a shadow error or a missing file with the hand-off. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
vahid-ahmadi
left a comment
There was a problem hiding this comment.
Thanks for the detailed write-up. Three CI causes on 4477f5d, all from the engine move rather than flakiness, plus a note on the conflict.
engine-uk (3.13/3.14): H2 spine fixture still on core 3.34.10. test_h2_uk_spine_parity fails at packages/microcosm-graph/tests/engine/uk/test_acceptance_h_parity.py:45 (graph_from_json(uk_spine.json) == graph, differing nodes). Every node in packages/microcosm-graph/tests/fixtures/parity/uk_spine/uk_spine.json records ["policyengine-core","3.34.10"] in numerical_dependencies, and the lock now installs 3.36.1 for the UK side too. It is the only non-changelog file at head that still says 3.34.10. Regenerating the fixture with its tool should clear both UK jobs.
engine-free (3.13/3.14): ACS local packaging test still expects tax_unit_role_input in the register. test_package_records_the_stored_input_gate_bound_to_the_packaged_bytes (packages/microcosm-build/tests/engine_free/us/test_us_acs_local_release_tool.py:5597) now raises StoredInputRefusalError: stored column 'tax_unit_role_input' ... is not a variable in policyengine-us 2.2.1. f247728 removed the entry from US_STORED_NON_VARIABLE_COLUMNS, but the test's stand-in engine (_PACKAGE_ENGINE, :54-57) is still a 2.2.1 surface without that variable. The fixture still stores the column (:1300, :4091), and the expected gate lists it in registered_non_variables (:5622). One option is to give the stand-in engine tax_unit_role_input (and the 2.145.3 label) and drop it from the expectation. Whichever way it goes, the test should state which engine the ACS lane is graded against while #1675 is open.
engine-us (3.13/3.14): scenario tests pinned to 2.2.1. packages/microcosm-build/tests/engine_scenario/us/test_us_adult_care.py:11 fails with assert '2.145.3' == '2.2.1'. The scenario lane stops at the first failure, so this is only the first. At head, 15 scenario files still assert version("policyengine-us") == "2.2.1" unconditionally: adult_care, disability_benefits, educator_expenses, energy_subsidy, farm_business_income, housing_inputs, other_health_insurance, relationship_inputs, retirement_distributions, sipp_head_start, ssi_disability_criteria, ssi_take_up, voluntary_filing, wic_claim and workers_compensation. Each needs either a re-pin to 2.145.3 with its contract re-checked, like test_us_medicare_take_up.py:59, or an explicit skip if it stays 2.2.1-specific.
Conflict with main. The history is criss-cross (both sides merged #1559's head 826c5eb), so there are two merge bases. A plain recursive git merge origin/main comes out clean, with the result equal to this branch plus #1664's files. Against the single base 5499382 the only conflict is packages/microcosm-build/tests/engine_free/us/test_route_a_driver.py: main keeps the BSD stat() shim and this branch drops it for file_bytes. The branch's side is right. Note that the last CI run tested a merge with 4d287f4, before #1559 reached main, so merging main also gets a run against the current base.
Things that look consistent: the pyproject and uv.lock pins, the take-up contract constraint, the mortgage-leg retirement (_retire_ecps_reference_layers refuses it if the engine disagrees), the base-weight tail gate (export_frame is only a reweight of base_frame), the SCF deflator covering every summary dollar column the two loaders read, the location attributes written before the post-export scorer binds the sha256, and the Route A driver. Its only diff vs main after #1559 is the Linux portability, STOP_BEFORE_RELEASE, the SCF pin and the commented-out d490 register.
Review drafted with AI assistance and checked against the code at 4477f5d.
The release's target and reform materialization wraps get_branch to retain every engine branch until a batch is checked. Core 3.32 copied the parent's bound wrapper into a clone; core 3.36.1 rebinds it to the copy, so the hook looked the copy up as its own parent and stopped with a KeyError. The hook now takes the parent from the call that created or holds the branch, which works with either behavior, and refuses a wrapper it cannot trace. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Version pins move to 2.145.3. Where the engine changed, the tests follow it: - ACA PTC: a unit that takes up coverage can claim without filing for another reason, so the voluntary-filing test uses a unit that does not. The probe's reason says so, and the runbook lists its reach as a risk. - SNAP child support: California now excludes it from gross income. - SALT refund: the probe scores federal income tax; South Carolina tax no longer moves, so the smoke needs 19 baselines, not 20. - Educator expenses: the ALD list names the capped educator_expense_ald. - HUD gross rent adds the utility allowance. - The self-employed health insurance limit subtracts half of SE tax. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The lock moves the UK side to core 3.36.1, which each UK graph node records among its numerical dependencies. Regenerated with tools/graph_uk_spine_fixture.py; only the core version changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The stored-input register follows the locked engine, which defines the tax-unit role as an input (policyengine-us#9617), so the stand-in engine of the ACS local release tests defines it too. Its label stays the reviewed-fill register's engine until that register's re-review (#1675). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…efresh The only conflict is the us_national gate-scope digests in test_us_battery_bindings.py: both sides moved them. They are re-measured on the merged gates.json, which carries #1635's last edits and this branch's base-weight tail gate note. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The stand-in engine's note now says it once: the lane's tests model a release on the reviewed-fill register's engine (2.2.1), and the stored-input register follows the locked engine (2.145.3), which defines tax_unit_role_input. Review of #1676 (Vahid). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Thanks, Vahid. All four points are handled at
|
vahid-ahmadi
left a comment
There was a problem hiding this comment.
Thanks for the quick turnaround. All four earlier points are resolved at 61c8fae6a:
- The H2 fixture records core 3.36.1 on all 56 nodes.
- The ACS stand-in defines
tax_unit_role_inputand the expectation drops it. Keeping the 2.2.1 label is consistent with_the_release_runs_the_reviewed_enginereporting the register'sreviewed_against, and the note attest_us_acs_local_release_tool.py:56-61explains the hybrid. - All 15 scenario files are re-pinned.
- The merge is clean.
engine-free (3.13/3.14): one new module in the battery's binding identity. The only failure (1 failed, 9633 passed) is test_the_batterys_binding_identity_adds_only_the_leaf_and_its_imports, assert 247 == ((198 + 25) + 23).
- Computed the same way as the test (
binding_identity.describeoverTRANSPORT_GATE_REGISTRY), the set holds 247 modules at this head and 246 at mainbcb5cba9d. - The one extra is
microcosm.frame.adapters._policyengine_us_helper_reviews, added in 0f51437 and imported byframe/adapters/policyengine_us.py:35and_policyengine_us_source_index.py:19, both already in the closure. - Adding it to
BINDING_MODULES_ADDED_AFTER_BASE(packages/microcosm-build/tests/engine_free/shared/test_transport_evidence_kernels.py:137) with a comment pointing at #1676 should clear both jobs (25 → 26 entries, 247).
Voluntary-filing probe: what it now measures. With takes_up_aca_if_eligible: False (test_us_voluntary_filing.py:37), the test passes because aca_ptc drops from 11,600 to 0.
- In 2.145.3 the credit a household receives is
assigned_aca_ptc = aca_ptc * takes_up_aca_if_eligible, which feedspremium_tax_credit,spm_unit_benefitsandhealthcare_benefit_value. files_return_for_aca_ptcis true for every unit that takes up a positive credit. So neutralizingwould_file_taxes_voluntarilycannot changeassigned_aca_ptcfor any unit.- On this household it is 0 in both runs with take-up off.
- With take-up on, it is 11,600 in both runs.
- The probe (
tools/build_us_release_input_coverage_manifest.py:1447) still shows that the filing leaf binds into the graph. But its margin is the pre-take-up credit of units that don't enroll, and the reason text says it "removes the credit from otherwise eligible voluntary filers". - The engine rule matches 36B(a) and 1.6011-8(a), so this is about the probe's meaning, not a bug. It would help to say in the reason that the margin is pre-take-up
aca_ptc, or to move the probe to a measure the leaf still reaches. The runbook already lists the $100M floor as a risk (docs/us-national-build-runbook.md:208).
Branch hook (dc992cf): small test gap. The fix looks right for both clone behaviors:
- On 3.32 the wrapper's owner is recorded.
- On 3.36 it falls back to
parent, andparent_original.__func__binds correctly to the child.
The engine-free fake still clones with copy.copy (test_support/microcosm_build/us_batched_target_materialization.py:118), which is the 3.32 behavior. Neither the rebind-to-copy case nor the new RuntimeError is tested outside the engine-workflow lane. A fake clone that rebinds instance methods, plus one refusal test, would keep this from regressing silently.
Things that look consistent:
- The other five contract changes match 2.145.3 and the law:
- CA takes the 273.9(c)(17) exclusion.
- The SALT refund is in federal gross income and SC subtracts it. No other probe needs the
state_income_taxbaseline, so 19 keys. educator_expense_aldis the 62(a)(2)(D)-capped amount.- HUD gross rent includes the utility allowance (24 CFR 5.603).
- The 162(l) limit nets the attributable half of SE tax (Form 7206).
- The re-measured
us_nationalgate-scope digests pass on the mergedgates.json, whose only change against main is the tail-gate note.
engine-us was still queued at the time of this review.
Review drafted with AI assistance and checked against the code at 61c8fae.
…ntity The policyengine-us 2.145.3 frame adapter keeps the static consumer index's helper reviews in microcosm.frame.adapters._policyengine_us_helper_reviews, which the adapter imports, so the gate bindings reach one more module. The engine-free job's --maxfail=1 stopped before this test in the first CI round. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The engine-free fake can now copy a branch as core 3.36's clone does, binding copied methods to the copy, and the branch tests run under both clone behaviors. A simulation copied outside get_branch carries the wrapper without being recorded; its get_branch now refuses with a clear error (a KeyError before), and one helper serves that refusal and the parent lookup. Review of #1676 (Vahid, second round). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The probe still shows the filing leaf binds into the graph, but on 2.145.3 its margin is the pre-take-up credit (aca_ptc) of voluntary filers who do not take up coverage: the credit a household receives, assigned_aca_ptc, does not move. The probe's reason, the runbook risk and the scenario test now say so. Review of #1676 (Vahid, second round). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The engine-free job stops at its first failure, so a full local run found six more files on the 2.145.3 lock: - the engine ABI fakes now follow US_TAKE_UP_PROGRAM_COUNT (21); - the primary QRF target order holds 64 targets (the mortgage legs left); - the SALT refund probe is positive on income_tax, and the smoke needs 19 baselines; - the release's location-attribute writer is a registered HDF write site (root attributes only); - the legacy pool publication manifest re-pins its checkpoint identity (pool_h5 and agreement unchanged). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Two conflicts. The release tool keeps #1672's end of the build and writes the base's location attributes right after the written file's stored-input check, before the build record binds the H5's sha256. Certification reads those attributes back from the written H5 for its source coverage (the auto-merged line used a name only the build defines). The Route A driver tests keep both sides: Linux sizing and STOP_BEFORE_RELEASE beside the certify flow. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
#1672 split the release into a build that stops at ROUTE_A_BUILT.json and a certification (route_a.sh --certify). Step 4 now builds, a new step 5 certifies and runs both preflights, the host table names the certify stage, and section 7 states María's 18 November rulings on #1672, which a follow-up brings before this build: certification may run at a later commit than the build, and the build has no tier (certification chooses it). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
M1: the base runs locally for now. M2: the build and its certification run on a laptop with enough memory, with the PUF inputs on it. M3: staging upload on (ROUTE_A_STAGING=1). M4: #1365 closed as superseded by #1676. M5: María decides publication and promotion and coordinates with Max. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…o the engine refresh main brings #1681 (rulings 1 and 3 on #1672: a build has no tier and certification chooses it; certification may run at a descendant of the build's commit that changes only tests, docs, changelog fragments and the standing evidence owners register) and #1677 (the Modal base hand-off copies the gate shadow directory). No textual conflicts. Checked where the two sides meet in tools/build_us_fiscal_refresh_release.py: the release still writes the base's household-location attributes after the written-H5 stored-input check and before the build record binds the H5's sha256, and certification still reads them back from the written H5. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… the runbook Certification takes about two days, so the runbook now runs the build, then probes it on a 5% household sample with tools/sample_us_export_households.py and tools/probe_us_post_export.py (about 10 hours on the published export), then waits for María's assessment. The operator certifies only when she asks, at the tier she names. - Step 5 runs certification's post-export checks on the sample. It leaves out the probe's QRF tail stage, which grades at final weights while the build decides that gate at base weights; certification does not run it. - Step 6 lists what she reads (the build's verdicts, its fit, the gate shadow, the probe's failures) and the three answers: certify, build again, or certify as evidence. - Section 7 describes #1681 as merged: the build refuses --evidence-release, and a later commit certifies only when it changes tests, docs, changelog fragments or the standing owners register, so a code fix needs a new build. - S6 stops on a probe failure; S3 names the gate shadow's directory. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
After the merge of main, the release stage accepts exit 3 too (a build that failed its release gates, kept for an evidence certification), so its run_stage line names "0 $BUILT_FAILED_GATES_RC". The pin follows it; the order it checks (the release config, then the stop, then the run) is the same. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Max's review of #1681 at cfd5a2a, its four points and two of its smaller ones (the Route A points follow with the driver): 1. The certified tier refuses a failed source-coverage gate before it writes either manifest, as it refuses a failed smoke, so the build can still be certified as evidence. 2. A failed build's H5 is a --base-h5 only beside an --export-input-mass-reference-h5: without one, the export input-mass gate judges the export against its base. 3. Certification adds every gate failure it finds to certification_failures.json beside the build record, at either tier, and a build that passed its own gates and then failed certification's is no reference until a certification ships it. 4. The build writes build_incomplete.json before its H5 and removes it once its record is written, so an H5 that no record pins is no reference. A standing evidence owner pattern owns a failure line only from its start, so "input signal failed:" no longer owns every gate ending in those words. The allowed-path summaries now name the root conftest.py, LICENSE and Markdown outside package sources, and a publisher test covers version 2 staging blocks in a separately certified build. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Six open PRs merge cleanly with main and conflict with
Fifteen more edit all four files and already conflict with main: Anthony's #1156 and #1683, David's #1085 and twelve agent PRs under my account, which also wait for this one. Two more of your UK drafts merge cleanly with main and conflict with this head: #1663 in I still owe a decision on #1676's from-scratch receipt under |
The build is one command: route_a.sh dry-runs the release's gates on the fresh base as a stage of its own before the release starts (ROUTE_A_DRY_RUN=1, the default). Exit 0 or 2 lets the release start; 1, a certain failure, stops the run in minutes. A dry run holds for the release settings it checked, by a digest of the release command without its build ID, so a restart with other settings dry-runs them again. --probe probes an accepted build on a 5% household sample with certification's own post-export checks, as two supervised stages under the run directory, and stops; a failed build gets its fit and target surface from its record, since it is no reference. --certify stays a step of its own. From Max's review of #1681: - check_commit checks the certification tool and parser on every run, whatever the tier, and check_flags.py refuses a source without the named parser even when no flag is passed. - A rerun to build refuses release settings other than the accepted build's, which it would otherwise keep without a word, and --rebuild sets the accepted build and its probe aside, keeping them on disk, to build the release again on the same base. It refuses a certified build. The runbook has one command per step (resolve, build, probe, certify) and one command that collects a run's logs and records, without its data files, to send for diagnosis; the README and the settings example follow. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The UK spine graph-parity fixture conflicted. #1663 regenerated it for its new UK stage outputs, and this branch for policyengine-core 3.36.1. The merged fixture is main's, with its 56 policyengine-core entries at 3.36.1, as tools/graph_uk_spine_fixture.py writes them on this branch; nothing else in it differs from main's. No other file conflicted. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The first run stops after the quick check: STOP_BEFORE_RELEASE=1 runs the base, its preflight and the release-gate dry run, each with the gate battery shadow on (#1635), and stops before the release. Step 3 is one command that reads it with #1635's pass rules: the dry run passed (exit 0 or 2), the base's comparison is a finished run's with nothing flagged, and the dry run's records preflight and assembled with no difference, shadow error or entry of those phases unobserved. It prints QUICK CHECK CLEAN, and the operator goes straight on to the build, or what it found, and the operator sends the evidence and waits. The evidence goes to María after the build and its probe, before certification's two days; after the quick check only when it found something; and at any stop. S3 names the three shadow comparisons. Both commands were run as the runbook gives them, on dummy run trees. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The release build rule asks a pull request that changes how the dataset is built for a from-scratch build and certification receipt from its own tree before it merges. The runbook's settings now build at the full SHA María names, #1676's head, with REQUIRE_ON_MAIN=0, so the pull request stays open for fixes. Certification runs at that commit too; a later fix to code means a new build at the new head, and the pull request merges with a merge commit, so the built commit lands in main's history. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Hi @PavelMakarchuk, could you run the next US national build on your laptop, from this PR's head? It's the first on policyengine-us 2.145.3, with The run is one command per step (section 4):
If anything in section 5 happens (S1 to S6), stop, keep every file, and send us the evidence. Nothing is published at any step. Thank you! (Edited on 20 November: the build commit is now |
|
Anthony merged #1682 at 21:20Z (
Merging #1676 after a build at |
|
Lines refer to
Gaps on later or hand-run paths:
|
Five pin files conflicted, as Max listed: #1682's in-place QRF leaf array and this branch's engine refresh each moved the same pins. Each takes this branch's side, and the pins both sides moved are recomputed on the merged tree: - tools/repin_us_spec_engine_contracts.py (twice, so the inventory count is read with the new seed hashes in place) rewrote the seed map and seed protocol digests, the spec-engine loader's golden vector and the pool tool's spec_sha256; tools/spec_engine_coverage.py regenerated the F0 coverage report (50,842 of 50,842 fields, 41 of 41 inventory checks), and both --check runs pass. - APPROVED_UV_LOCK_SHA256 is the merged uv.lock's digest. The lock merged without a conflict (#1682 pins quantile-forest==1.4.2), and uv lock --check resolves it unchanged. The US bundle generator needs policyengine-us, which the engine-free environment lacks; #1666 and #1682 change none of its inputs, so the bundle stands, and CI's engine lane checks it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Max's review at d596fcb (issuecomment-7023661200) found nothing a Route A build reaches in the runbook's order, and five gaps on later or hand-run paths: 1. --probe after a failed certification passed the build's own directory as the probe's reference, which the probe refuses. A build whose certification found gates failing now gets the failed build's arguments, its fit and target surface, which the probe accepts of any build. 2. certification_failures.json named no build, and nothing removed it, so a hand-run rebuild into the same --out inherited the old attempts. Each attempt now names the build and its record's digest; only attempts on the current record count, and the next attempt drops the others. 3. The build wrote calibration_diagnostics.json before build_incomplete.json. The marker now goes down as the build creates its --out, before any file there; a dry run, which writes no --out, writes none. 4. The test of point 1 compared line numbers. It now reads the structure: each certified-tier refusal is the whole body of its tier branch, the statement before it records the failures, and the owner check follows. 5. The rerun guard compared only the release command. It also compares release-inputs.key, the digest of what the release read by path when it was launched (the base H5, the release's pinned inputs and the export input-mass reference), and the dry run's settings key carries it too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@PavelMakarchuk you can go ahead with the build at (Edited on 20 November: the build commit is now |
|
Lines refer to Before the release starts, the driver now digests Section 4 says to run each command from the Smaller points, off the runbook's path:
|
|
The red The suite's own wall time reads 6,552 seconds here, against 5,275 at I re-ran the cancelled job. |
…1585) From Max's review of bd4ff48 (issuecomment-7025833584): - The driver loads itself and its helpers from the checkout it runs in, and nothing compared that copy with COMMIT. main's route_a.sh has no STOP_BEFORE_RELEASE and no --probe, so the runbook's steps 2 and 5 need the build commit's driver. check_commit now refuses a driver whose files differ from tools/route_a at the build commit, so --resolve reports it at step 1, and the runbook says to check that commit out first. - The rerun key hashes the export input-mass reference before the release. The input check now reads it too, with no pin to match, so a reference openssl cannot read stops the run before the base, not after it. - The certification register's writer keeps what its readers count: this record's attempts and any that name no record. - A test runs the rerun guard's comparison: the command, the inputs' key, and a run from before the key existed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The test set RUN_ROOT to $(pwd)/root, so a run from the repository root wrote inputs.resolved.json there. It now passes RUN_ROOT as a setting under tmp_path. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
`local driver_differs= driver_file driver_files` declares an empty driver_differs and two more locals, which is what the driver needs, but shellcheck warns on the space after `=` (SC1007), so the engine-free shellcheck test failed. Write the empty value as ''. No change to what the driver does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@MaxGhenis @PavelMakarchuk thanks for the reviews. None of the notes since @PavelMakarchuk, please build at |
|
I read the driver and release-tool changes in All 12 checks pass at |
Moves the US engine to policyengine-us 2.145.3 (core 3.36.1, spm-calculator 1.1.0) and makes
mainready for the next US national build through Route A, with the operator runbook indocs/us-national-build-runbook.md.Base: #1559, #1635, #1664, #1672, #1677 and #1681 have landed on
main, and this branch has mergedmainat7ff5a26bc(with #1663, #1666 and #1682).Data improvements this build picks up
main. They act on ACS rows, so the county files carry them; the national pool has no ACS rows. The ACS local lane runs on 2.145.3 once ACS local lane: re-review the reviewed-fill consumer register against policyengine-us 2.145.3 #1675 re-reviews its register.block_v1household location with the F18 block ladder. The national H5 carries the base's location rule, so the county line can use it as ablock_v1donor.us/gates.json, run in shadow beside today's gates (#1585 item 11, PR 2 of 4) #1635): thegates.jsonbattery runs beside today's gates and records each difference (warn only).ssa=4loss multiplier for the SSA total.Before the build
REQUIRE_ON_MAIN=0and from a checkout of that commit, and certifies at the same commit, so the PR stays open for fixes. A fix to code after the build means a new build at the new head. The PR then merges with a merge commit, so the built commit lands inmain's history.d596fcb60andbd4ff48a6(commits 27 and 28). Later review notes that change nothing a build does when it follows the runbook go into the PR that stacks on this one for the local-area path, so the build commit isba410438e, this PR's last commit.us/gates.json, run in shadow beside today's gates (#1585 item 11, PR 2 of 4) #1635's pass rules. When it is clean, the operator goes straight on to the build; when it finds something, the evidence comes to María first.route_a.sh, about 7 to 9 hours) and its probe (route_a.sh --probe, about 10 hours, against about 48 for certification). The operator sends the run's evidence with the runbook's step 6 command, which collects the logs and records and leaves every data file on the laptop.route_a.sh --certifyonly when she asks.ROUTE_A_STAGING=1).Commits, in order
policyengine-us>=2.145.3,<3andpolicyengine-core==3.36.1. uv then resolves one core for both forks, so the UK side moves from 3.34.10 to 3.36.1 too (ruled 17 November). The worker identity pin follows the newuv.lock.stat,df -P), the README has a Linux section, andSTOP_BEFORE_RELEASE=1stops before the release so its gates can be dry-run first.rate_unsourced; everyone eligible takes up, as on 2.2.1). The ABI count moves from 17 to 21.social_security_<type>to its_reportedsource, so levers apply (tested in the baseline and under a +10% reform). The adapter treats those names as inputs; columns keep their names.first/second_home_mortgage_interestlegs are gone from the engine (pe-us#9605). The PUF chain stops producing them, and the eCPS parity gate records the retired layers.estate_income_would_be_qualified = False.populace_location_ruleonto its H5 (County Files: a proof-of-concept county-calibrated dataset by 23 November #1647).qrf_tail_concentration.json(schema 2) without failing on it. Collectibles gets a q0.999 donor bound.clonebinds a copied method to the copy, so the release's batched target and reform materialization stopped with aKeyError. The hook now takes the parent from the call that made the branch, and refuses a simulation copied outsideget_branch.mainmerged with the location attributes written before the build record binds the H5, and certification reading them back from the written H5. The runbook now builds, then certifies.mainmerged atcfd5a2a5e, with no conflicts. The location attributes are still written after the written-H5 stored-input check and before the build record binds the H5. A Route A test follows the release stage, which now also accepts a build that failed its gates (exit 3).tools/sample_us_export_households.py,tools/probe_us_post_export.py) before María's assessment (certify, build again, or certify as evidence), and certifies only when she asks. The probe leaves out its QRF tail stage, which grades at final weights while the build decides that gate at base weights. S6 stops on a probe failure.ea810f35f).--base-h5only beside an--export-input-mass-reference-h5: without one, the export input-mass gate judges the export against its base.certification_failures.jsonbeside the build record, at either tier, and a build that passed its own gates and then failed certification's is no reference until a certification ships it.build_incomplete.jsonbefore its H5 and removes it once its record is written, so an H5 that no record pins is no reference either.input signal failed:no longer owns every gate ending in those words.conftest.py,LICENSEand Markdown outside the packages' sources, and a publisher test covers version 2 staging blocks in a separately certified build.18667a600).route_a.shdry-runs the release's gates on the fresh base as a stage of its own before the release starts (ROUTE_A_DRY_RUN=1, the default). A certain failure stops the run in minutes, and a dry run holds only for the release settings it checked.route_a.sh --probeprobes an accepted build as two supervised stages under the run directory, and stops.--rebuildsets that build aside, keeping it on disk, to build the release again on the same base.mainmerged at6d32375b3(8d33275f8). Only the UK spine graph-parity fixture conflicted. It ismain's, with its 56 policyengine-core entries at 3.36.1, as this branch's generator writes them; nothing else in it differs frommain's.6983bad4e). The runbook's first run stops after the base, its preflight and the release-gate dry run, each with the gate battery shadow on. Step 3 reads them with one command, applying US gates inus/gates.json, run in shadow beside today's gates (#1585 item 11, PR 2 of 4) #1635's pass rules, and printsQUICK CHECK CLEANor what it found. The evidence then goes to María after the build and its probe, after the quick check only when it found something, and at any stop. S3 names the three shadow comparisons.d596fcb60). The runbook builds at this PR's head, pinned by its full SHA, withREQUIRE_ON_MAIN=0, as the release build rule asks of a change this size before it merges.mainmerged at7ff5a26bc(8a48bf6e2). The five pin files that Fill the QRF leaf array in place and pin quantile-forest 1.4.2 #1682's in-place QRF leaf array and the engine refresh both moved conflicted, as Max listed. Each takes this branch's side, and the pins both moved are recomputed on the merged tree:tools/repin_us_spec_engine_contracts.pyrewrote the seed digests, the loader's golden vector and the pool tool'sspec_sha256, andtools/spec_engine_coverage.pyregenerated the F0 report (both--checkpass). The worker's lock pin is the mergeduv.lock's digest.bd4ff48a6): five gaps on later or hand-run paths, none on the runbook's.certification_failures.jsonnames the build and its record's digest, so a later build into the same--outinherits none.build_incomplete.jsongoes down as the build creates its--out, before any file there, its diagnostics included.bd4ff48a6(360357c58).main's has noSTOP_BEFORE_RELEASEand no--probe. The commit check now refuses a driver whose files differ fromtools/route_a/at the build commit, and the runbook says to check that commit out first.1382d2d10): the export reference test writes under its own temporary directory.ba410438e): the driver's self-check writes its empty value as'', as shellcheck asks; nothing the driver does changes.What changes in outputs
tenant_pays_utilitiesandliving_arrangements_allow_for_food_preparation(now True); federal AGI now includes state tax refunds, estate income and taxable disability benefits.Tests
Touched tests ran locally in an engine-free environment and in a 2.145.3 environment. The engine-free and US engine jobs stop at a process's first failure, so the whole engine-free list and every US scenario and workflow module also ran locally, and the UK H2 parity test ran on core 3.36.1. The full suite runs in CI.
After
mainwas merged atcfd5a2a5e, the 44 engine-free test files that reach the release tool, Route A, the probe, the certify tool, the preflights or the publisher, or that read the changed docs, ran locally: 3,184 tests. One Route A test failed on the release stage's new text; it is fixed in5c37a801c, and its file passes (118 tests).tools/ci_test_plan.py verifyis ok. The engine jobs run in CI.For commits 21 to 24, the engine-free test files they touch, or that read the changed docs, ran locally. Before the merge, the release tool's builder file (465 tests) ran first. Then 1,058 tests ran in two runs, covering Route A, the probe, its design, the release-gate dry run and preflight, the export tool's source, the spec bundle, the CI test plan, the logbook, the CI integration job, the publisher guard and the release contract. One Route A test failed: it pins the one place that removes
ROUTE_A_BUILT.json, and--rebuildnow sets that file aside instead. It is fixed in commit 22. After the merge with6d32375b3, none failed: 930 tests across Route A, its ASEC pool, the Modal stage plans, the CI test plan and the graph acceptance files, and the builder file's 465.tools/ci_test_plan.py verifyis ok. The UK spine parity test needs the UK engine, and shellcheck is not installed locally, so CI runs both. Commit 25 changes only the runbook.After the merge with
7ff5a26bc, 4,182 engine-free tests ran locally, none failing: the spec-engine loader, the US stacked spine, spine blindness and pool H5 files, microcosm-fit's and microcosm-frame's engine-free suites, the graph executor and parity pins, Route A and the release tool's builder file.tools/ci_test_plan.py verifyis ok. The re-pinned engine-contract and engine-workflow tests and the US bundle check need the US engine, so CI runs them.For commit 27, 805 engine-free tests ran locally, none failing: Route A, the probe and its design, the release-gate preflight and dry run, and the release tool's builder file.
tools/ci_test_plan.py verifyis ok.For commits 28 and 29, the Route A driver file (146 tests) and the release tool's certification tests (60) ran locally, none failing, and
tools/ci_test_plan.py verifyis ok. For commit 30, the driver file ran again atba410438e, none failing; its shellcheck test needs shellcheck, so CI runs it.Follow-ups (not in this PR)
weeks_workedis an input on 2.145.3 (policyengine-us#9660 Part A1). The pool still leaves it out; carrying WKSWORK weeks changes pool outputs, so it is its own change._reportedis possible later.unemployment_compensation_monthsis a new unemployment-insurance consumer ofweeks_unemployedon 2.145.3.qrf_tail_concentration.json, whose verdict is at base weights since 17 November. The runbook leaves the stage out; moving it to base weights is its own change.Not settled here
Only a real build settles the risks listed in the runbook's section 6.
🤖 Generated with Claude Code