Skip to content

Update requery logic #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michael-paystack merged 1 commit into from
Nov 3, 2026
Merged

Update requery logic #166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions paystack/src/main/java/co/paystack/android/TransactionManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,7 @@ public void onSuccess(TransactionInitResponse data) {
card.getLast4digits(),
deviceId,
data.getReference(),
data.getAccessCode(),
null
);
processCharge(params);
Expand Down
2 changes: 1 addition & 1 deletion paystack/src/main/java/co/paystack/android/api/PaystackRepositoryImpl.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ internal class PaystackRepositoryImpl(private val apiService: PaystackApiService

override fun requeryTransaction(chargeParams: ChargeParams, callback: ChargeApiCallback) {
makeApiRequest(
apiCall = { apiService.requeryTransaction(chargeParams.transactionId) },
apiCall = { apiService.requeryTransaction(chargeParams.accessCode) },
onSuccess = { data -> callback.onSuccess(chargeParams, data) },
onError = { throwable -> callback.onError(throwable, chargeParams.reference) },
)
Expand Down
5 changes: 4 additions & 1 deletion paystack/src/main/java/co/paystack/android/api/model/TransactionInitResponse.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,8 @@ data class TransactionInitResponse(
val transactionId: String,

@Json(name = "reference")
val reference: String?
val reference: String?,

@Json(name = "access_code")
val accessCode: String
)
1 change: 1 addition & 0 deletions paystack/src/main/java/co/paystack/android/api/request/ChargeParams.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ data class ChargeParams(
val last4: String,
val deviceId: String,
val reference: String?,
val accessCode: String,
val handle: String? = null
) {
fun toRequestMap() = mapOf(
Expand Down
4 changes: 2 additions & 2 deletions paystack/src/main/java/co/paystack/android/api/service/PaystackApiService.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ internal interface PaystackApiService {
fun validateAddress(@FieldMap fields: Map<String, String>): Call<ChargeResponse>

@NoWrap
@GET("/checkout/requery/{transactionId}")
fun requeryTransaction(@Path("transactionId") transactionId: String): Call<ChargeResponse>
@GET("/checkout/requery/{accessCode}")
fun requeryTransaction(@Path("accessCode") accessCode: String): Call<ChargeResponse>

}
2 changes: 1 addition & 1 deletion paystack/src/test/java/co/paystack/android/TransactionManagerTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ class TransactionManagerTest {
whenever(paystackRepository.initializeTransaction(anyString(), any(), anyString(), any()))
.thenAnswer {
val callback = it.arguments[3] as ApiCallback<TransactionInitResponse>
callback.onSuccess(TransactionInitResponse("success", "trans_id"))
callback.onSuccess(TransactionInitResponse("success", "trans_id", "access_code"))
}

val transactionManager = TransactionManager(paystackRepository)
Expand Down
5 changes: 3 additions & 2 deletions paystack/src/test/java/co/paystack/android/api/PaystackRepositoryImplTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ class PaystackRepositoryImplTest {
@Test
fun `initializeTransaction calls PaystackApiService with correct params`() {
whenever(apiService.initializeTransaction(anyMap()))
.thenReturn(FakeCall.success(TransactionInitResponse("success", "trans_id")))
.thenReturn(FakeCall.success(TransactionInitResponse("success", "trans_id", "access_code")))
val repository = PaystackRepositoryImpl(apiService)
val apiCallback = mock<ApiCallback<TransactionInitResponse>>()
val testMetadata = "internal_tag" to "tag_internal_example"
Expand Down Expand Up @@ -82,7 +82,8 @@ class PaystackRepositoryImplTest {
transactionId = testTransactionId,
last4 = "5599",
deviceId = testDeviceId,
null
null,
accessCode = "test_access_code"
)

val TEST_CHARGE_RESPONSE = ChargeResponse(
Expand Down
Loading