Skip to content

Support Talisman Aspect effect enchantments - #10423

Open
mcagnion wants to merge 2 commits into
PathOfBuildingCommunity:devfrom
mcagnion:bugfix/talisman-aspect-effects
Open

mcagnion wants to merge 2 commits into
PathOfBuildingCommunity:devfrom
mcagnion:bugfix/talisman-aspect-effects

Conversation

@mcagnion

@mcagnion mcagnion commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Description of the problem being solved:

The Aspect effect enchantments on Craicic, Farric and Fenumal Talismans are not recognised, so equipping these bases leaves the corresponding effects unchanged.

Recognise these enchantments and apply their effect modifiers to the corresponding Aspect.

The supported enchantment lines are:

  • Craicic Talisman: 100% increased Aspect of the Crab Buff Effect.
  • Farric Talisman: 100% increased Aspect of the Cat Buff Effect.
  • Fenumal Talisman: 100% increased Aspect of the Spider Debuff Effect.

Steps taken to verify a working solution:

  • Added regression coverage using the actual Talisman bases and their granted Aspects. The effect assertions fail on the unchanged base and pass with this change.
  • Checked Cat's Stealth and Agility independently and together, Crab barrier counts and maximum, Spider's Web stacks, inactive or absent Aspects, and unrelated buffs.

Before and after screenshots:

All three public exports already equip the shown Talisman. Each pair uses identical inputs. Item tooltips show line recognition and stat differences when removing the whole amulet; the breakdowns isolate the Aspect contribution.

Aspect of the Crab

Thisisabadidea__: enable the existing level-30 Aspect and disable Wrath to free reservation. At 12 Crab Barriers, physical damage reduction increases from 28% to 52%; the Aspect contribution changes from +24 to +48.

Before After
crab-item-before crab-item-after
Before: calculation After: calculation
crab-breakdown-before crab-breakdown-after

Aspect of the Cat

TorntUp: retain the original level-30 Aspect and Cat's Agility. Aspect of the Cat contributes 16% → 32% increased attack speed to Static Strike of Gathering Lightning.

Before After
cat-item-before cat-item-after

Before: calculation

cat-breakdown-before

After: calculation

cat-breakdown-after

Aspect of the Spider

onestepblack: retain the original Shield Crush (1 Wave), active level-20 Aspect and three webs. Shield Crush hit DPS increases from 4,273,454.6 to 4,721,719.1; the breakdown isolates the Aspect's 15% → 30% increased damage taken.

Before: Shield Crush After: Shield Crush
spider-stats-before spider-stats-after
Before: item After: item
spider-item-before spider-item-after
Before After
spider-breakdown-before spider-breakdown-after

Risks/notes

The full test suite still fails the existing "only offers attainable modifiers on That Which Was Taken" case in TestRareLike_spec.lua (nil instead of 48). The same failure was reproduced on the unchanged base with the same runtime.

Scope Cat and Crab buff effect and Spider debuff effect to their skills so
the base enchantments affect calculations. Cover equipped Talismans,
conditional buffs, unchanged stacks and unrelated buffs.
Keep scoped parsing and one calculation per Aspect. Drop repeated checks of
existing modes, stacks and unrelated skills to keep the tests proportional
to the parser fix.
@mcagnion
mcagnion marked this pull request as ready for review November 10, 2026 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant