Repository navigation
Conversation
Scope Cat and Crab buff effect and Spider debuff effect to their skills so the base enchantments affect calculations. Cover equipped Talismans, conditional buffs, unchanged stacks and unrelated buffs.
Keep scoped parsing and one calculation per Aspect. Drop repeated checks of existing modes, stacks and unrelated skills to keep the tests proportional to the parser fix.
mcagnion
marked this pull request as ready for review
November 10, 2026 00:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
The Aspect effect enchantments on Craicic, Farric and Fenumal Talismans are not recognised, so equipping these bases leaves the corresponding effects unchanged.
Recognise these enchantments and apply their effect modifiers to the corresponding Aspect.
The supported enchantment lines are:
100% increased Aspect of the Crab Buff Effect.100% increased Aspect of the Cat Buff Effect.100% increased Aspect of the Spider Debuff Effect.Steps taken to verify a working solution:
Before and after screenshots:
All three public exports already equip the shown Talisman. Each pair uses identical inputs. Item tooltips show line recognition and stat differences when removing the whole amulet; the breakdowns isolate the Aspect contribution.
Aspect of the Crab
Thisisabadidea__: enable the existing level-30 Aspect and disable Wrath to free reservation. At 12 Crab Barriers, physical damage reduction increases from 28% to 52%; the Aspect contribution changes from +24 to +48.
Aspect of the Cat
TorntUp: retain the original level-30 Aspect and Cat's Agility. Aspect of the Cat contributes 16% → 32% increased attack speed to Static Strike of Gathering Lightning.
Before: calculation
After: calculation
Aspect of the Spider
onestepblack: retain the original Shield Crush (1 Wave), active level-20 Aspect and three webs. Shield Crush hit DPS increases from 4,273,454.6 to 4,721,719.1; the breakdown isolates the Aspect's 15% → 30% increased damage taken.
Risks/notes
The full test suite still fails the existing "only offers attainable modifiers on That Which Was Taken" case in
TestRareLike_spec.lua(nilinstead of48). The same failure was reproduced on the unchanged base with the same runtime.