Skip to content

More mappings for 1.13 snapshots - #213

Merged
SpaceWalkerRS merged 31 commits into
OrnitheMC:gen2from
danilwhale:continuing-1.13
Nov 9, 2026
Merged

SpaceWalkerRS merged 31 commits into
OrnitheMC:gen2from
danilwhale:continuing-1.13

Conversation

@danilwhale

Copy link
Copy Markdown
Contributor

No description provided.

@SpaceWalkerRS SpaceWalkerRS left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I got about halfway through the changes, I'll do the rest tomorrow

Comment thread mappings/1.13#18w30a.tinydiff Resolved
Comment thread mappings/1.13-pre2#1.13-pre3.tinydiff Resolved
Comment thread mappings/1.13-pre5#1.13-pre6.tinydiff Resolved
Comment thread mappings/1.13.2#18w43a.tinydiff Resolved
p 1 p_1
p 2 p_2
c net/minecraft/unmapped/C_66796240$C_53134182$53458528 53458528
c net/minecraft/unmapped/C_66796240$C_53134182$53458528 53458528

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what on earth happened here, I guess it doesn't break anything but it's weird this extra tab got inserted

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enigma weirdly inserted atComparator locally, so I pasted original values through text editor and probably caught that when selecting

Comment thread mappings/17w46a#17w47a.tinydiff Resolved
Comment thread mappings/17w46a#17w47a.tinydiff Resolved
p 1 state
p 2 ctx
m (Lnet/minecraft/unmapped/C_15815210;Lnet/minecraft/unmapped/C_46108969;Lnet/minecraft/unmapped/C_32594356;Lnet/minecraft/unmapped/C_28786548;)Z m_95670435 shouldNotRender
m (Lnet/minecraft/unmapped/C_15815210;Lnet/minecraft/unmapped/C_46108969;Lnet/minecraft/unmapped/C_32594356;Lnet/minecraft/unmapped/C_28786548;)Z m_95670435 shouldRenderFace

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is suspicious, I suppose the function of the method got inverted?

@danilwhale danilwhale Jul 13, 2026 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why was it even called this way, it has same behavior as Block#shouldRenderFace in version prior. that is, deciding whether the face should be rendered. perhaps, changed behavior in later versions?

Comment thread mappings/17w46a#17w47a.tinydiff Resolved
Comment thread mappings/17w46a#17w47a.tinydiff Resolved
Comment thread mappings/18w16a#18w19a.tinydiff Resolved
Comment thread mappings/18w14b#18w15a.tinydiff Resolved
Comment thread mappings/1.13-pre4#1.13-pre5.tinydiff Resolved
@SpaceWalkerRS
SpaceWalkerRS marked this pull request as ready for review November 9, 2026 20:20
@SpaceWalkerRS
SpaceWalkerRS merged commit b994ee8 into OrnitheMC:gen2 Nov 9, 2026
45 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants