Repository navigation
Conversation
The output-budget example called estimate_output_shape() and estimate_memory() on an unfitted Preprocessor, which raises NotFittedError, and the page advised running them before a fit that overflow_policy="error" would reject. Both are fitted methods: the output width is only known after fit. The example now fits first, and the page explains how to size a large dataset up front: fit on a sample (the row count is read from the data passed to the estimate), or fit with overflow_policy="warn".
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The output-budget example in
docs/core_concepts/outputs_and_inspection.mdcalledestimate_output_shape()/estimate_memory()on an unfittedPreprocessor, which raisesNotFittedError, and the page advised running them before a fit thatoverflow_policy="error"would reject. Both are fitted methods.The example now fits first, and the page explains how to size a large dataset up front: fit on a sample (the row count is read from the data passed to the estimate) or fit with
overflow_policy="warn". The new snippets were executed as written. Docs-only change.Validation
Checks: full suite (2544 passed, 59 skipped, 7 xfailed, coverage >= 94.79%),
ruff format/ruff check, pyright (no new diagnostics), docs build with-W,scripts/quickstart.py. Merges cleanly withmainand with #136.