Skip to content

test(transformers): run check_estimator on the Fourier and kernel maps - #143

Open
xillig wants to merge 1 commit into
OpenTabular:mainfrom
xillig:test/sklearn-compat-fourier-kernel
Open

xillig wants to merge 1 commit into
OpenTabular:mainfrom
xillig:test/sklearn-compat-fourier-kernel

Conversation

@xillig

@xillig xillig commented Nov 11, 2026

Copy link
Copy Markdown

Summary

FourierFeatureTransformer, RandomFourierFeaturesTransformer and NystroemFeaturesTransformer were in neither tier of tests/transformers/test_sklearn_compat.py, so nothing guarded their estimator contract.

All three pass every check_estimator check, so they join the near-conformant tier without tolerated failures: a regression in any check now fails the suite. Test-only change.

Also verified on the minimum-dependency set of the CI job (Python 3.10, numpy 1.24.4, pandas 2.0.3, scipy 1.10.1, scikit-learn 1.6.0).

Validation

Checks: full suite (2547 passed, 59 skipped, 7 xfailed, coverage >= 94.79%), ruff format / ruff check, pyright (no new diagnostics), docs build with -W, scripts/quickstart.py. Merges cleanly with main and with #136.

FourierFeatureTransformer, RandomFourierFeaturesTransformer and
NystroemFeaturesTransformer were in neither tier of the scikit-learn
conformance suite, so nothing guarded their estimator contract.

All three pass every check_estimator check, on the locked dependencies
and on the minimum supported ones (Python 3.10, scikit-learn 1.6.0), so
they join the near-conformant tier without tolerated failures: a future
regression in any check now fails the suite.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant