Repository navigation
Conversation
mark_stale() flags the current fitted state as outdated. Fitting the same object again replaced that state, but lifecycle_state_ kept reporting STALE with the old reason, so a freshly fitted preprocessor looked unusable. A successful fit now removes the mark and the state returns to FITTED. A fit that raises leaves the mark in place. The attribute is removed rather than reset, so the spec and fingerprint of a never-stale preprocessor are unchanged.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
mark_stale()flags the current fitted state as outdated. Fitting the same object again replaced that state, butlifecycle_state_kept reportingSTALEwith the old reason.Fix
A successful
fitremoves the mark; afitthat raises keeps it. The attribute is removed rather than reset toNone, soto_spec()andfingerprint_of a never-stale preprocessor are unchanged.FROZENhandling is untouched.Tests and docs
Five tests in
tests/integration/test_frozen_lifecycle.py(fit, fit_transform, failed fit, unchanged spec / fingerprint, spec round trip); themark_staledocstring andreproducibility.mdare updated.Validation
Checks: full suite (2549 passed, 59 skipped, 7 xfailed, coverage >= 94.79%),
ruff format/ruff check, pyright (no new diagnostics), docs build with-W,scripts/quickstart.py. Merges cleanly withmainand with #136.