Skip to content

docs: fix the MPS tip and the outdated version pins - #626

Merged
mkumar73 merged 3 commits into
OpenTabular:mainfrom
jorisstrakeljahn:docs/mps-tip-and-version-pins
Nov 13, 2026
Merged

mkumar73 merged 3 commits into
OpenTabular:mainfrom
jorisstrakeljahn:docs/mps-tip-and-version-pins

Conversation

@jorisstrakeljahn

Copy link
Copy Markdown
Contributor

The MPS tip in comparison_tables.md says to set accelerator="mps" in TrainerConfig. But TrainerConfig has no such field, so following the tip raises a TypeError. With this PR the tip says to pass it to fit(), which is also what config_system.md says about Lightning trainer arguments.

Also three pages still show deeptab==2.0.0 as the exact pin for experimental models, so copying it installs 2.0.0 instead of the current 2.1.0. The experimental notebook even still shows 1.8.0 and the ranges for 1.x. So I changed the pins to 2.1.0 and the notebook ranges to the ones in experimental.md. I did not re-run the notebook, so one saved cell output still prints deeptab==1.8.0.

There are two commits, one for each fix.
just docs and just check pass.

Also I kept the style of these pages, which use a real version number, but I can switch them to x.y.z if you prefer that, because then they don't have to be updated with every new version.

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@mkumar73 mkumar73 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jorisstrakeljahn , thank you for your contribution.

  • Changes looks good, CI test passes.
  • PR will be merged to main.

@mkumar73
mkumar73 merged commit f776187 into OpenTabular:main Nov 13, 2026
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants