Repository navigation
docs: fix the MPS tip and the outdated version pins - #626
Merged
mkumar73 merged 3 commits intoNov 13, 2026
Merged
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
mkumar73
approved these changes
Nov 13, 2026
mkumar73
left a comment
Collaborator
There was a problem hiding this comment.
@jorisstrakeljahn , thank you for your contribution.
- Changes looks good, CI test passes.
- PR will be merged to main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MPS tip in
comparison_tables.mdsays to setaccelerator="mps"inTrainerConfig. But TrainerConfig has no such field, so following the tip raises a TypeError. With this PR the tip says to pass it tofit(), which is also whatconfig_system.mdsays about Lightning trainer arguments.Also three pages still show
deeptab==2.0.0as the exact pin for experimental models, so copying it installs 2.0.0 instead of the current 2.1.0. The experimental notebook even still shows 1.8.0 and the ranges for 1.x. So I changed the pins to 2.1.0 and the notebook ranges to the ones inexperimental.md. I did not re-run the notebook, so one saved cell output still printsdeeptab==1.8.0.There are two commits, one for each fix.
just docsandjust checkpass.Also I kept the style of these pages, which use a real version number, but I can switch them to x.y.z if you prefer that, because then they don't have to be updated with every new version.