Skip to content

feat(compat): require mlflow>=3.9 for SQLAlchemy 2.1 - #625

Merged
mkumar73 merged 1 commit into
OpenTabular:mainfrom
jorisstrakeljahn:fix/mlflow-sqlalchemy-2-1
Nov 13, 2026
Merged

mkumar73 merged 1 commit into
OpenTabular:mainfrom
jorisstrakeljahn:fix/mlflow-sqlalchemy-2-1

Conversation

@jorisstrakeljahn

Copy link
Copy Markdown
Contributor

With SQLAlchemy 2.1 and MLflow tracking turned on, fit() crashes when mlflow is older than 3.9, see #624. This PR raises the lower bound in the mlflow, tracking and all extras to mlflow>=3.9, the first version with the fix.

I added one test and extended another.
The new test checks that the three extras allow 3.9.0 and not 3.8.1. test_declared_dependency_profile now also builds a real MLflow logger when mlflow is installed. The TensorBoard case of that test already writes a real event file in the same way. That part only runs when pytest gets --dependency-profile=extras or tabr. just test does not pass that option, so it only runs in CI.

In poetry.lock only the content hash changes, because the locked mlflow 3.17.1 already satisfies the new bound. poetry check --lock passes.

The installation page now states the new minimum, next to the TensorBoard one. docs/developer_guide/versioning.md asks for a feat(compat) commit when a dependency minimum goes up, so I used that type.

just test: 3358 passed. just docs and just check pass.

Fixes #624

@mkumar73 mkumar73 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jorisstrakeljahn - thank you for your contribution

  • changes looks fine, PR will be merged once the CI, and test pass.

@codecov-commenter

Copy link
Copy Markdown

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment

Thanks for integrating Codecov - We've got you covered ☂️

@mkumar73
mkumar73 merged commit e35300e into OpenTabular:main Nov 13, 2026
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] MLflow tracking crashes with SQLAlchemy 2.1 when mlflow is older than 3.9

3 participants