Repository navigation
feat(compat): require mlflow>=3.9 for SQLAlchemy 2.1 - #625
Merged
mkumar73 merged 1 commit intoNov 13, 2026
Merged
Conversation
mkumar73
self-requested a review
November 12, 2026 23:01
mkumar73
approved these changes
Nov 12, 2026
mkumar73
left a comment
Collaborator
There was a problem hiding this comment.
@jorisstrakeljahn - thank you for your contribution
- changes looks fine, PR will be merged once the CI, and test pass.
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With SQLAlchemy 2.1 and MLflow tracking turned on,
fit()crashes when mlflow is older than 3.9, see #624. This PR raises the lower bound in the mlflow, tracking and all extras to mlflow>=3.9, the first version with the fix.I added one test and extended another.
The new test checks that the three extras allow 3.9.0 and not 3.8.1.
test_declared_dependency_profilenow also builds a real MLflow logger when mlflow is installed. The TensorBoard case of that test already writes a real event file in the same way. That part only runs when pytest gets--dependency-profile=extrasortabr.just testdoes not pass that option, so it only runs in CI.In
poetry.lockonly the content hash changes, because the locked mlflow 3.17.1 already satisfies the new bound.poetry check --lockpasses.The installation page now states the new minimum, next to the TensorBoard one.
docs/developer_guide/versioning.mdasks for afeat(compat)commit when a dependency minimum goes up, so I used that type.just test: 3358 passed.just docsandjust checkpass.Fixes #624