Repository navigation
fix(models): reject unnamed validation features before replacing fitt… - #623
Merged
mkumar73 merged 2 commits intoNov 14, 2026
Merged
Conversation
…ed state fit(X=<named DataFrame>, X_val=<ndarray or list>) passed the preflight column check, which only compared names when both inputs carried columns, and then failed inside the fitted preprocessor's ColumnTransformer with 'NoneType' object is not iterable after the model had already been rebuilt, invalidating a previously fitted estimator. The check now compares the coerced validation columns against the training columns whenever the training frame carries string names, so unnamed validation input raises the same ColumnNameError as a positionally labelled frame before any state changes.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ed state
fit(X=, X_val=) passed the preflight column check, which only compared names when both inputs carried columns, and then failed inside the fitted preprocessor's ColumnTransformer with 'NoneType' object is not iterable after the model had already been rebuilt, invalidating a previously fitted estimator. The check now compares the coerced validation columns against the training columns whenever the training frame carries string names, so unnamed validation input raises the same ColumnNameError as a positionally labelled frame before any state changes.