Skip to content

fix(models): reject unnamed validation features before replacing fitt… - #623

Merged
mkumar73 merged 2 commits into
OpenTabular:mainfrom
xillig:fix/unnamed-validation-features
Nov 14, 2026
Merged

mkumar73 merged 2 commits into
OpenTabular:mainfrom
xillig:fix/unnamed-validation-features

Conversation

@xillig

@xillig xillig commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

…ed state

fit(X=, X_val=) passed the preflight column check, which only compared names when both inputs carried columns, and then failed inside the fitted preprocessor's ColumnTransformer with 'NoneType' object is not iterable after the model had already been rebuilt, invalidating a previously fitted estimator. The check now compares the coerced validation columns against the training columns whenever the training frame carries string names, so unnamed validation input raises the same ColumnNameError as a positionally labelled frame before any state changes.

xillig and others added 2 commits November 10, 2026 19:42
…ed state

fit(X=<named DataFrame>, X_val=<ndarray or list>) passed the preflight column check, which only compared names when both inputs carried columns, and then failed inside the fitted preprocessor's ColumnTransformer with 'NoneType' object is not iterable after the model had already been rebuilt, invalidating a previously fitted estimator. The check now compares the coerced validation columns against the training columns whenever the training frame carries string names, so unnamed validation input raises the same ColumnNameError as a positionally labelled frame before any state changes.

@mkumar73 mkumar73 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xillig

  • The fix correctly rejects unnamed validation input before replacing fitted state, with regression coverage.
  • Looks good to merge once CI and Docs pass.
  • PR approved.

Thank you for your contribution :)

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@mkumar73
mkumar73 merged commit 4d30b22 into OpenTabular:main Nov 14, 2026
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants