Skip to content

fix(architectures): run Trompt on tables without numerical features - #622

Merged
mkumar73 merged 2 commits into
OpenTabular:mainfrom
xillig:fix/trompt-categorical-only
Nov 14, 2026
Merged

mkumar73 merged 2 commits into
OpenTabular:mainfrom
xillig:fix/trompt-categorical-only

Conversation

@xillig

@xillig xillig commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

Trompt read the batch size from the first numerical tensor, so a categorical-only (or embedding-only) table failed with IndexError in the first forward pass. The prompt records are now sized from the first tensor of whichever feature group is present.

xillig and others added 2 commits November 10, 2026 17:37
Trompt read the batch size from the first numerical tensor, so a categorical-only (or embedding-only) table failed with IndexError in the first forward pass. The prompt records are now sized from the first tensor of whichever feature group is present.
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@mkumar73 mkumar73 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xillig

  • fix correctly handles missing numerical features, with regression coverage for categorical-only and embedding-only inputs.
  • All checks pass

Thank you for your contribution!

@mkumar73
mkumar73 merged commit eb15b6b into OpenTabular:main Nov 14, 2026
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants