You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
feat: add GET /1/account and deprecate GET /1/users/self - #379
GET /1/account returns the current user's account information as a plain object (no legacy { message, data } wrapper). It lives on the account controller and, unlike the rest of it, also accepts API tokens so token clients can migrate off /1/users/self.
/1/users/self keeps working with its legacy wrapper and is marked obsolete, which shows as deprecated in the OpenAPI document.
Summary by CodeRabbit
New Features
Added authenticated GET /1/account for retrieving the current user’s ID, name, email, image, roles, and password status. It supports session and API-token authentication.
Changes
The existing GET /1/users/self endpoint is deprecated, with callers directed to GET /1/account. It remains available with the legacy rank field for compatibility.
GET /1/account returns the current user's account information as a plain
object (no legacy { message, data } wrapper). It lives on the account
controller and, unlike the rest of it, also accepts API tokens so token
clients can migrate off /1/users/self.
/1/users/self keeps working with its legacy wrapper and is marked
obsolete, which shows as deprecated in the OpenAPI document.
No actionable comments were generated in the recent review.
Walkthrough
The API adds authenticated GET /1/account with a new response model. The legacy user endpoint now uses a separate legacy response model and is marked obsolete. Integration tests cover session and API-token authentication, response fields, and unauthorized access.
Changes: Account endpoint
Layer / File(s)
Summary
Account response models and endpoints API/Models/Response/UserSelfResponse.cs, API/Controller/Account/Authenticated/GetSelf.cs, API/Models/Response/LegacyUserSelfResponse.cs, API/Controller/Users/GetSelf.cs
Adds the response model and authenticated GET /1/account endpoint. The legacy endpoint now returns LegacyUserSelfResponse and is marked obsolete with guidance to use /1/account.
This change adds a new account endpoint and marks the legacy user endpoint as deprecated, leaving the legacy response unchanged. No actionable merge-blocking risk was identified.
Pre-merge checks: 4
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title names the two main changes: the new GET /1/account endpoint and the deprecation of GET /1/users/self. The summaries confirm both: a new authenticated account controller and response models, …
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title names the two main changes: the new GET /1/account endpoint and the deprecation of GET /1/users/self. The summaries confirm both: a new authenticated account controller and response models, and the legacy GetSelf marked obsolete with a pointer to /1/account. The title is specific and matches the primary change, so it passes.
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
File: No configuration file from this repository applied
Commit: Unavailable
Layers: defaults
Review profile: CHILL
Plan: Advanced
Run ID: e6ed1568-f21d-4606-8d5c-d1ef4aee33b5
Commits
Reviewing files that changed from the base of the PR and between 5da14a0 and 10b466f.
Files selected for processing: 4
API/Controller/Account/Authenticated/GetSelf.cs
API/Controller/Users/GetSelf.cs
API/Models/Response/LegacyUserSelfResponse.cs
API/Models/Response/UserSelfResponse.cs
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GET /1/account returns the current user's account information as a plain object (no legacy { message, data } wrapper). It lives on the account controller and, unlike the rest of it, also accepts API tokens so token clients can migrate off /1/users/self.
/1/users/self keeps working with its legacy wrapper and is marked obsolete, which shows as deprecated in the OpenAPI document.
Summary by CodeRabbit
GET /1/accountfor retrieving the current user’s ID, name, email, image, roles, and password status. It supports session and API-token authentication.GET /1/users/selfendpoint is deprecated, with callers directed toGET /1/account. It remains available with the legacyrankfield for compatibility.