Skip to content

AWB import: route branch points through junction nodes - #339

Merged
danyill merged 1 commit into
mainfrom
fix/awb-import-junction-nodes
Nov 19, 2026
Merged

danyill merged 1 commit into
mainfrom
fix/awb-import-junction-nodes

Conversation

@danyill

@danyill danyill commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

Fixes #338.

AWB lets several connections leave a block or the start, and several arrive at a block or the end, with no node. RAPTOR only splits and joins at a node. The import now inserts an ordinary node with k = 1 at each such point. That keeps the meaning of a plain AWB junction: any one path through.

Why it matters. This is not only about the warnings. The engine computes the wrong answer for the model as it was imported:

OilAndGasExample.awb, 500 runs Availability System failures per run
Before 99.989 % 0.39
After 97.34 % 9.7

Block 1.5 is on every path and has an availability of 8760 / (8760 + 240) = 97.33 %. The system cannot be more available than that, so the 'before' figure is impossible.

AWB's own results for this example are not in the file: its availability profile is 1.0 throughout. The check is therefore this bound, not a comparison with AWB. Reading the plain AWB junction as 1-of-n is my interpretation. Every block in the example has LogicMode 0, the default, and no node in the file has a vote count.

AWB examples (link and connection warnings, before and after):

Example Before After
OilAndGasExample 7 0
Example1 2 0
MaximoDemo 2 0
SapDemo 2 0

ALTExample has no RBD diagram in the file, so it is unchanged.

Tests. test_awb_branches_without_nodes_get_junction_nodes builds two blocks in parallel with no node, the way AWB draws them. It fails without the fix and passes with it.

AWB draws parallel paths with no node: several connections leave a block
or the start, several arrive at a block or the end. The import copied
them as they were, but RAPTOR splits and joins only at a node, so the GUI
flagged every such model and the engine's answer was wrong:
OilAndGasExample came out 99.989 % available although block 1.5, at
8760 / (8760 + 240) = 97.33 %, is on every path. Each such point now gets
an ordinary 1-of-n node, the meaning of a plain AWB junction (any one path
through); the same model gives 97.34 %. Example1, MaximoDemo and SapDemo
also lose their link warnings.
@danyill
danyill merged commit e1f4841 into main Nov 19, 2026
24 checks passed
@danyill
danyill deleted the fix/awb-import-junction-nodes branch November 19, 2026 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AWB import: branches without nodes give link warnings and wrong results

1 participant