Repository navigation
Pass -s=ida for --daeMode models - #420
Merged
Merged
Conversation
OpenModelica #17977 makes -s=auto the default solver method, and the runtimes no longer replace an explicit method. A model compiled with --daeMode and simulated with a method other than ida now stops with: The model was compiled with --daeMode, which works only with -s=ida or -s=auto. Before, the runtimes used IDA without an error. The testing gives an explicit method in two cases: the s of the __OpenModelica_simulationFlags annotation (s = "dassl" in Dynawo.Examples.SVarC), and the cvode and gbode solvers of the solvers job. These runs all fail on master now. Find --daeMode in the custom commands of the library and the job, and in the __OpenModelica_commandLineOptions annotation of the model, as omc reads it: case-insensitive, with =false, and the last value wins. For such a model, ignore the s of the annotation and put -s=ida last in the simulation flags of every run. The runs then use IDA, as before #17977, so the cvode and gbode tables keep IDA results for these models. The wasm FMU runners now use the same test. The old test did not find --daemode, which one Dynawo model uses. Assisted-by: Claude Opus 5.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenModelica #17977 makes -s=auto the default solver method, and the runtimes no longer replace an explicit method. A model compiled with --daeMode and simulated with a method other than ida now stops with:
The model was compiled with --daeMode, which works only with -s=ida
or -s=auto.
Before, the runtimes used IDA without an error. The testing gives an explicit method in two cases: the s of the __OpenModelica_simulationFlags annotation (s = "dassl" in Dynawo.Examples.SVarC), and the cvode and gbode solvers of the solvers job. These runs all fail on master now.
Find --daeMode in the custom commands of the library and the job, and in the __OpenModelica_commandLineOptions annotation of the model, as omc reads it: case-insensitive, with =false, and the last value wins. For such a model, ignore the s of the annotation and put -s=ida last in the simulation flags of every run. The runs then use IDA, as before #17977, so the cvode and gbode tables keep IDA results for these models.
The wasm FMU runners now use the same test. The old test did not find --daemode, which one Dynawo model uses.
Assisted-by: Claude Opus 5.5