Repository navigation
Compare hidden variables, skip missing constants - #418
Merged
Merged
Conversation
Since OpenModelica #17888, diffSimulationResults fails on a variable that is in the reference but not in the result. Many references have such variables that OpenModelica does not write: - Parameters with HideResult=true, for example m_flow_fixed of the ThermofluidStream sinks. -emit_protected does not write them. - Constants, for example dropOfCommons.instanceNameColor of ThermofluidStream, the fuel constants of ClaRa and eps of ModelicaTest. OpenModelica never writes constants. Simulate with -ignoreHideResult too, so that the hidden variables are in the result and are compared. Do not compare a variable that is not in the result when its value in the reference does not change: for a .mat reference, a variable that is not time-varying; for a CSV reference, a column with one value. The log lists these variables. A missing variable that changes over time is still a failure. Assisted-by: Claude Opus 5.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since OpenModelica #17888, diffSimulationResults fails on a variable that is in the reference but not in the result. Many references have such variables that OpenModelica does not write:
Simulate with -ignoreHideResult too, so that the hidden variables are in the result and are compared.
Do not compare a variable that is not in the result when its value in the reference does not change: for a .mat reference, a variable that is not time-varying; for a CSV reference, a column with one value. The log lists these variables. A missing variable that changes over time is still a failure.
Assisted-by: Claude Opus 5.5