Repository navigation
Keep reports off asap-remote, survive mail errors (#416) - #417
Merged
Merged
Conversation
The report stages ran on asap-remote, which has been moved. Its publish-reports.py could not reach smtp.office365.com, and the OSError failed the stage before the overviews were built. Run the report stages on linux && !asap-remote. Catch OSError and SMTPException around the SMTP session: print the emails left unsent (the reports are recorded, so a rerun would not send them), exit with 2 and let the Jenkinsfile mark the build unstable, so the overviews are still built. Give the connection a 60 s timeout. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #416.
The report stage failed in
publish-reports.pyonasap-remote(OSError: [Errno 101] Network is unreachableconnecting tosmtp.office365.com). The reports were already recorded, so their emails were lost, and the overviews built after that step were never regenerated.Changes
.CI/Jenkinsfile: thereport,drop stale pull request tablesandpull request reportstages (which share thews/OpenModelicaLibraryTestingReportworkspace) now run onlinux && !asap-remote.publish-reports.py:OSErrorandSMTPExceptionfrom the SMTP session are caught. The script prints the unsent recipients and their report lines, since a rerun would not send them, and exits with 2. The connection gets a 60 s timeout..CI/Jenkinsfile: exit code 2 marks the build unstable and the stage goes on to build the overviews. Any other non-zero exit still fails it.Tested locally against stub
resultsdbandsmtplibmodules: an unreachable server prints both unsent emails, removes the pending file and exits 2, and a reachable one sends both and exits 0. Not run in Jenkins yet. The node nameasap-remoteis taken from the Jenkins agent name, so check that it matches.🤖 Generated with Claude Code