Repository navigation
Conversation
jyxjjj
previously requested changes
Nov 13, 2026
jyxjjj
left a comment
Member
There was a problem hiding this comment.
[P1] build.sh 的 FetchWebRelease 删除 grep -v lite 后,会同时匹配标准版和 lite 版前端包。当前前端最新 Release v4.2.9 仍有这两个 tar.gz,release_tar_url 会包含换行,传给 curl 时成为无效 URL,标准版 Release 构建也会失败。要改成精确匹配标准包,或保留排除 lite 的条件,FetchWebRolling 同理。关联前端改动尚未发布时,后端不能假设旧 Release 的 lite 产物已经消失。
前端产物:https://github.com/OpenListTeam/OpenList-Frontend/releases/tag/v4.2.9
-- 人工核查认为 AI 本次评论可能有误
Reviewed or refined by GPT-6.1-Sol Medium
Releases from OpenList-Frontend still ship both openlist-frontend-dist-<ver>.tar.gz and openlist-frontend-dist-lite-<ver>.tar.gz, so matching "openlist-frontend-dist" alone returns two URLs. The multi-line value reached curl as a single malformed argument and aborted release builds (curl exit 3) before the archive was unpacked, breaking every release matrix job and the docker release build until the frontend drops its lite artifact. Match the standard name explicitly and require exactly one candidate, failing with the offending list instead of handing a bad URL to curl.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary / 摘要
移除 lite 版本的后端构建与 Docker 发布,后续仅保留标准版。
用户可见:Release Assets 不再包含
*-lite.zip、*-lite.tar.gz、md5*-lite.txt;Docker 不再发布-lite、-lite-ffmpeg、-lite-aria2、-lite-aio标签。build.sh:删除lite参数识别、useLite分支、产物-lite后缀与 MD5 文件名变体;前端 dist 始终下载openlist-frontend-dist-*.tar.gz。.github/workflows/release.yml:矩阵去掉build-type: ['standard', 'lite'],Build步骤不再传lite。.github/workflows/release_docker.yml:删除ARTIFACT_NAME_LITE、build_binary_lite、release_docker_lite。This PR has breaking changes.
/ 此 PR 包含破坏性变更。
This PR changes public API, config, storage format, or migration behavior.
/ 此 PR 修改了公开 API、配置、存储格式或迁移行为。
This PR requires corresponding changes in related repositories.
/ 此 PR 需要关联仓库同步修改。
Related repository PRs / 关联仓库 PR:
Testing / 测试
go test ./.../ 未执行:本次仅改动构建脚本与 workflow,未涉及 Go 代码。
/ 手动验证:
- 三个工作流经 YAML 解析通过;
release.yml作业为prerelease, release,release_docker.yml作业为build_binary, release_docker。- 全仓检索确认无
lite构建残留(仅剩第三方库golang-sdk-lite名称)。- 本机为 Windows 且无 bash,未执行
bash -n与实际构建。Checklist / 检查清单
/ 我已阅读 CONTRIBUTING。
/ 我确认此贡献符合仓库许可证、贡献规范和行为准则。
gofmt,go fmt, orprettierwhere applicable./ 我已按适用情况使用
gofmt、go fmt或prettier格式化变更代码。/ 我已在适用情况下请求相关维护者或代码所有者审查。
AI Disclosure / AI 使用声明
/ 此 PR 包含 AI 辅助内容。
Tools used / 使用工具:
Usage scope / 使用范围:
Code generation / 代码生成
Refactoring / 重构
Documentation / 文档
Tests / 测试
Translation / 翻译
Review assistance / 审查辅助
I have reviewed and validated all AI-assisted content included in this PR.
/ 我已审核并验证此 PR 中的所有 AI 辅助内容。
I have ensured that all AI-assisted commits include
Co-Authored-Byattribution./ 提交未附加
Co-Authored-By,如项目要求可补充。I can reproduce all AI-assisted content included in this PR without any AI tools.
/ 我可以在没有任何 AI 工具的情况下重现此 PR 中包含的所有 AI 辅助内容。