Skip to content

sstar: name Infinity2M instead of reporting it as unknown - #282

Merged
openipc-ai merged 2 commits into
masterfrom
sstar-infinity2m
Nov 13, 2026
Merged

openipc-ai merged 2 commits into
masterfrom
sstar-infinity2m

Conversation

@openipc-ai

Copy link
Copy Markdown
Contributor

INFINITY2M (0xF0, Taiyaki) has been in src/hal/sstar.h since #69, but sstar_detect_cpu() had no case for it and getchipfamily() no family. An Infinity2M part was therefore detected as SigmaStar and then reported as

chip:
  vendor: SigmaStar
  model: unknown
  family: unknown

It now reports model: SSD20X and family: infinity2m.

Why "SSD20X". SSD201/SSD202 and the SSR62x NVR parts are one generation, and nothing ipctool reads tells them apart. So the model is the group's name, as SSC33X and SSC37X already are. It has no slash because ipcinfo -c prints it and scripts read it.

Evidence. An owner report to openipc.org from a Jooan JA-8108 NVR: https://openipc.org/cameras/boards/jooan-ja-8108

  • the chip is marked SSR621Q (photographed), on board SSR621Q_V202P1_NVR04
  • BROM tag MVX4######g833de85I2m_ROM####XVM; the IPL and U-Boot versions start I2g
  • ipctool printed model: unknown, family: unknown

I have no Infinity2M hardware. The register value 0xF0 comes from the existing table, not from a reading taken on this unit. If anyone has an SSD20x or SSR62x, ipctool output from it would confirm it.

Native build and all unit tests pass. Nothing else changes: pad-mux and the die-ID read already keyed on chip_generation, which was set for this part before.

INFINITY2M (0xF0) has been defined since #69, but sstar_detect_cpu()
had no case for it, so an Infinity2M part was detected as SigmaStar and
then printed with model and family "unknown". It now reports model
SSD20X and family infinity2m.

SSD201/SSD202 and the SSR62x NVR parts are one generation and nothing
ipctool reads tells them apart, so the model is the group's name, as
SSC33X and SSC37X are.

Reported from an SSR621Q in a Jooan JA-8108 NVR: BROM tag
MVX4######g833de85I2m_ROM####XVM, U-Boot "Version: I2g...", the chip
marked SSR621Q.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@qodo-free-for-open-source-projects

Copy link
Copy Markdown

PR Summary by Qodo

Report Infinity2M as SSD20X with the infinity2m family

🐞 Bug fix 🕐 Less than 10 minutes

Grey Divider

AI Description

• Name Infinity2M chips SSD20X instead of reporting an unknown model.
• Report their family as infinity2m, making SigmaStar chip information useful to scripts.
Diagram

graph TD
  A["SoC ID register"] --> B["SigmaStar detector"] --> C["SSD20X model"] --> E["Chip report"]
  B --> D["Family lookup"] --> E
Loading
High-Level Assessment

The existing generation-based mappings are the right place for this fix. A more specific SSD201, SSD202, or SSR62x model would require evidence the current detection reads cannot provide; keep the group-level name pending hardware confirmation.

Files changed (2) +11 / -0

Bug fix (2) +11 / -0
chipid.cMap Infinity2M to the infinity2m family +4/-0

Map Infinity2M to the infinity2m family

• Adds an Infinity2M case to the SigmaStar family mappings so reports return infinity2m rather than the fallback name.

src/chipid.c

sstar.cIdentify Infinity2M chips as SSD20X +7/-0

Identify Infinity2M chips as SSD20X

• Adds an Infinity2M case to SigmaStar CPU detection, replacing the unknown model with the generation-level name SSD20X. The comment explains why individual SSD20x and SSR62x parts are not distinguished.

src/hal/sstar.c

@qodo-free-for-open-source-projects

qodo-free-for-open-source-projects Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0) 🎨 UX issues (0) 🔗 Cross-repo conflicts (0) 📜 Skill insights (0)

Grey Divider


Informational

1. Infinity2M model name has no test ✓ Resolved
Description
The new case INFINITY2M in sstar_detect_cpu() maps register value 0xF0 to SSD20X, but no test
asserts that mapping. A later change that drops or renames this arm would leave Infinity2M parts
reporting unknown again without any test failing.

Grey Divider

Tip of the day
💡 Did you know, you can start a comment with 'qodo' or '@qodo' to chat about any finding

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

Qodo's review: nothing failed if the Infinity2M case went away again.
sstar_test drives sstar_detect_cpu() through its own mem_reg() for every
generation with a name, one without (still SigmaStar, unnamed) and no
/dev/mem; reginfo_test checks the family each generation prints. Each
fails with the Infinity2M case removed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@openipc-ai

Copy link
Copy Markdown
Contributor Author

Qodo's Infinity2M model name has no test: addressed in af9535b. Asserting the name back after as_chip() would only test the helper, so sstar_test runs sstar_detect_cpu() against its own mem_reg() for every named generation (Infinity2M included), one without a name, and no /dev/mem. reginfo_test checks getchipfamily() for each SigmaStar generation. Both fail with the Infinity2M case removed (checked).

@openipc-ai
openipc-ai merged commit b88a43b into master Nov 13, 2026
5 checks passed
@openipc-ai
openipc-ai deleted the sstar-infinity2m branch November 13, 2026 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant