Repository navigation
sstar: name Infinity2M instead of reporting it as unknown - #282
Conversation
INFINITY2M (0xF0) has been defined since #69, but sstar_detect_cpu() had no case for it, so an Infinity2M part was detected as SigmaStar and then printed with model and family "unknown". It now reports model SSD20X and family infinity2m. SSD201/SSD202 and the SSR62x NVR parts are one generation and nothing ipctool reads tells them apart, so the model is the group's name, as SSC33X and SSC37X are. Reported from an SSR621Q in a Jooan JA-8108 NVR: BROM tag MVX4######g833de85I2m_ROM####XVM, U-Boot "Version: I2g...", the chip marked SSR621Q. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
PR Summary by QodoReport Infinity2M as SSD20X with the infinity2m family
AI Description
Diagram
High-Level Assessment
Files changed (2)
|
Code Review by Qodo
1.
|
Qodo's review: nothing failed if the Infinity2M case went away again. sstar_test drives sstar_detect_cpu() through its own mem_reg() for every generation with a name, one without (still SigmaStar, unnamed) and no /dev/mem; reginfo_test checks the family each generation prints. Each fails with the Infinity2M case removed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Qodo's Infinity2M model name has no test: addressed in af9535b. Asserting the name back after |
INFINITY2M(0xF0, Taiyaki) has been insrc/hal/sstar.hsince #69, butsstar_detect_cpu()had no case for it andgetchipfamily()no family. An Infinity2M part was therefore detected as SigmaStar and then reported asIt now reports
model: SSD20Xandfamily: infinity2m.Why "SSD20X". SSD201/SSD202 and the SSR62x NVR parts are one generation, and nothing ipctool reads tells them apart. So the model is the group's name, as
SSC33XandSSC37Xalready are. It has no slash becauseipcinfo -cprints it and scripts read it.Evidence. An owner report to openipc.org from a Jooan JA-8108 NVR: https://openipc.org/cameras/boards/jooan-ja-8108
SSR621Q_V202P1_NVR04MVX4######g833de85I2m_ROM####XVM; the IPL and U-Boot versions startI2gmodel: unknown,family: unknownI have no Infinity2M hardware. The register value 0xF0 comes from the existing table, not from a reading taken on this unit. If anyone has an SSD20x or SSR62x,
ipctooloutput from it would confirm it.Native build and all unit tests pass. Nothing else changes: pad-mux and the die-ID read already keyed on
chip_generation, which was set for this part before.