Skip to content

sigmastar: majestic on the infinity3 lite images - #2741

Merged
openipc-ai merged 2 commits into
masterfrom
infinity3-majestic
Nov 1, 2026
Merged

openipc-ai merged 2 commits into
masterfrom
infinity3-majestic

Conversation

@openipc-ai

Copy link
Copy Markdown
Collaborator

Problem

The infinity3 lite images (msc313e, msc316dc, msc316dm) ship no streamer: there was no majestic for infinity3 (OpenIPC/majestic#360). There is one now, majestic.infinity3.lite, on the release bucket, built for the vendor stack that #2735 made run. This enables it, with its web UI and fonts, the way the infinity6 lite defconfigs do.

Hardware tested on

Not run on a camera. There is no infinity3 board in reach; the reporter of OpenIPC/majestic#360 (Imou LOOC 2, MSC316DC + OV2735) has offered to test. What has run is qemu-bench's msc313e machine (with OpenIPC/qemu-bench#221), booting this branch's msc313e_lite kernel with its rootfs as an initramfs, -m 128 (the rootfs no longer unpacks in the model's 64 MB as an initramfs; on flash it is a squashfs). The camera stays unclaimed there, so nothing below involved a password or the EULA.

Evidence

Before (master, 0047f43): no streamer in the image.

msc313e_lite   - uImage: [1878KB/2048KB]  - rootfs.squashfs: [3960KB/5120KB]
msc316dc_lite  - uImage: [1879KB/2048KB]  - rootfs.squashfs: [3960KB/5120KB]

After (this branch, make BOARD=<board>):

msc313e_lite   - uImage: [1878KB/2048KB]  - rootfs.squashfs: [4912KB/5120KB]
msc316dc_lite  - uImage: [1878KB/2048KB]  - rootfs.squashfs: [4912KB/5120KB]
msc316dm_lite  - uImage: [1879KB/2048KB]  - rootfs.squashfs: [4912KB/5120KB]

msc313e_lite on qemu-bench msc313e, syslog:

majestic[753]: Majestic Lite for SigmaStar (infinity3), version master+05d531d, built on 2026-10-31 19:05
majestic[753]: RTSP server started on port 554
majestic[753]: Live backlog budget: 32263 KiB of 125744 KiB RAM (headroom bound, memory available 80660 KiB); ...

From the host, unclaimed:

GET /setup.html  200 33463 bytes
GET /image.jpg   401

The model's encoder dump (-global sstar-mfe.dump=) of that boot, first 8 MB, on ffprobe: h264,Main,1920,1080,76 frames; one frame has one macroblock the decoder rejects, which is the encoder model's, not majestic's (majestic only receives the bitstream). About one boot in five the model stalls before the encoder starts; that is OpenIPC/qemu-bench, not this change.

Not checked: RTSP and snapshots from outside (unclaimed), the sub stream, day/night, the WiFi and USB paths on these images, and any real sensor.

Scope

  • No kernel patches under general/package/all-patches/linux/ (those go to OpenIPC/linux)
  • No files specific to a single retail camera model (those go to OpenIPC/builder)
  • No probing or bring-up tooling (that goes to OpenIPC/ipctool)
  • Nothing under general/overlay/ or in a shared load_<vendor> script hardcodes a value specific to my board
  • Package sources come from an OpenIPC repository, and any version bump keeps at least the specificity of the pin it replaces (a new package should pin a full 40-character SHA)
  • No LD_PRELOAD, and no binaries that cannot be rebuilt from source
  • New code is selected by a defconfig, so CI actually builds it

The msc313e, msc316dc and msc316dm lite images shipped no streamer: there was
no majestic for infinity3 (OpenIPC/majestic#360). There is one now,
majestic.infinity3.lite on the release bucket, built against the vendor stack
#2735 made run, so these defconfigs take majestic, its web UI and its fonts
the way the infinity6 lite ones do.

The rootfs grows from 3960 to 4912 KB of its 5120 on all three, 208 KB short
of the cap.
@qodo-free-for-open-source-projects

Copy link
Copy Markdown

PR Summary by Qodo

Enable Majestic on SigmaStar Infinity3 lite images

✨ Enhancement ⚙️ Configuration changes 🕐 10-20 Minutes

Grey Divider

AI Description

• Add Majestic streaming to the msc313e, msc316dc, and msc316dm lite images.
• Include its web UI and fonts using the existing package definitions.
• Builds fit the rootfs limit; emulator boot checks passed, but camera hardware remains untested.
Diagram

graph TD
  D["Infinity3 lite configs"] --> B["Buildroot selection"] --> M["Majestic binary"] --> R["Lite rootfs"]
  B --> W["Web UI"] --> R
  B --> F["Fonts"] --> R
Loading
High-Level Assessment

Selecting the existing packages in each defconfig is the appropriate approach: it follows other SigmaStar lite images and keeps the change within the affected boards. Shared package or startup changes are unnecessary. Hardware validation remains the main outstanding check, particularly with only 208 KB of rootfs headroom.

Files changed (3) +9 / -0

Enhancement (3) +9 / -0
msc313e_lite_defconfigInclude Majestic in the msc313e lite image +3/-0

Include Majestic in the msc313e lite image

• Enables the existing Majestic streamer, web UI, and font packages. The reported image build fits the rootfs limit, and an msc313e emulator boot started Majestic; camera hardware was not tested.

br-ext-chip-sigmastar/configs/msc313e_lite_defconfig

msc316dc_lite_defconfigInclude Majestic in the msc316dc lite image +3/-0

Include Majestic in the msc316dc lite image

• Enables the existing Majestic streamer, web UI, and font packages for this Infinity3 lite board. The reported image build fits the rootfs limit; no board-level streaming test is reported.

br-ext-chip-sigmastar/configs/msc316dc_lite_defconfig

msc316dm_lite_defconfigInclude Majestic in the msc316dm lite image +3/-0

Include Majestic in the msc316dm lite image

• Enables the existing Majestic streamer, web UI, and font packages for this Infinity3 lite board. The reported image build fits the rootfs limit; no board-level streaming test is reported.

br-ext-chip-sigmastar/configs/msc316dm_lite_defconfig

@qodo-free-for-open-source-projects

qodo-free-for-open-source-projects Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (1) 📎 Requirement gaps (0) 🎨 UX issues (0) 🔗 Cross-repo conflicts (0) 📜 Skill insights (0)

Grey Divider


Action required

1. Infinity3 images lack camera validation 📘 Rule violation ☼ Reliability
Description
Each of the three Infinity3 defconfigs now enables Majestic, its web UI, and fonts. The PR
explicitly reports that no Infinity3 board was available and supplies only qemu-bench evidence, so
the firmware behavior reached by these selections remains unverified on a camera.
Code

br-ext-chip-sigmastar/configs/msc313e_lite_defconfig[R59-61]

+BR2_PACKAGE_MAJESTIC_FONTS=y
+BR2_PACKAGE_MAJESTIC_WEBUI=y
+BR2_PACKAGE_MAJESTIC=y
Evidence
The changed defconfig lines enable Majestic and its web assets in all three affected Infinity3
images. The PR description states that the change was not run on a camera and provides only
qemu-bench evidence, which does not satisfy the hardware-validation requirement.

Rule 3: Hardware evidence is present and honest
br-ext-chip-sigmastar/configs/msc313e_lite_defconfig[59-61]
br-ext-chip-sigmastar/configs/msc316dc_lite_defconfig[59-61]
br-ext-chip-sigmastar/configs/msc316dm_lite_defconfig[59-61]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The PR enables Majestic, its web UI, and fonts in three Infinity3 firmware images, but explicitly states that the change was not tested on an Infinity3 camera. The compliance gate requires hardware evidence for changes that can alter camera firmware behavior.
## Fix Focus Areas
- br-ext-chip-sigmastar/configs/msc313e_lite_defconfig[59-61]
- br-ext-chip-sigmastar/configs/msc316dc_lite_defconfig[59-61]
- br-ext-chip-sigmastar/configs/msc316dm_lite_defconfig[59-61]
## Recommended Fix
Test at least one affected Infinity3 camera and add its symptom, board identity, before/after output, and relevant boot, streaming, or web UI evidence to the PR description. If no camera can be accessed, obtain equivalent evidence from the hardware owner before merging.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


2. The new streamers fail to start ✓ Resolved
Description
The three new defconfigs enable Majestic, but its package metadata declares json-c only as a build
dependency while its configuration does not select the runtime library. On these profiles no other
package selects JSON-C, so the dynamic loader cannot start /usr/bin/majestic and the new video
service remains unavailable.
Code

br-ext-chip-sigmastar/configs/msc313e_lite_defconfig[61]

+BR2_PACKAGE_MAJESTIC=y
Evidence
Majestic lists json-c in MAJESTIC_DEPENDENCIES, but its Kconfig selects only zlib. The three
changed profiles add Majestic and its UI assets without selecting JSON-C, while the init script
launches /usr/bin/majestic at boot, leaving the daemon unable to load its required shared library.

general/package/majestic/majestic.mk[15-21]
general/package/majestic/Config.in[1-6]
br-ext-chip-sigmastar/configs/msc313e_lite_defconfig[59-61]
br-ext-chip-sigmastar/configs/msc316dc_lite_defconfig[59-61]
br-ext-chip-sigmastar/configs/msc316dm_lite_defconfig[59-61]
general/package/majestic/files/S95majestic[156-161]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The new SigmaStar profiles enable Majestic without selecting `BR2_PACKAGE_JSON_C`. `MAJESTIC_DEPENDENCIES` controls build ordering but does not enable the JSON-C target package, so the resulting image can lack `libjson-c` and fail to start Majestic.
### Fix Focus Areas
- general/package/majestic/Config.in[1-6]
- br-ext-chip-sigmastar/configs/msc313e_lite_defconfig[59-61]
- br-ext-chip-sigmastar/configs/msc316dc_lite_defconfig[59-61]
- br-ext-chip-sigmastar/configs/msc316dm_lite_defconfig[59-61]
### Recommended Fix
Add `select BR2_PACKAGE_JSON_C` to the `BR2_PACKAGE_MAJESTIC` definition, following the existing dependency-selection pattern, then regenerate or validate all three defconfigs and confirm that `libjson-c` is included in the target filesystem.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

Tip of the day
💡 Did you know, you can show, collapse, or hide each part of a finding: code, evidence, and all

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

majestic.mk lists json-c in its dependencies, which builds it but leaves
BR2_PACKAGE_JSON_C unset, and libyaml came only through yaml-cli. Every
image that has majestic carried both anyway, but nothing said it must,
the way the select of zlib already does (review of #2741).
@openipc-ai
openipc-ai merged commit 7a60c73 into master Nov 1, 2026
135 of 136 checks passed
@openipc-ai
openipc-ai deleted the infinity3-majestic branch November 1, 2026 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant