Repository navigation
sigmastar: majestic on the infinity3 lite images - #2741
Conversation
The msc313e, msc316dc and msc316dm lite images shipped no streamer: there was no majestic for infinity3 (OpenIPC/majestic#360). There is one now, majestic.infinity3.lite on the release bucket, built against the vendor stack #2735 made run, so these defconfigs take majestic, its web UI and its fonts the way the infinity6 lite ones do. The rootfs grows from 3960 to 4912 KB of its 5120 on all three, 208 KB short of the cap.
PR Summary by QodoEnable Majestic on SigmaStar Infinity3 lite images
AI Description
Diagram
High-Level Assessment
Files changed (3)
|
Code Review by Qodo
1. Infinity3 images lack camera validation
|
majestic.mk lists json-c in its dependencies, which builds it but leaves BR2_PACKAGE_JSON_C unset, and libyaml came only through yaml-cli. Every image that has majestic carried both anyway, but nothing said it must, the way the select of zlib already does (review of #2741).
Problem
The infinity3 lite images (msc313e, msc316dc, msc316dm) ship no streamer: there was no majestic for infinity3 (OpenIPC/majestic#360). There is one now,
majestic.infinity3.lite, on the release bucket, built for the vendor stack that #2735 made run. This enables it, with its web UI and fonts, the way the infinity6 lite defconfigs do.Hardware tested on
Not run on a camera. There is no infinity3 board in reach; the reporter of OpenIPC/majestic#360 (Imou LOOC 2, MSC316DC + OV2735) has offered to test. What has run is qemu-bench's
msc313emachine (with OpenIPC/qemu-bench#221), booting this branch'smsc313e_litekernel with its rootfs as an initramfs,-m 128(the rootfs no longer unpacks in the model's 64 MB as an initramfs; on flash it is a squashfs). The camera stays unclaimed there, so nothing below involved a password or the EULA.Evidence
Before (master, 0047f43): no streamer in the image.
After (this branch,
make BOARD=<board>):msc313e_lite on qemu-bench
msc313e, syslog:From the host, unclaimed:
The model's encoder dump (
-global sstar-mfe.dump=) of that boot, first 8 MB, on ffprobe:h264,Main,1920,1080,76frames; one frame has one macroblock the decoder rejects, which is the encoder model's, not majestic's (majestic only receives the bitstream). About one boot in five the model stalls before the encoder starts; that is OpenIPC/qemu-bench, not this change.Not checked: RTSP and snapshots from outside (unclaimed), the sub stream, day/night, the WiFi and USB paths on these images, and any real sensor.
Scope
general/package/all-patches/linux/(those go to OpenIPC/linux)general/overlay/or in a sharedload_<vendor>script hardcodes a value specific to my boardLD_PRELOAD, and no binaries that cannot be rebuilt from source