Repository navigation
examples/cellcaps: print the AdapterCaps that gate a cell node - #580
Merged
Merged
Conversation
…r vfio PCIe) A small read-only probe: opens the radio named in the environment (DEVOURER_VID/PID or DEVOURER_PCIE_BDF) and prints, as JSON, the caps examples/cell caps_ok checks (tsf_write_ok, tbtt_follows_tsf, beacon_backoff_ctl, hw_beacon_txtsf) plus ack_responder_ok and the timestamp caps, with a cell_node_ok verdict. Used to confirm on hardware that a USB 8852CU reports cell_node_ok=0 (TSF-write/TBTT refused over USB) while the same die over PCIe passes — see #579. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
PR Summary by QodoAdd a USB and PCIe cell-capability probe
AI Description
Diagram
High-Level Assessment
Files changed (2)
|
Code Review by Qodo
1.
|
…SIX-only - examples/common/cell_caps.h holds cell_node_caps_ok(AdapterCaps): the single source of truth for the caps a cell node needs. Both examples/cell caps_ok and the cellcaps probe call it, so the probe's cell_node_ok verdict cannot drift from the gate the cell node applies. - The cellcaps target is guarded if(NOT WIN32), like the other radio_open bench probes (libusb + POSIX _exit). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Collaborator
Author
|
Both fixed in
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small read-only diagnostic that answers "can this radio run a cell node?" for any USB or PCIe radio, the probe used to characterise the Kestrel caps in #579.
What
examples/cellcapsopens the radio named in the environment and prints, as one JSON line, the caps thatexamples/cellcaps_okchecks — plus the ACK-responder and timestamp caps and acell_node_okverdict:{"ev":"cellcaps","radio":"usb 0bda:c85a","chip":"RTL8852C","variant":"C8852C","transport":"usb", "tsf_write_ok":0,"tbtt_follows_tsf":0,"beacon_backoff_ctl":1,"hw_beacon_txtsf":1, "ack_responder_ok":1,"hw_rx_timestamp":1,"hw_injected_mgmt_txtsf":1,"cell_node_ok":0}It reuses
examples/common/radio_open.h, so the one binary serves both transports, and does nothing beyond the normal open path — no beacon, no TX.Why
caps_okonly prints its four gate caps on failure, and only from inside the cell node. When qualifying a new radio or bus for a cell role (e.g. the USB-Kestrel question in #579, or the moving-UE node in #563) it's useful to read the full cell-gate verdict directly, without standing up a DU/UE. This is the probe that produced the hardware readout in #579.Notes
radio_openprobes; the PCIe path compiles only under-DDEVOURER_PCIE=ON(viaDEVOURER_HAVE_PCIE).Refs #579.
🤖 Generated with Claude Code