Repository navigation
xm-n51813l: [static_awb] CorrectionStrength 100 - #246
Merged
Merged
Conversation
The 80 % was tuned while majestic programmed an ISP image height of 0, and the white-balance statistics counted one line per zone (fixed in majestic #1256). On the real statistics, 80 % leaves every scene yellow (grey b* +18..+23); 100 % beats the stock firmware's ColorChecker colour error in every scene measured -- daylight and the room's bulbs at 3000-6000 K: dE 6.9-9.1 against 8.3-9.6.
widgetii
requested review from
cronyx,
flyrouter and
viktorxda
as code owners
November 14, 2026 09:41
PR Summary by QodoCorrect AR0130 white balance strength on XM-N51813L
AI Description
Diagram
High-Level Assessment
Files changed (1)
|
Code Review by Qodo
1.
|
…e tuning needs Review: the header still said the V1 AWB ignores its statistics and that CorrectionStrength keeps some of the light's colour; both described the camera before majestic's ISP image height fix. The dE figures are now the per-scene pairs against stock in the same minute, and the header names the majestic commit (and the reboot) the tuning depends on.
Member
Author
|
Review addressed in 5df2f69:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 80 % strength was tuned while majestic programmed an ISP image height of 0. The white-balance statistics then counted one line per zone; this is fixed in widgetii/majestic#1256 (cf4a1d2, merged, in the published master build). The tuning needs that majestic, plus a reboot after updating.
Measured on an N51813L against the stock firmware on a twin unit. Each OpenIPC sample is paired with stock's ColorChecker dE2000 from the same minute:
At strength 100, OpenIPC beats stock in all five pairs (mean 7.62 against 8.71). At 80 it is yellow everywhere: it holds the blue gain near 2.1, where stock uses 2.5–2.7.