Repository navigation
ci: check lib/types exports and time-limit the Playwright install - #16
Conversation
- publicApi.test.ts: every type declared in lib/types/* must be exported from lib/index.ts (GridAi*/GridAgent* from /ai), except an explicit INTERNAL_TYPES list, which must itself name existing types. - ci.yml: timeout-minutes 10 on the Playwright browser install, so a stalled download fails fast instead of holding the job for 40 minutes.
ECC Tools / Security EvidenceCommit: Security evidence gate passed (success) No security-sensitive scanner-evidence gap detected. Mode: enforce Scanned 3 changed file(s). No missing scanner-evidence signal was detected. Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission. |
ECC Tools / PR Risk TaxonomyCommit: PR taxonomy review recommended (neutral) Detected 3 PR taxonomy bucket(s): Security Evidence, CI/CD Recommendation, Cost/Token Risk. Scanned 3 changed file(s). Roadmap taxonomy buckets: Security EvidenceSecurity-sensitive changes should carry explicit scanner, code-scanning, or focused regression evidence. Signals:
Paths:
CI/CD RecommendationCI, dependency, coverage, and contract signals should be routed into follow-up checks or verification work. Signals:
Paths:
Cost/Token RiskAI routing, usage, and token-budget changes should include budget or usage-limit evidence. Signals:
Paths:
Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission. |
ECC Tools / Reference Set ReadinessCommit: Reference set readiness gaps detected (neutral) Reference evidence present for 0/7 areas (0%) across 3 changed file(s). This check is based on files changed in this PR. Repository-level readiness is still reported by
Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission. |
ECC Tools / Hosted Promotion ReadinessCommit: Hosted promotion readiness passed (success) No hosted promotion evidence gaps detected across 3 changed file(s); 0 corpus scenarios had matching evidence. This check compares PR file changes against the evaluator/RAG promotion corpus in No evaluator corpus scenarios matched this PR. Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission. |
ECC Tools / PR Config AuditCommit: No changed-config issues detected (success) Scanned 2 config file(s) present at this commit across 2 changed config path(s) and found no issues in the supported security rules. Changed config files:
Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission. |
ECC Tools / PR Harness AuditCommit: Harness warnings detected (neutral) Scanned 2 changed config file(s) and found 1 harness issue(s).
Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission. |
Summary
lib/publicApi.test.ts): fails when a type declared inlib/types/*is not exported fromlib/index.ts(GridAi*/GridAgent*from/ai). Three internal store types are allowlisted inINTERNAL_TYPESwith reasons; the test also fails if an allowlisted name disappears. The existing checks only caught a missing export once the docs named the type; the context-menu types in 3.11.0 nearly shipped un-importable.timeout-minutes: 10on Install Playwright browsers inci.yml: on PR feat: context menu for cells (3.11.0) #15 a stalled download held the job until its 40-minute timeout.Test plan
npx vitest run --project unit lib/publicApi.test.ts: 11 passedGridFillResultfromlib/index.tsmakes the test fail namingGridFillResult (lib/types/editing.ts)