Repository navigation
lift upper bound on python-json-logger dependency - #557
Merged
Merged
Conversation
Member
Author
|
this should address the "taskName" related failures in unit test runs on python 3.12 and up which was known and fixed issue nhairs/python-json-logger#3 but not available to use because of version upper bound e.g. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the update to require python-json-logger>=3.2.1.
No open issues 🎉
What changed in this PR
Updates the logging dependency to support Python 3.12 and newer, contributing to the compatibility work tracked in #541.
Changes:
- Replaces
python-json-logger~=2.0with>=3.2.1, removing the upper bound and requiring the release containing the upstream fix. - Removes the obsolete comment explaining the previous restriction.
| File | Description |
|---|---|
setup.py |
Updates the python-json-logger requirement to >=3.2.1. |
Review effort: Balanced
improves compatibility with Python 3.12 and up original bound was added for nhairs/python-json-logger#29 but that has been fixed in v3.2.1 ref #541
soxofaan
force-pushed
the
issue541-python312-jsonlogging-compatibility
branch
from
October 30, 2026 10:43
cb9046f to
aaf7db9
Compare
Member
Author
|
effect of this PR failures (on python 3.12) goes down from
to
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
improves compatibility with Python 3.12 and up
original bound was added for nhairs/python-json-logger#29 but that has been fixed in v3.2.1
ref #541