Repository navigation
extend raster:bands if no bands - #555
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The condition can create an empty raster:bands array when bands is empty and nodata or data_type is set, violating the raster extension’s nonempty-array requirement.
1 open issue
What changed in this PR
This PR supports nodata round-tripping by enriching existing raster-band metadata even when spectral band metadata is absent.
Changes:
- Move legacy
raster:bandsenrichment outside the spectral-band check. - Add raster-band metadata to the dummy NetCDF asset.
- Update job-result expectations across API versions and signed URL scenarios.
| File | Description |
|---|---|
tests/test_views.py |
Expect NetCDF raster-band nodata in job results. |
openeo_driver/dummy/dummy_backend.py |
Add an empty raster-band entry to the NetCDF fixture. |
openeo_driver/backend_/_geopyspark.py |
Enrich existing raster bands independently of spectral bands. |
Review effort: Balanced
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Open-EO/openeo-geotrellis-extensions#863