Repository navigation
Conversation
lucianogdittgen
force-pushed
the
upgrade/easysplash-84f31ef
branch
from
November 12, 2026 19:29
5f27bba to
6a6abf6
Compare
Brings the systemd unit fixes (easysplash.enable=0 boot parameter, RemainAfterExit, no start in containers), the cargo dependency upgrade (gstreamer-rs 0.20; crates regenerated with update_crates) and the Makefile fix for the systemdsystemunitdir lookup (OSSystems/EasySplash#28). The recipe still passes systemdsystemunitdir explicitly so the unit directory does not come from pkg-config. Tested: bitbake easysplash and both animations on qemuarm; buildhistory shows only the expected deltas. Signed-off-by: Luciano Dittgen <luciano.dittgen@ossystems.com.br>
The Makefile reads INITD, not INIT, so PACKAGECONFIG sysvinit never installed /etc/init.d/easysplash-start and update-rc.d had no script. Tested: bitbake easysplash on qemuarm, default oel (no change) and with PACKAGECONFIG sysvinit (init script installed, paths substituted). Signed-off-by: Luciano Dittgen <luciano.dittgen@ossystems.com.br>
lucianogdittgen
force-pushed
the
upgrade/easysplash-84f31ef
branch
from
November 12, 2026 21:00
6a6abf6 to
5cdfc2f
Compare
This was referenced Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two commits:
easysplash: Upgrade 81a4439 -> 7829a12: picks up the 9 upstream commits since the 2023 pin: systemd unit fixes (
easysplash.enable=0boot parameter,RemainAfterExit, no start in containers,KillMode=mixed) and the cargo dependency upgrade (gstreamer-rs 0.18 -> 0.20, glib 0.15 -> 0.17, toml 0.5 -> 0.7).easysplash-crates.incwas regenerated withbitbake -c update_crates easysplash. The animations share the SRCREV; their content is unchanged.7829a12 is the merged OSSystems/EasySplash#28, which fixes the Makefile's
systemdsystemunitdirlookup (84f31ef used a Make variable reference instead of$(shell ...), so the units would install to${D};/…). The recipe still passessystemdsystemunitdir=${systemd_system_unitdir}so the path follows the distro setting.easysplash: Pass INITD to install the sysvinit script: the recipe passed
INIT=, but the Makefile readsINITD, soPACKAGECONFIGsysvinitnever installed/etc/init.d/easysplash-start.Validation (qemuarm, oel)
Built
easysplash,easysplash-animation-defaultandeasysplash-animation-ossystems.Buildhistory against the pre-upgrade build: same files and paths (units still in
/usr/lib/systemd/system), the units gain the upstream conditions, the binary grows from 609664 to 695688 bytes, RDEPENDS unchanged.INITD: default
oel(systemd) shows no change. WithPACKAGECONFIG:pn-easysplash = "systemd sysvinit"(andRMINITDIRcleared sosystemd.bbclasskeeps/etc/init.d), the package gains/etc/init.d/easysplash-start(0755, paths substituted).Re-validated after the bump to 7829a12 (only the Makefile changed upstream): same deltas as above, apart from the version. The deployed ipk keeps the same file list, the sysvinit variant still installs
/etc/init.d/easysplash-start, andcontrib/oelint/run-oelint.shpasses.