Skip to content

#4690 included full timestamp for Slack Message inclduing day of week - #4741

Open
namanp07 wants to merge 1 commit into
feature/bay-dashboardfrom
#4690-NamanPatel-Dashboard
Open

namanp07 wants to merge 1 commit into
feature/bay-dashboardfrom
#4690-NamanPatel-Dashboard

Conversation

@namanp07

Copy link
Copy Markdown
Contributor

Changes

Scheduled event Slack notifications (sendEventScheduledSlackNotif) now include the day of the week.

  • Updated formatForSlack in src/shared/src/date-format.ts from 'M/D/YYYY [at] h:mm A' to 'dddd, M/D/YYYY [at] h:mm A'
  • Updated the function's doc comment with an example

Before: 11/18/2025 at 3:00 PM
After: Tuesday, 11/18/2025 at 3:00 PM

Notes

  • formatForSlack is only used by sendEventScheduledSlackNotif, so no other messages are affected.
  • Times are still always shown in Eastern time, so the weekday is the Eastern day. An event late at night UTC shows the correct local day.

Test Cases

  • 2025-11-18T20:00:00Z → Tuesday, 11/18/2025 at 3:00 PM
  • 2026-07-04T13:30:00Z → Saturday, 7/4/2026 at 9:30 AM (single-digit month/day, during daylight saving)
  • Both scheduled and rescheduled notifications use the same formatter, so both show the weekday

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #4690

@namanp07 namanp07 self-assigned this Nov 18, 2026
@coderabbitai

coderabbitai Bot commented Nov 18, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: ebf3ecb2-c260-475b-9da2-5a70aca6f375

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant