Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Manually opened attendance sessions now auto-close after 2 hours instead of 1.
ATTENDANCE_AUTO_CLOSE_MSconstant (2 * 60 * 60 * 1000) at the top ofattendance.services.tstakeAttendancenow uses this constant in itssetTimeoutinstead of the hardcoded3600000Notes
takeAttendance. Sessions opened automatically for a scheduled meeting are unchanged — they still close when the meeting ends (viacloseEndedScheduledAttendancesin the bay-cron job).setTimeout, so if the server restarts while a session is open, that session won't be auto-closed. This was already true before this change.Test Cases
closeAttendancereturns early ifclosedAtis already set)Checklist
It can be helpful to check the
ChecksandFiles changedtabs.Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
yarn.lockchanges (unless dependencies have changed)Closes #4586