Skip to content

#4586 made a new constant which can be put into the wait time - #4740

Open
namanp07 wants to merge 1 commit into
feature/bay-dashboardfrom
#4586-NamanPatel-Dashboard
Open

namanp07 wants to merge 1 commit into
feature/bay-dashboardfrom
#4586-NamanPatel-Dashboard

Conversation

@namanp07

@namanp07 namanp07 commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Changes

Manually opened attendance sessions now auto-close after 2 hours instead of 1.

  • Added a ATTENDANCE_AUTO_CLOSE_MS constant (2 * 60 * 60 * 1000) at the top of attendance.services.ts
  • takeAttendance now uses this constant in its setTimeout instead of the hardcoded 3600000

Notes

  • This only affects sessions opened manually via takeAttendance. Sessions opened automatically for a scheduled meeting are unchanged — they still close when the meeting ends (via closeEndedScheduledAttendances in the bay-cron job).
  • The auto-close still uses an in-memory setTimeout, so if the server restarts while a session is open, that session won't be auto-closed. This was already true before this change.

Test Cases

  • Opening attendance manually schedules the auto-close for 2 hours later
  • Closing attendance manually before 2 hours still works, and the later timeout does nothing (closeAttendance returns early if closedAt is already set)
  • Scheduled meeting attendance still closes when the meeting ends

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #4586

@namanp07 namanp07 self-assigned this Nov 18, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant