Repository navigation
Conversation
--start-stopped suspends the process without telling the runtime to wait for a debugger, so nothing resumes it. The app now gets --nativescript-debug-brk like the pre-iOS 17 path, and the runtime waits. App arguments have to come after devicectl's own options. The start response includes the pid, so the CLI can attach a native debugger.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
On iOS 17+ devices,
waitForDebuggerlaunches withdevicectl --start-stoppedand never passes--nativescript-debug-brk. The process is suspended without the runtime knowing it should wait, and nothing is set up to resume it. Sons debug ios --debug-brkdoesn't stop for a debugger.What is the new behavior?
--nativescript-debug-brk, as the pre-iOS 17 path already does. The runtime does the waiting.devicectl's own options.run_devicectlappended--quiet --json-outputto the end, which would have handed them to the app.startresponse includespidon iOS 17+. The CLI uses it to attach a native debugger, because iOS kills an app that takes about 20 seconds to launch.Testing
Tested with the CLI and runtime PRs below on an iPad on iPadOS 26.7: a demo app waited, a CDP client connected, the app stayed paused for 40 seconds, then resumed and ran. JS tests pass. Devices below iOS 17 weren't tested, and that path is unchanged.
Part of a stack
Base: #88. All of these are needed for
--debug-brkon devices: