Skip to content

Build and test with CUDA 13.4.3 - #2965

Open
jameslamb wants to merge 4 commits into
NVIDIA:mainfrom
jameslamb:cuda-13.4
Open

jameslamb wants to merge 4 commits into
NVIDIA:mainfrom
jameslamb:cuda-13.4

Conversation

@jameslamb

Copy link
Copy Markdown
Member

Contributes to rapidsai/build-planning#335

  • uses CUDA 13.4.3 to build and test
  • updates to CUDA 13.4.3 devcontainers

@jameslamb jameslamb added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels Oct 29, 2026
@copy-pr-bot

copy-pr-bot Bot commented Oct 29, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@jameslamb

Copy link
Copy Markdown
Member Author

/ok to test 7bb271c

@jameslamb jameslamb added non-breaking Introduces a non-breaking change and removed non-breaking Introduces a non-breaking change labels Oct 29, 2026
@jameslamb

Copy link
Copy Markdown
Member Author

/ok to test 7442497

@jameslamb
jameslamb marked this pull request as ready for review October 30, 2026 16:46
@jameslamb
jameslamb requested review from a team as code owners October 30, 2026 16:46
@coderabbitai

coderabbitai Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: NVIDIA/cuvs
  • Branch: main
  • File: .coderabbit.yaml
  • Commit: 98b95b6
  • Layers: Repository YAML
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: bb42893f-c7ca-4cfb-806e-d639ddaac914
Commits

Reviewing files that changed from the base of the PR and between 98b95b6 and 7442497.

Files selected for processing: 29
  • .devcontainer/cuda13.4-conda/devcontainer.json
  • .devcontainer/cuda13.4-pip/devcontainer.json
  • .github/workflows/build.yaml
  • .github/workflows/clib-build.yaml
  • .github/workflows/matrix-job.yaml
  • .github/workflows/pr.yaml
  • .github/workflows/publish-rust.yaml
  • .github/workflows/test.yaml
  • build.sh
  • conda/environments/all_cuda-134_arch-aarch64.yaml
  • conda/environments/all_cuda-134_arch-x86_64.yaml
  • conda/environments/bench_ann_cuda-134_arch-aarch64.yaml
  • conda/environments/bench_ann_cuda-134_arch-x86_64.yaml
  • conda/environments/go_cuda-134_arch-aarch64.yaml
  • conda/environments/go_cuda-134_arch-x86_64.yaml
  • conda/environments/rust_cuda-134_arch-aarch64.yaml
  • conda/environments/rust_cuda-134_arch-x86_64.yaml
  • dependencies.yaml
  • examples/go/README.md
  • fern/pages/build.md
  • fern/pages/cuvs_bench/install.md
  • fern/pages/installation/c.md
  • fern/pages/installation/cpp.md
  • fern/pages/installation/go.md
  • fern/pages/installation/java.md
  • fern/pages/installation/python.md
  • fern/pages/installation/rust.md
  • java/docker-build/README.md
  • python/libcuvs/pyproject.toml

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

📝 Summary

Summary by CodeRabbit

  • New Features
    • Added CUDA 13.4 support across build and test workflows, package environments, and installation options.
  • Documentation
    • Updated installation and build guidance to use CUDA 13.4, including standalone builds.
  • Compatibility
    • Updated CUDA 13 wheel requirements to use the CUDA 13.4 toolkit and a matching minimum nvJitLink version.

CUDA 13.4 replaces CUDA 13.3 across dependency and Conda environment definitions, CI build and test matrices, development containers, build defaults, and installation instructions. The workflows also add an optional matrix_type input and pass it to compute-matrix.

Changes: CUDA 13.4 rollout

Layer / File(s) Summary
CUDA 13.4 dependency and environment definitions
dependencies.yaml, conda/environments/*cuda-134*, python/libcuvs/pyproject.toml
Dependency matrices and Conda environment files now select CUDA 13.4. The CUDA 13 nvJitLink minimum is 13.4.
Reusable workflow matrix input
.github/workflows/clib-build.yaml, .github/workflows/matrix-job.yaml
Both workflows accept an optional matrix_type input, defaulting to auto, and pass it to compute-matrix.
CI build, test, and publish matrix updates
.github/workflows/build.yaml, .github/workflows/pr.yaml, .github/workflows/test.yaml, .github/workflows/publish-rust.yaml
Build, pull-request, and test jobs select CUDA 13.4 matrix types. The Rust publish matrix changes its CUDA version to 13.4.3.
Development environments, build defaults, and installation instructions
.devcontainer/*/devcontainer.json, build.sh, examples/go/README.md, fern/pages/*, java/docker-build/README.md
Development container settings, the standalone C tarball default, and documented setup and installation commands now reference CUDA 13.4 or 13.4.3.

Priority: Normal

Estimated code review effort: 2 (Simple) | ~15 minutes

Change: Other

Suggested labels: Build

Suggested reviewers: bdice, cjnolet

Merge Risk: Minimal · up to 74424

No concrete merge-blocking defect was found in the CUDA 13.4 rollout.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly summarizes the primary change: building and testing with CUDA 13.4.3.
Description check Passed The description directly relates to the changeset by describing CUDA 13.4.3 build and test updates and devcontainer updates.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files. (28 skipped: 28 unsupported.)

Finishing Touches: 💡 1
🧪 Generate unit tests (beta)
  • Create a new PR
🛠️ Fix failing CI checks: 💡
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant