[mdboom]

#3209 upgraded cython-lint which added a new lint for inline functions that wouldn't be properly inlined across modules. To fix the lints, inline was removed from some functions, creating a performance regression, rather than moving the function definitions to the .pxd files.

Additionally, if cython-lint doesn't see all the files together, it can not correctly detect these cross-file issues. The fix is to always pass all of the cython files to cython-lint when any file in cuda_core/cuda changes.

[coderabbitai]

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: NVIDIA/cuda-python
• Branch: main
• File: .coderabbit.yaml
• Commit: 5d65e6f
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Enterprise
• Run ID: 189f7ddd-400b-426d-a393-a2aff6159e0b

Commits

Reviewing files that changed from the base of the PR and between 5d65e6f and b0f9c38.

Files selected for processing: 9

• .pre-commit-config.yaml
• cuda_core/cuda/core/_memory/_legacy.py
• cuda_core/cuda/core/_stream.pxd
• cuda_core/cuda/core/_stream.pyx
• cuda_core/cuda/core/_utils/cuda_utils.pxd
• cuda_core/cuda/core/_utils/cuda_utils.pyi
• cuda_core/cuda/core/_utils/cuda_utils.pyx
• cuda_core/cuda/core/graph/_graph_node.pxd
• cuda_core/cuda/core/graph/_graph_node.pyx

Files with no reviewable changes: 1

• cuda_core/cuda/core/_stream.pyx

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

📝 Summary

Summary by CodeRabbit

• Bug Fixes
  • Improved handling of memory-copy operations in CUDA graphs, including validation of buffer allocations and attachment owners.
  • Updated CUDA error handling and default-stream checks for more consistent behavior.
• Chores
  • Updated pre-commit linting to check the CUDA source directory when matching files change.

The changes move Cython helper implementations into declaration files, revise CUDA error-checking helpers, update memcpy operand resolution, and adjust the Cython lint hook and a type-checking annotation.

Changes: Cython helper updates

Layer / File(s)	Summary
Error checks and Cython support cuda_core/cuda/core/_utils/cuda_utils.pxd, cuda_core/cuda/core/_utils/cuda_utils.pyx, cuda_core/cuda/core/_utils/cuda_utils.pyi, cuda_core/cuda/core/_memory/_legacy.py, .pre-commit-config.yaml	Error-check declarations now return success or delegate failures to renamed helpers. The stub adds success constants and removes private checker declarations. The lint hook targets cuda_core/cuda, runs serially, and does not pass filenames. An import gains a type-checking annotation.
Stream-token checks cuda_core/cuda/core/_stream.pxd, cuda_core/cuda/core/_stream.pyx	Inline checks in the declaration file recognize both default-stream tokens, while the legacy-only check recognizes only the legacy token. The former implementations are removed from the .pyx file.
Memcpy operand resolution cuda_core/cuda/core/graph/_graph_node.pxd, cuda_core/cuda/core/graph/_graph_node.pyx	Inline helpers resolve Buffer and integer-address operands to device pointers and attachment owners. The former local helpers are removed from the .pyx file.

Possibly related issues

• [BUG]: cython-lint can miss cross-file inline violations when pre-commit batches files #3246: The lint-hook change matches the issue’s proposed serialized, full-directory invocation. The issue’s separate cdef inline changes are not included here.
• Fix performance regression in #3209 #3252: The stream-token checks are now inline in _stream.pxd, matching the issue’s report about removed inline declarations.

Possibly related PRs

• NVIDIA/cuda-python#3209: This PR changes the same error-check helpers and their inline declarations.
• NVIDIA/cuda-python#3173: This PR also changes the Cython lint configuration and binding exclusions.
• NVIDIA/cuda-python#3243: This PR changes the same stream default-token detection helpers.

Suggested reviewers: andy-jost, juenglin, jpascucci-nv

Priority: Low

Change: Bug fix

Merge Risk: Minimal · up to b0f9c

No merge-blocking issue was established; the change is ready for normal checks.

Finishing Touches: 💡 1

🛠️ Fix failing CI checks: 💡

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

Doc Preview CI
Preview removed because the pull request was closed or merged.