Skip to content

Fix cython-lint batching and ineffective helper inlining #3247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rwgk wants to merge 1 commit into from
Closed

Fix cython-lint batching and ineffective helper inlining #3247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,8 @@ repos:
rev: "35dbc940c2bd4499ebf39aba00ad717e05cec9b5" # frozen: v0.22.0
hooks:
- id: cython-lint
# Cross-file rules need .pxd declarations and .pyx implementations in one process.
require_serial: true
args: [--no-pycodestyle]
exclude: ^cuda_bindings_(?:12|13)/
additional_dependencies:
Expand Down
6 changes: 3 additions & 3 deletions cuda_core/cuda/core/_stream.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -517,7 +517,7 @@ cpdef Stream default_stream():
else:
return LEGACY_DEFAULT_STREAM

cdef inline bint Stream_handle_is_default_token(cydriver.CUstream s) noexcept nogil:
cdef bint Stream_handle_is_default_token(cydriver.CUstream s) noexcept nogil:
"""Return True for the raw CU_STREAM_LEGACY and CU_STREAM_PER_THREAD tokens.

These tokens carry no context of their own; they refer to whatever context
Expand All @@ -527,12 +527,12 @@ cdef inline bint Stream_handle_is_default_token(cydriver.CUstream s) noexcept no
return h == <uintptr_t>cydriver.CU_STREAM_LEGACY or h == <uintptr_t>cydriver.CU_STREAM_PER_THREAD


cdef inline bint Stream_is_default_token(Stream self) noexcept nogil:
cdef bint Stream_is_default_token(Stream self) noexcept nogil:
"""Return True when this stream is CU_STREAM_LEGACY or CU_STREAM_PER_THREAD."""
return Stream_handle_is_default_token(as_cu(self._h_stream))


cdef inline bint Stream_is_legacy_default_token(Stream self) noexcept nogil:
cdef bint Stream_is_legacy_default_token(Stream self) noexcept nogil:
"""Return True only for CU_STREAM_LEGACY.

Unlike CU_STREAM_PER_THREAD, the legacy default stream token is rejected
Expand Down
2 changes: 1 addition & 1 deletion cuda_core/cuda/core/graph/_graph_node.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -923,7 +923,7 @@ cdef inline OpaqueHandle _buffer_attachment_owner(Buffer buf, str label):
return attachment_owner


cdef inline OpaqueHandle _resolve_memcpy_operand(
cdef OpaqueHandle _resolve_memcpy_operand(
object operand, object owner, str side,
cydriver.CUdeviceptr* out_ptr) except *:
"""Resolve an operand to a pointer and optional attachment owner.
Expand Down
Loading