Repository navigation
Trim keywords and drop empty ones - #715
Open
simonvanlierde wants to merge 2 commits into
Open
simonvanlierde wants to merge 2 commits into
simonvanlierde wants to merge 2 commits into
Conversation
- pyproject.toml: strip spaces after commas, skip empty entries - CITATION.cff: same, and leave out keywords when none are left - add tests for both cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Type of change
List of related issues or pull requests
Refs:
Describe the changes made in this pull request
Hi,
As discussed in #627: the
keywordsanswer is split on,but not trimmed, sokw1, second kwgiveskeywords = ["kw1"," second kw"], and an empty answer giveskeywords = [""].pyproject.toml.jinjatrims each keyword and drops empty ones, so an empty answer now giveskeywords = [].keywords:when nothing is left.tests/test_values.py, one per file. Both fail onmainand pass with the change.Tests: the full suite passes on Python 3.12, 3.13 and 3.14 (Linux), apart from
test_ruff_check, which fails onCPY001as it does onmain. #713 fixes that. I couldn't run macOS or Windows.Instructions to review the pull request
Answer
kw1, second kw,for keywords, then checkkeywordsinpyproject.tomlandCITATION.cff.Simon