Repository navigation
feat: mount the Garage API skeleton in the main API - #1924
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Mounts the beta Garage endpoints (
/v1/garage) in the main API for #1899. Access requires theuserDatasetsfeature flag. Also addsgarage_gento the CI and deploy workflows, and a load balancer route for DELETE.Expected behavior:
Every endpoint returns 401 without an identity and 403 without the flag. With the flag it returns 501, or 422 for an invalid body.
Testing tips:
Run
./scripts/api-tests.sh --test_file api/tests/unittest/garage/test_garage_api.py. On dev, grant the flag through the Operations API and callGET /v1/garage/datasets.Please make sure these boxes are checked before submitting your pull request - thanks!
./scripts/api-tests.shto make sure you didn't break anything