Skip to content

feat: mount the Garage API skeleton in the main API - #1924

Merged
davidgamez merged 3 commits into
mainfrom
feat/garage-api-skeleton-main
Nov 19, 2026
Merged

davidgamez merged 3 commits into
mainfrom
feat/garage-api-skeleton-main

Conversation

@davidgamez

Copy link
Copy Markdown
Member

Summary:

Mounts the beta Garage endpoints (/v1/garage) in the main API for #1899. Access requires the userDatasets feature flag. Also adds garage_gen to the CI and deploy workflows, and a load balancer route for DELETE.

Expected behavior:

Every endpoint returns 401 without an identity and 403 without the flag. With the flag it returns 501, or 422 for an invalid body.

Testing tips:

Run ./scripts/api-tests.sh --test_file api/tests/unittest/garage/test_garage_api.py. On dev, grant the flag through the Operations API and call GET /v1/garage/datasets.

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with ./scripts/api-tests.sh to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@davidgamez
davidgamez requested a review from cka-y November 19, 2026 20:50

@cka-y cka-y left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidgamez
davidgamez merged commit 3b5a189 into main Nov 19, 2026
33 checks passed
@davidgamez
davidgamez deleted the feat/garage-api-skeleton-main branch November 19, 2026 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants