Repository navigation
Fix ore generation and upgrades on 1.12.2 - #337
Merged
SkyBlade1978 merged 1 commit intoNov 9, 2026
Merged
SkyBlade1978 merged 1 commit into
SkyBlade1978 merged 1 commit into
Conversation
SkyBlade1978
merged commit Nov 9, 2026
7202b00
into
MinecraftModDevelopmentMods:master-1.12.2
6 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I’ve brought the recent ore fixes to 1.12.2. Mods can now pick an exact host rock, sulfur and lithium defaults account for mods that finish loading later, and old profiles keep their imported ore rule without running an untouched duplicate. Edited rules are left alone and flagged for review.
I tested this build on 1.12.2. All 338 automated tests passed too.