Repository navigation
Fix ore overlays and update the 1.12.2 dependencies - #139
Merged
SkyBlade1978 merged 1 commit intoNov 9, 2026
Conversation
Let the stone show through the ore overlays, switch to the published MMDLib and OreSpawn builds, and restore the missing translations.
SkyBlade1978
merged commit Nov 9, 2026
71e3d99
into
MinecraftModDevelopmentMods:master-1.12
6 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the black background on the 1.12.2 ore blocks so the stone shows through, including with a resource pack. It also moves Modern Metals to the published MMDLib 1.0.0-rc3 and OreSpawn 4.1.6 builds.
The checks passed with and without Base Metals 2.6.2. A copy of an old world kept its ore IDs and crusher outputs. The fork build produced the same game jar as the one used for the overlay test. Fork build