Repository navigation
Bottle experience fluids into Bottles o' Enchanting - #101
Merged
Merged
Conversation
A glass bottle filled with a fluid in NeoForge's #c:experience tag, from the world or a tank, becomes vanilla's Bottle o' Enchanting rather than an MMDLib fluid bottle. It takes 250 mB, the tag's convention, and needs no #mmdlib:bottleable tag. As with other bottleable fluids, a world source is left in place. It is one way: the XP comes back by throwing the bottle, so the bottle has no fluid capability to pour it into a tank. FluidBottles.capacity(fluid) is now the single rule for what a glass bottle takes and how much, and FluidBottles.filled(fluid) for what it becomes. Game tests use molten gold, tagged #c:experience in the test resources. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A glass bottle filled with a fluid in NeoForge's #c:experience tag, from the world or a tank, becomes vanilla's Bottle o' Enchanting rather than an MMDLib fluid bottle. It takes 250 mB, the tag's convention, and needs no #mmdlib:bottleable tag. As with other bottleable fluids, a world source is left in place. It is one way: the XP comes back by throwing the bottle, so the bottle has no fluid capability to pour it into a tank.
FluidBottles.capacity(fluid) is now the single rule for what a glass bottle takes and how much, and FluidBottles.filled(fluid) for what it becomes. Game tests use molten gold, tagged #c:experience in the test resources.