Repository navigation
Bring the Base Minerals update to Minecraft 1.12.2 - #43
Merged
SkyBlade1978 merged 4 commits intoNov 9, 2026
Conversation
SkyBlade1978
merged commit Nov 9, 2026
f13e83c
into
MinecraftModDevelopmentMods:master-1.12
6 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This brings the 1.10 and 1.11 Base Minerals updates across to Minecraft 1.12.2. The seven ores use the same depths and deposit shapes and have KiriCattus's overlays on vanilla stone. This build uses the published MMDLib 1.0.0 RC3 and OreSpawn 4.1.6.112021 jars. Base Metals is optional. I tested its hammer on the ores using the new Eclipse launch with Base Metals 2.6.2.112021.
The client and server checks passed, including both settings screens, saved stacks and Tinkers casting. All four generation seeds produced the seven ores at the expected heights, and the shared-ore checks passed with Base Electric and Mineralogy. The local timing run was 16.9% slower than the old rules, inside the 20% limit.
OreSpawn 3 settings import directly. For an OreSpawn 1 world, import the settings on 1.10.2 or 1.11.2 and bring the saved profile across. The upgrade check kept the lithium rule and settings on a copy of the 1.11.2 world.
The CurseForge workflow now covers 1.12.2 and checks the tested jar hash against the successful merged build before uploading.