Repository navigation
Conversation
Collaborator
Author
|
@vincent-noel and others more familiar with PhysiMeSS should comment before merging. |
marcorusc
added a commit
to PhysiMeSS/PhysiMeSS
that referenced
this pull request
Nov 17, 2026
…a cell The adhesion to a fibre and the drag by its contact were computed from the previous velocity of the cell and added once per fibre. - the velocity of a cell between two fibres could diverge (more than 100 micron in one minute with the default parameters). As proposed in MathCancer#443: the adhesion factor is limited to positive values, and the previous velocity is no longer subtracted per fibre; the strongest contact damps the motility across that fibre, once - the adhesion always pushed the cell along the stored orientation of the fibre, whatever the direction of the cell: a cell was accelerated along a fibre in one direction and blocked in the other. It is now along the fibre in the direction of motion (not in the PhysiCell PR) The three formulas are in PhysiMeSS_geometry.h with 8 unit tests. MODEL_CHANGES.md: new section 4. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Contributor
|
Hi Randy. I reproduced the problem and tested the fix while working on the 3d branch of PhysiMeSS ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sample_projects/physimess/config/Cell_Fibre_Mechanics/test_2fibres.{xml,csv}to testsample_projects/physimess/config/Cell_Fibre_Mechanics/fibre_rotating.xmlto match https://doi.org/10.46471/gigabyte.136This image illustrates the undesirable result from the original code, using the test_2fibres.xml. It shows a single cell between 2 fibers, chemotaxing to the secreting cell at the bottom. The left plot is the .svg plot, showing the fibers as rods. The right plot, from the Studio, shows the "trapped" cell's large velocity (magnitude > 1000) from a custom_data variable (requiring a custom.cpp, not in this PR). And unfortunately, the right (Studio) plot just plots the fibers as circles instead of rods.