Skip to content

refactor: solve new linter issues after dependency update - #4346

Open
KristjanESPERANTO wants to merge 3 commits into
MagicMirrorOrg:developfrom
KristjanESPERANTO:deps-eslint
Open

KristjanESPERANTO wants to merge 3 commits into
MagicMirrorOrg:developfrom
KristjanESPERANTO:deps-eslint

Conversation

@KristjanESPERANTO

Copy link
Copy Markdown
Collaborator

Originally I intended only to update the dependencies. But the new @stylistic/eslint-plugin major-version introduced deprecation warnings and surfaced new lint issues in the code. I fixed those and used the opportunity to simplify the ESLint config and align the rules for .js and .mjs files.

Comment thread eslint.config.mjs
},
{
files: ["**/*.js", "defaultmodules/defaultmodules.mjs", "defaultmodules/calendar/calendarutils.mjs", "js/app.mjs", "js/deprecated.mjs", "js/electron_helper.mjs", "js/http_fetcher.mjs", "js/ip_access_control.mjs", "js/releasenotes.mjs", "js/server.mjs", "js/server_functions.mjs", "js/vendor.mjs", "tests/**/*.mjs"],
files: ["**/*.{js,mjs}"],

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we ok with this simplification? will stuff be included that we dont want in there?

Comment thread eslint.config.mjs
},
{
files: ["**/*.js", "defaultmodules/defaultmodules.mjs", "defaultmodules/calendar/calendarutils.mjs", "js/app.mjs", "js/deprecated.mjs", "js/electron_helper.mjs", "js/http_fetcher.mjs", "js/ip_access_control.mjs", "js/releasenotes.mjs", "js/server.mjs", "js/server_functions.mjs", "js/vendor.mjs", "tests/**/*.mjs"],
files: ["**/*.{js,mjs}"],

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants