Skip to content

fix(http_fetcher): show "no connection" only when offline - #4345

Merged
rejas merged 1 commit into
MagicMirrorOrg:developfrom
KristjanESPERANTO:offline
Nov 15, 2026
Merged

rejas merged 1 commit into
MagicMirrorOrg:developfrom
KristjanESPERANTO:offline

Conversation

@KristjanESPERANTO

Copy link
Copy Markdown
Collaborator

While investigating #4343 I noticed that with a wrong URL the calendar module showed No internet connection., which is factually wrong and misleading.

I looked into the code and improved it: No internet connection. is now only shown for errors that really mean the network is down. Everything else shows Check logs for more details. instead.

@rejas
rejas merged commit b7481b8 into MagicMirrorOrg:develop Nov 15, 2026
13 checks passed
@KristjanESPERANTO
KristjanESPERANTO deleted the offline branch November 15, 2026 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants