Repository navigation
Conversation
Documentation build overview
5 files changed ·
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5546 +/- ##
========================================
Coverage 93.93% 93.94%
========================================
Files 184 184
Lines 22675 22681 +6
Branches 3227 3229 +2
========================================
+ Hits 21300 21307 +7
+ Misses 915 914 -1
Partials 460 460 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Author
|
please have a look at this ive completed the fix and added a regression test covering early iterator closure when ProgressBar is disabled. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5540
Changes made in this Pull Request
ProgressBar.__iter__()now uses a regularforloop instead ofyield fromwhen the progress display is disabled.yield fromforwardsgenerator closure to the wrapped iterator, which closed the
TrajectoryReader when iteration was interrupted (tqdm >= 4.70).
after a disabled
ProgressBarloop is exited early.package/CHANGELOGentry under Fixes and added myself topackage/AUTHORS.Testing
python -m pytest testsuite/MDAnalysisTests/lib/test_log.py -q: 4 passedpython -m pytest testsuite/MDAnalysisTests/lib -q: 9950 passed, 3 skippedLLM / AI generated code disclosure
I used AI to help investigate the bug and understand its root cause, and to
help draft this PR description.
PR Checklist
package/CHANGELOGfile updated?package/AUTHORS? (If it is not, add it!)Developers Certificate of Origin
I certify that I can submit this code contribution as described in the Developer Certificate of Origin, under the MDAnalysis LICENSE.